[MERGE] WCCPv2 Config Cleanup

2008-09-12 Thread Amos Jeffries
WCCP config cleanups mk2 - clean of the additional extras slipped in last time. - corrected according to Adrians updated info Amos # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: [EMAIL PROTECTED] # target_branch: file:///src/squid/bzr/trunk/ # testament_sha1:

Re: Cleanup patches to follow

2008-09-12 Thread Alex Rousskov
On Wed, 2008-09-10 at 23:42 -0600, Alex Rousskov wrote: If the code is committed, I will go through affected bug reports (that I know of) and update or close them. Done. If I missed any affected bugs, please point me to them. Finally, I am aware of one unreported(?) problem related to the

header_access directive in Squid3/HEAD

2008-09-12 Thread Ritter, Nicholas
Was the header_access directive/functionality removed or otherwise broken in Squid3/HEAD? I am using squid-3.HEAD-20080910 with the following config lines: acl appsds_ctl url_regex -i ^http://apps.ds.atv/ request_header_access Cache-Control deny appsds_ctl header_access Cache-Control deny

Re: header_access directive in Squid3/HEAD

2008-09-12 Thread Alex Rousskov
On Fri, 2008-09-12 at 12:44 -0500, Ritter, Nicholas wrote: Was the header_access directive/functionality removed or otherwise broken in Squid3/HEAD? I am using squid-3.HEAD-20080910 with the following config lines: acl appsds_ctl url_regex -i ^http://apps.ds.atv/ request_header_access

Re: broken regex, refresh_pattern, or request_/reply_header?

2008-09-12 Thread Henrik Nordstrom
the *_header_access directives can only change the external view of the headers sent by Squid, not how Squid parses received headers. To override bad things sent by client or server you need to use refresh_pattern overrides. In your case both the ignore-reload and ignore-private overrides. Be

Re: apologies for spamming squid-dev with apologies for spamming squid-dev with commit messages

2008-09-12 Thread Henrik Nordstrom
On tor, 2008-09-11 at 23:07 -0600, Alex Rousskov wrote: It looks like I mistook the Reply-To: email header for a To: header. I was not really sending those commit messages to squid-dev, just to squid-cvs. So I was not really spamming. Until now... No problem. Got me a little confused there

Re: Where to document APIs?

2008-09-12 Thread Henrik Nordstrom
On tor, 2008-09-11 at 09:54 -0600, Alex Rousskov wrote: You mean as a large blob of comments at the end of some .h file? The cons are: I think Adrian is thinking more of blobs next to the implementations (.cc) As time has passed a little I have this slightly refined view: * Overview type

Re: pseudo-specs for a String class: tokenization

2008-09-12 Thread Henrik Nordstrom
On tor, 2008-09-11 at 10:03 -0600, Alex Rousskov wrote: You made the right choice. The modifying methods modify their object approach is more efficient and should be expected by most C++ developers. Yes, the other approach (return a new object) is used mainly for operators. C = A + B;

Re: [MERGE] WCCPv2 Config Cleanup

2008-09-12 Thread Henrik Nordstrom
On fre, 2008-09-12 at 20:39 +1200, Amos Jeffries wrote: +#define WCCP2_FORWARDING_METHOD_GRE WCCP2_METHOD_GRE +#define WCCP2_FORWARDING_METHOD_L2 WCCP2_METHOD_L2 +#define WCCP2_PACKET_RETURN_METHOD_GRE WCCP2_METHOD_GRE +#define WCCP2_PACKET_RETURN_METHOD_L2WCCP2_METHOD_L2

Re: Where to document APIs?

2008-09-12 Thread Alex Rousskov
On Fri, 2008-09-12 at 22:28 +0200, Henrik Nordstrom wrote: On tor, 2008-09-11 at 09:54 -0600, Alex Rousskov wrote: You mean as a large blob of comments at the end of some .h file? The cons are: I think Adrian is thinking more of blobs next to the implementations (.cc) As time has

Re: [MERGE] WCCPv2 Config Cleanup

2008-09-12 Thread Adrian Chadd
The specification defines them as separate entities and using them in this fashion makes it clearer for people working on the code. Adrian 2008/9/13 Henrik Nordstrom [EMAIL PROTECTED]: On fre, 2008-09-12 at 20:39 +1200, Amos Jeffries wrote: +#define WCCP2_FORWARDING_METHOD_GRE

Re: [MERGE] WCCPv2 Config Cleanup

2008-09-12 Thread Henrik Nordstrom
With the patch the code uses WCCP2_METHOD_.. in some places (config parsing/dumping) and the context specific ones in other places. This is even more confusing. Very minor detail in any case. On lör, 2008-09-13 at 09:49 +0800, Adrian Chadd wrote: The specification defines them as separate

Re: apologies for spamming squid-dev with apologies for spamming squid-dev with commit messages

2008-09-12 Thread Amos Jeffries
Henrik Nordstrom wrote: On tor, 2008-09-11 at 23:07 -0600, Alex Rousskov wrote: It looks like I mistook the Reply-To: email header for a To: header. I was not really sending those commit messages to squid-dev, just to squid-cvs. So I was not really spamming. Until now... No problem. Got me

Re: [MERGE] WCCPv2 Config Cleanup

2008-09-12 Thread Adrian Chadd
Amos, why are you pushing through changes to the WCCP configuration stuff at this point in the game? The WCCPv2 stuff works fine (for what it does); it could do with some better documentation but what it really needs is to be broken out from Squid itself and run as a seperate daemon. Adrian

Re: squid-2.HEAD: storeCleanup and -F option (foreground rebuild)

2008-09-12 Thread Adrian Chadd
I've committed a slightly modified version of this - store_rebuild.c r1.80 . Take a look and see if it works for you. Thanks! Adrian 2008/8/5 Alexander V. Lukyanov [EMAIL PROTECTED]: Hello! I use squid in transparent mode, so I don't want degraded performance while rebuilding and cleanup.

Re: squid-2.HEAD: fwdComplete/Fail before comm_close

2008-09-12 Thread Adrian Chadd
Hiya, Could you please verify this is still a problem in the latest 2.HEAD and if so lodge a bugzilla bug report with the patch? Thanks! Adrian 2008/8/5 Alexander V. Lukyanov [EMAIL PROTECTED]: Hello! Some time ago I had core dumps just after these messages: Short response from

Re: squid-2.HEAD:

2008-09-12 Thread Adrian Chadd
have you dumped this into bugzilla? Thanks! 2008/9/3 Alexander V. Lukyanov [EMAIL PROTECTED]: Hello! I have noticed lots of 'impossible keep-alive' messages in the log. It appears that httpReplyBodySize incorrectly returns -1 for 304 Not Modified replies. Patch to fix it is attached. --