Re: SBuf review at r9370

2009-02-26 Thread Alex Rousskov
On 02/26/2009 10:24 AM, Kinkie wrote: On Thu, Feb 26, 2009 at 1:46 AM, Alex Rousskov rouss...@measurement-factory.com wrote: http://bazaar.launchpad.net/~kinkie/squid/stringng at r9370. * Remove isLiteral and the corresponding code/logic. We might add this very minor performance

Re: Feature: quota control

2009-02-26 Thread Adrian Chadd
I'm looking at implementing this as part of a contract for squid-2. I was going to take a different approach - that is, i'm not going to implement quota control or management in squid; I'm going to provide the hooks to squid to allow external controls to handle the quota. adrian 2009/2/21

Re: Feature: quota control

2009-02-26 Thread Mark Nottingham
Isn't requests really just an external acl helper? On 27/02/2009, at 8:36 AM, Adrian Chadd wrote: I'm looking at implementing this as part of a contract for squid-2. I was going to take a different approach - that is, i'm not going to implement quota control or management in squid; I'm going

Re: Feature: quota control

2009-02-26 Thread Robert Collins
Key things I'd look for: - quota's shouldn't be lost when squid restarts - people should be able to use external quota systems (they may have e.g. netflow or other systems tracking direct b/w use, and squid is pulling from those allowances when downloads are caused by a given user).

Re: Feature: quota control

2009-02-26 Thread Mark Nottingham
Honestly, if I wanted to do byte-based quotas today, I'd have an external ACL helper talking to an external logging helper; that way, you can just log the response sizes to a daemon and then another daemon would use that information to make a decision at access time. The only even mildly

Re: Feature: quota control

2009-02-26 Thread Mark Nottingham
I was talking about request number quotas (e.g., you can make n requests in m minutes). Regarding byte quotes -- see subsequent message -- I disagree that you need eCAP :) On 27/02/2009, at 10:00 AM, Kinkie wrote: On Thu, Feb 26, 2009 at 11:23 PM, Mark Nottingham m...@yahoo- inc.com

Re: Feature: quota control

2009-02-26 Thread Alex Rousskov
On 02/26/2009 04:04 PM, Mark Nottingham wrote: I was talking about request number quotas (e.g., you can make n requests in m minutes). Regarding byte quotes -- see subsequent message -- I disagree that you need eCAP :) eCAP is one way of doing byte- and/or count- quotas, but there are, of

Re: Feature: quota control

2009-02-26 Thread Kinkie
On Thu, Feb 26, 2009 at 11:23 PM, Mark Nottingham m...@yahoo-inc.com wrote: Isn't requests really just an external acl helper? Not really.. an external ACL helper would need to do real-time parsing of the logs to really know how much each client downloaded, as AFAIK both request and reply acl's

Re: SBuf review at r9370

2009-02-26 Thread Amos Jeffries
Kinkie wrote: On Thu, Feb 26, 2009 at 1:46 AM, Alex Rousskov rouss...@measurement-factory.com wrote: Hi Kinkie, Here are a few corrections for http://bazaar.launchpad.net/~kinkie/squid/stringng at r9370. * Remove isLiteral and the corresponding code/logic. We might add this very minor

Re: Feature: quota control

2009-02-26 Thread Amos Jeffries
Robert Collins wrote: On Fri, 2009-02-27 at 10:00 +1100, Mark Nottingham wrote: Honestly, if I wanted to do byte-based quotas today, I'd have an external ACL helper talking to an external logging helper; that way, you can just log the response sizes to a daemon and then another daemon

Re: SBuf review at r9370

2009-02-26 Thread Alex Rousskov
On 02/26/2009 08:46 PM, Amos Jeffries wrote: Kinkie wrote: * Please use .length() everywhere you can. Do not mix .len_ and .length(). Ok, checked. I've left len_ where it's being assigned to another object's len_ or in very low-level stuff (e.g. object dumping, stuff doing pointer maths).

[PATCH] Uninstall configuration files

2009-02-26 Thread Alex Rousskov
Hello, Please review the attached patch. The patched Makefiles delete installed configuration files, restoring functionality removed from Squid some time ago, but hopefully in a safer manner. This is the cleanest way I could find to make make distcheck work again (with the other pending

Re: [PATCH] Uninstall configuration files

2009-02-26 Thread Bundle Buggy
Bundle Buggy has detected this merge request. For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C49A77084.20304%40measurement-factory.com%3E Project: Squid

RFC: add distcheck to test-builds.sh

2009-02-26 Thread Alex Rousskov
Hello, With the recent SourceLayout and distclean cleanup, make distcheck is working again. I would like to decrease the chance that it gets broken. Any objections to adding that check to test-builds.sh? It will double the script running time, but I think it is worth it and appropriate for a