Re: [PATCH] Uninstall configuration files

2009-02-27 Thread Amos Jeffries
Alex Rousskov wrote: Hello, Please review the attached patch. The patched Makefiles delete installed configuration files, restoring functionality removed from Squid some time ago, but hopefully in a safer manner. This is the cleanest way I could find to make make distcheck work again (with

Re: RFC: add distcheck to test-builds.sh

2009-02-27 Thread Amos Jeffries
Alex Rousskov wrote: Hello, With the recent SourceLayout and distclean cleanup, make distcheck is working again. I would like to decrease the chance that it gets broken. Any objections to adding that check to test-builds.sh? It will double the script running time, but I think it is worth it

Re: RFC: add distcheck to test-builds.sh

2009-02-27 Thread Alex Rousskov
On 02/27/2009 04:45 AM, Amos Jeffries wrote: Alex Rousskov wrote: With the recent SourceLayout and distclean cleanup, make distcheck is working again. I would like to decrease the chance that it gets broken. Any objections to adding that check to test-builds.sh? Not quite yet. I did

Re: SBuf review at r9370

2009-02-27 Thread Kinkie
Um, IMO its better to be liberal with length() and very,very conservative with len_. I think I reached a sensible compromise, however subjective. I ask you not to be too strict now, but to feel free to change it after the branch lands into trunk. Dumping stuff and pointer maths particularly

Re: RFC: add distcheck to test-builds.sh

2009-02-27 Thread Amos Jeffries
Alex Rousskov wrote: On 02/27/2009 04:45 AM, Amos Jeffries wrote: Alex Rousskov wrote: With the recent SourceLayout and distclean cleanup, make distcheck is working again. I would like to decrease the chance that it gets broken. Any objections to adding that check to test-builds.sh? Not quite

Re: SBuf review at r9370

2009-02-27 Thread Amos Jeffries
Kinkie wrote: Um, IMO its better to be liberal with length() and very,very conservative with len_. I think I reached a sensible compromise, however subjective. I ask you not to be too strict now, but to feel free to change it after the branch lands into trunk. Dumping stuff and pointer maths