Re: [PATCH] Add cpu_affinity_map configuration option to bind workers to cores

2010-09-20 Thread Amos Jeffries
On Mon, 20 Sep 2010 17:44:17 -0600, Alex Rousskov wrote: > > This is take10 of the patch, addressing Amos' comments as discussed below: > > On 09/14/2010 12:00 AM, Amos Jeffries wrote: > >> * does cpuAffinityMap = NULL in free_CpuAffinityMap not work? NULL is >> not always 0. > > Fixed. The

Re: [PATCH] HTTP Compliance: Make date parser more strict to better handle extended Expires

2010-09-20 Thread Amos Jeffries
On Mon, 20 Sep 2010 10:33:45 -0600, Alex Rousskov wrote: > HTTP Compliance: Make date parser more strict to better handle extended > Expires > > Check that there is no zone or zone is "GMT" in parse_date_elements(). > Make sure there is no junk at the end of date in parse_date(). > > Co-Advisor

Re: StringNg review: MemBlob

2010-09-20 Thread Alex Rousskov
On 09/03/2010 09:21 AM, Kinkie wrote: You'll find the branch at lp:~kinkie/squid/stringng I decided to take a look at MemBlob because it is used by SBuf which was reviewed a few days ago. It would be nice to get a fixed SBuf committed, but that would require committing the classes it uses.

[PATCH] Add cpu_affinity_map configuration option to bind workers to cores

2010-09-20 Thread Alex Rousskov
Add cpu_affinity_map configuration option to bind workers to CPU cores. Allows the admin to place all workers on individual cores without writing a lot of if-statements. For example, cpu_affinity_map process_numbers=1,2,3,4 cores=1,3,5,7 will have an effect for kids 1 through 4 only and w

Re: [PATCH] comm cleanup mk8 - src/comm only

2010-09-20 Thread Alex Rousskov
On 09/19/2010 05:35 AM, Amos Jeffries wrote: Round 2 of only src/comm/ changes. I believe this accounts for all the bits requested to date. Including adding Subscriptions for ConnAcceptor. * The patch is missing the new Subscription class. Based on your subject line, I am guessing you will po

Build failed in Hudson: 3.HEAD-i386-OpenBSD #575

2010-09-20 Thread noc
See Changes: [Henrik Nordstrom ] Bug 3056 - comm.cc "!fd_table[fd].closing()" assertion from helperServerFree when a helper crashes while processing requests reshuffle helperServerFree so it first unregisters the failed helper

bzr usage update

2010-09-20 Thread Henrik Nordström
A small bzr usage update. When committing bugfixes please use "bzr commit --fixes squid:". You need a little configuration to enable the squid bugtracker. In $HOME/.bazaar/bazaar.conf add [DEFAULT] bugzilla_squid_url = http://bugs.squid-cache.org You can add as many --fixes arguments as needed.

Build failed in Hudson: 3.HEAD-i386-OpenBSD #574

2010-09-20 Thread noc
See Changes: [Alex Rousskov ] Bug #3048 fix: "commio_has_callback(fd, IOCB_READ, ccb)" assertion; may also be applicable to a similar IOCB_WITE assertion. When we start closing a descriptor, we call commio_finish_callback() to r

Re: HTTP Compliance: do not remove ETag header from partial responses

2010-09-20 Thread Henrik Nordström
mån 2010-09-20 klockan 10:26 -0600 skrev Alex Rousskov: > HTTP Compliance: do not remove ETag header from partial responses > > RFC 2616 section 10.2.7 says that partial responses MUST include ETag > header, if it would have been sent in a 200 response to the same request. Oh! Is that still in Sq

[PATCH] HTTP Compliance: Reply with an error if required validation failed

2010-09-20 Thread Alex Rousskov
HTTP Compliance: Reply with an error if required validation failed RFC 2616 says that proxy MUST not use stale entries that have s-maxage, proxy-revalidate, or must-revalidate cache-directive. Add new fail_on_validation_err request flag to store result from refreshCheck(). It is needed to av

[PATCH] HTTP Compliance: Make date parser more strict to better handle extended Expires

2010-09-20 Thread Alex Rousskov
HTTP Compliance: Make date parser more strict to better handle extended Expires Check that there is no zone or zone is "GMT" in parse_date_elements(). Make sure there is no junk at the end of date in parse_date(). Co-Advisor test case: test_case/rfc2616/invalidExpiresMakesStale-rfc1123x HTT

HTTP Compliance: do not remove ETag header from partial responses

2010-09-20 Thread Alex Rousskov
HTTP Compliance: do not remove ETag header from partial responses RFC 2616 section 10.2.7 says that partial responses MUST include ETag header, if it would have been sent in a 200 response to the same request. Co-Advisor test cases: test_case/rfc2616/scHdrs-206-include-explicit-withVary-noIf

Hello8

2010-09-20 Thread John Smith
Hello, What have you been up to ? Tell you a good news. At last few days,My friend Jack told me where was called the factory of world.All the things is very cheap. Register to be their members as soon as possible, during this time, they have discount sales, many surprises are waiting for you. w