Re: Store_url_rewrite for squid 3+

2012-09-09 Thread Eliezer Croitoru
On 09/08/2012 01:36 AM, Alex Rousskov wrote: On 09/07/2012 01:32 PM, Eliezer Croitoru wrote: On 09/07/2012 05:10 PM, Alex Rousskov wrote: I am not sure what option you are referring to in the above. The Store::get(key) API I have described is not optional -- it is the primary

Re: Store_url_rewrite for squid 3+

2012-09-09 Thread Amos Jeffries
On 9/09/2012 4:19 a.m., Alex Rousskov wrote: On 09/07/2012 09:13 PM, Amos Jeffries wrote: Also, any revalidation requests done later must be done on the original request URL. Not the stored URL nor the potentially different current client request URL. This sounds like a very important point

Re: ICAP connections under heavy loads

2012-09-09 Thread Amos Jeffries
On 9/09/2012 8:30 p.m., Amos Jeffries wrote: On 9/09/2012 5:03 a.m., Alex Rousskov wrote: On 09/07/2012 09:51 PM, Amos Jeffries wrote: On 8/09/2012 3:17 a.m., Alex Rousskov wrote: On 09/07/2012 08:33 AM, Alexander Komyagin wrote: However, as I stated earlier, the comm.cc problem (actually

Re: [RFC] CONNECT and use_ssl cache_peer

2012-09-09 Thread Amos Jeffries
On 9/09/2012 3:54 a.m., Alex Rousskov wrote: On 09/07/2012 10:38 PM, Amos Jeffries wrote: On 8/09/2012 3:54 p.m., Alex Rousskov wrote: Hello, I came upon a Squid proxy configured with cache_peer ssl (i.e., peer-use_ssl is true). The proxy forwards GETs to the peer using an SSL

[PATCH]proposal for a fake_strore_url helper wrapping.

2012-09-09 Thread Eliezer Croitoru
I took the url_rewrite helper and used what ever seems needed to create a url_store_rewrite helper. I also added the needed variables for the next step and freeing them where and if needed. this is a more of a basic sketch. Eliezer === modified file 'src/ClientRequestContext.h' ---

Re: ICAP connections under heavy loads

2012-09-09 Thread Alexander Komyagin
On Fri, 2012-09-07 at 09:17 -0600, Alex Rousskov wrote: On 09/07/2012 08:33 AM, Alexander Komyagin wrote: On Fri, 2012-09-07 at 08:15 -0600, Alex Rousskov wrote: On 09/07/2012 02:32 AM, Alexander Komyagin wrote: However, as I stated earlier, the comm.cc problem (actually semantics

Re: [PATCH]proposal for a fake_strore_url helper wrapping.

2012-09-09 Thread Amos Jeffries
On 9/09/2012 10:08 p.m., Eliezer Croitoru wrote: I took the url_rewrite helper and used what ever seems needed to create a url_store_rewrite helper. I also added the needed variables for the next step and freeing them where and if needed. this is a more of a basic sketch. Eliezer You dont

Re: [PATCH]proposal for a fake_strore_url helper wrapping. +fixes

2012-09-09 Thread Eliezer Croitoru
On 9/9/2012 2:54 PM, Amos Jeffries wrote: On 9/09/2012 10:08 p.m., Eliezer Croitoru wrote: I took the url_rewrite helper and used what ever seems needed to create a url_store_rewrite helper. I also added the needed variables for the next step and freeing them where and if needed. this is a more

Re: [PATCH]fix to the fix

2012-09-09 Thread Eliezer Croitoru
Fix those and I think this is a good part-1 patch that can be applied to trunk. Amos found missing declaration in the flags struct. a fixed patch included. === modified file 'src/ClientRequestContext.h' --- src/ClientRequestContext.h 2012-08-14 11:53:07 + +++ src/ClientRequestContext.h

Re: [PATCH]fix to the fix - was a typo.

2012-09-09 Thread Eliezer Croitoru
On 09/09/2012 06:31 PM, Eliezer Croitoru wrote: Fix those and I think this is a good part-1 patch that can be applied to trunk. Amos found missing declaration in the flags struct. a fixed patch included. and a tiny tiny really weird typo. === modified file 'src/ClientRequestContext.h'

Re: Store_url_rewrite for squid 3+

2012-09-09 Thread Eliezer Croitoru
On 09/06/2012 03:58 AM, Amos Jeffries wrote: I don't think there is anything which needs new cache_cf.cc code. The parsing side if things is identical for url_rewrite_*. The different defaults and locations are all coded in cf.data.pre ... yes indeed but the actual effect comes from the

Re: BZR repository upgrade re-proposal.

2012-09-09 Thread Kinkie
I'm glad that a consensus is forming. The next question would then be who will perform the upgrade, and when - assuming noone speaks up against it. This friday? +1 :) +1. It seems that the schedule was missed. When is the next chance? Thanks, -- /kinkie

Re: [PATCH]I will have more look at it tommorrow

2012-09-09 Thread Eliezer Croitoru
On 09/09/2012 07:06 PM, Eliezer Croitoru wrote: On 09/09/2012 06:31 PM, Eliezer Croitoru wrote: Fix those and I think this is a good part-1 patch that can be applied to trunk. Amos found missing declaration in the flags struct. a fixed patch included. and a tiny tiny really weird typo.

Re: BZR repository upgrade re-proposal.

2012-09-09 Thread Henrik Nordström
sön 2012-09-09 klockan 19:15 +0200 skrev Kinkie: It seems that the schedule was missed. Yes. Been ill since friday. Combination of sleep deprivation and a cold taking it's poll. When is the next chance? Haven't seen any indications of any remaining reasons to not being able to switch.

Re: BZR repository upgrade re-proposal.

2012-09-09 Thread Kinkie
On Sun, Sep 9, 2012 at 9:36 PM, Henrik Nordström hen...@henriknordstrom.net wrote: sön 2012-09-09 klockan 19:15 +0200 skrev Kinkie: It seems that the schedule was missed. Yes. Been ill since friday. Combination of sleep deprivation and a cold taking it's poll. Sorry to hear that. Get well

Re: [PATCH]proposal for a fake_strore_url helper wrapping. +fixes

2012-09-09 Thread Amos Jeffries
On 10.09.2012 01:12, Eliezer Croitoru wrote: On 9/9/2012 2:54 PM, Amos Jeffries wrote: ++ It is questionable whether the store-URL should also be below the no_cache_done bits as well. Since requests withcache deny are not going to be loaded from cache, but maybe they will be stored later

Re: Store_url_rewrite for squid 3+

2012-09-09 Thread Amos Jeffries
On 10.09.2012 04:56, Eliezer Croitoru wrote: On 09/06/2012 03:58 AM, Amos Jeffries wrote: I don't think there is anything which needs new cache_cf.cc code. The parsing side if things is identical for url_rewrite_*. The different defaults and locations are all coded in cf.data.pre ... yes

Re: [RFC] CONNECT and use_ssl cache_peer

2012-09-09 Thread Henrik Nordström
sön 2012-09-09 klockan 21:34 +1200 skrev Amos Jeffries: Henrik and I seem to disagree on this being a good idea being plugged into BodyPipe. But as I see it BodyPipe is where Upgrade, WebSockets and SSL-Bump should be happening in a node which internally receives the tunnel connection and

Re: [RFC] CONNECT and use_ssl cache_peer

2012-09-09 Thread Amos Jeffries
On 10.09.2012 13:08, Henrik Nordström wrote: sön 2012-09-09 klockan 21:34 +1200 skrev Amos Jeffries: Henrik and I seem to disagree on this being a good idea being plugged into BodyPipe. But as I see it BodyPipe is where Upgrade, WebSockets and SSL-Bump should be happening in a node which

Build failed in Jenkins: 3.2-matrix » obsd-51-x86 #263

2012-09-09 Thread noc
See http://build.squid-cache.org/job/3.2-matrix/./label=obsd-51-x86/263/ -- Started by upstream project 3.2-matrix build number 263 Building remotely on obsd-51-x86 in workspace http://build.squid-cache.org/job/3.2-matrix/./label=obsd-51-x86/ws/

Build failed in Jenkins: 3.2-matrix » opensuse-x64 #263

2012-09-09 Thread noc
See http://build.squid-cache.org/job/3.2-matrix/./label=opensuse-x64/263/changes Changes: [Amos Jeffries] Bug 3615: configure check for default max number of FDs is broken [Amos Jeffries] Fix maximum_single_addr_tries upgrade [Amos Jeffries] Bug 3622: peerClearRRStart scheduling multiple