Re: MD5 and URL validation (continue to other very old thread)

2012-11-22 Thread Henrik Nordström
ons 2012-11-21 klockan 21:06 +0200 skrev Eliezer Croitoru: The problem is that it only being checked while a file is being fetched from UFS(what I have checked) while from RAM it wont be checked. There is no risk of object store displacement in RAM. The result is that when store_url_rewrite

Re: [PATCH] SSL server certificate fingerprint ACL type

2012-11-22 Thread Amos Jeffries
On 22/11/2012 9:15 a.m., Tsantilas Christos wrote: If there is not any objection I will commit this patch to trunk Sorry, please hold a day or so. I have not gotten around to auditing these. Will do this one tomorrow. Amos

Re: [PATCH] SSL server certificate validator implementation

2012-11-22 Thread Amos Jeffries
On 22/11/2012 9:14 a.m., Tsantilas Christos wrote: If there is not any objection I will commit this patch plus the cert validation cache patches to trunk Sorry. I have not gotten around to auditing these yet. Thanks for the reminder I just did a quick check... ** please update the wiki

Re: [PATCH] match empty header field values using req_header

2012-11-22 Thread Amos Jeffries
On 22/11/2012 2:44 p.m., Alex Rousskov wrote: Hello, Squid req_header ACL cannot match valid HTTP headers with empty values. The attached patch makes it possible. I tried to limit the changes to address this specific use case. It would be good to also review other HttpHeader::get*() uses

Re: [PATCH] SSL server certificate validator implementation

2012-11-22 Thread Tsantilas Christos
One-two clarifications On 11/22/2012 02:10 PM, Amos Jeffries wrote: On 22/11/2012 9:14 a.m., Tsantilas Christos wrote: * please enable concurrency by default. Since this is a new interface we have no legacy excuses to hold us back on good performance. Not a real concurrency. It is just a

Testing ssl-bump-server-first with an upstream proxy

2012-11-22 Thread Steve Hill
I'm currently testing the SSL bump-server-first functionality in Squid 3.3.0.1-20121122-r12391. I have an upstream proxy with never-direct allow all set (the reasons for this are slightly convoluted :). When making a bumped request, Squid bombs with: 2012/11/22 17:53:57 kid1| assertion

Re: [PATCH] SSL server certificate validator implementation

2012-11-22 Thread Amos Jeffries
On 23/11/2012 5:56 a.m., Tsantilas Christos wrote: One-two clarifications On 11/22/2012 02:10 PM, Amos Jeffries wrote: On 22/11/2012 9:14 a.m., Tsantilas Christos wrote: * please enable concurrency by default. Since this is a new interface we have no legacy excuses to hold us back on good

Re: Testing ssl-bump-server-first with an upstream proxy

2012-11-22 Thread Amos Jeffries
On 23/11/2012 7:15 a.m., Steve Hill wrote: I'm currently testing the SSL bump-server-first functionality in Squid 3.3.0.1-20121122-r12391. I have an upstream proxy with never-direct allow all set (the reasons for this are slightly convoluted :). When making a bumped request, Squid bombs

Re: MD5 and URL validation (continue to other very old thread)

2012-11-22 Thread Eliezer Croitoru
On 11/22/2012 10:35 AM, Henrik Nordström wrote: ons 2012-11-21 klockan 21:06 +0200 skrev Eliezer Croitoru: The problem is that it only being checked while a file is being fetched from UFS(what I have checked) while from RAM it wont be checked. There is no risk of object store displacement in

Re: MD5 and URL validation (continue to other very old thread)

2012-11-22 Thread Amos Jeffries
On 23/11/2012 3:49 p.m., Eliezer Croitoru wrote: On 11/22/2012 10:35 AM, Henrik Nordström wrote: ons 2012-11-21 klockan 21:06 +0200 skrev Eliezer Croitoru: The problem is that it only being checked while a file is being fetched from UFS(what I have checked) while from RAM it wont be checked.

Re: MD5 and URL validation (continue to other very old thread)

2012-11-22 Thread Eliezer Croitoru
The last post I wrote with the very very long diff seems to be the one. But since there was a change in the helpers and other stuff in the code I now so to speak have a working MODEL for in memory cache well tested. It has been like that for a about one month. When this TCP_SWAP_FAIL stroked

Re: [PATCH] HelperReply upgrade stage 2

2012-11-22 Thread Amos Jeffries
On 11/11/2012 6:28 p.m., Amos Jeffries wrote: Updated patch attache, containing the updates below... If there is no objections I will commit this to trunk soon. It has passed 10+ days with no additional followup. Amos On 11/11/2012 1:37 p.m., Alex Rousskov wrote: On 11/10/2012 04:14 AM,

Re: MD5 and URL validation (continue to other very old thread)

2012-11-22 Thread Amos Jeffries
On 23/11/2012 4:20 p.m., Eliezer Croitoru wrote: The last post I wrote with the very very long diff seems to be the one. You referring to the email of 24th Oct? You said that was not quite ready and I can see a lot of formatting bits with missing lines which But since there was a change in

Re: MD5 and URL validation (continue to other very old thread)

2012-11-22 Thread Eliezer Croitoru
On 11/23/2012 7:29 AM, Amos Jeffries wrote: On 23/11/2012 4:20 p.m., Eliezer Croitoru wrote: The last post I wrote with the very very long diff seems to be the one. You referring to the email of 24th Oct? You said that was not quite ready and I can see a lot of formatting bits with missing