Re: [PATCH] AND and OR ACLs

2012-12-26 Thread Tsantilas Christos
On 12/22/2012 12:10 AM, Alex Rousskov wrote: On 12/21/2012 02:21 PM, Tsantilas Christos wrote: On 12/21/2012 08:58 PM, Alex Rousskov wrote: Christos, I wonder if we can avoid code duplication by moving existing AND and OR logic from Checklist into a new ACL node type and then _always_

Default behavior for --enable-esi?

2012-12-26 Thread Kinkie
Hi all, What is in your opinion the right behavior wrt ESI in configure, default-maybe (enabled if all dependencies are present) or default-disable? The latter is what is curerntly in, but I'm concerned it may be due to a bug in configure.ac. Thanks -- /kinkie

[PATCH] Improve the logging for squid -z when cache_dir is not configured

2012-12-26 Thread Tianyin Xu
Hi all, The patch adds a log message when users runs squid -z without cache_dir configured. It is described in bugzilla #3728. http://bugs.squid-cache.org/show_bug.cgi?id=3728 Eliezer told me I should put here rather than leaving it at bugzilla. Thanks, Eliezer! The patch is attached. Best,

Re: Default behavior for --enable-esi?

2012-12-26 Thread Amos Jeffries
On 27/12/2012 2:07 a.m., Kinkie wrote: Hi all, What is in your opinion the right behavior wrt ESI in configure, default-maybe (enabled if all dependencies are present) or default-disable? The latter is what is curerntly in, but I'm concerned it may be due to a bug in configure.ac. Thanks --

Re: [PATCH] Fix memory leaks in ident.cc

2012-12-26 Thread Amos Jeffries
On 25/12/2012 7:24 p.m., Mike Mitchell wrote: Here is a revised patch for the memory leak in Ident.cc This version frees both the IdentStateData structure and a Connection structure. The Close_() definition now has the static keyword. Mike Mitchell

Re: [PATCH] auto-enable kqueue support

2012-12-26 Thread Amos Jeffries
On 16/12/2012 11:35 p.m., Amos Jeffries wrote: bumps kqueue from experimental to fully available net I/O method. kqueue has been in use on FreeBSD and maybe others for some time now and has less bugs than epoll. So the issues on record should not be held against it. The attached patch adds

Re: [PATCH] Fix memory leaks in auth_digest.cc

2012-12-26 Thread Amos Jeffries
On 22/12/2012 3:59 a.m., Kinkie wrote: Hi all, the attached patch addresses Coverity issue 740431: in Auth::Digest::Config::decode, username is allocated on the heap and not freed in case of certain errors. I've taken the chance to get rid of a few HEREs. An alternate approach would be to

Re: Default behavior for --enable-esi?

2012-12-26 Thread Henrik Nordström
tor 2012-12-27 klockan 13:38 +1300 skrev Amos Jeffries: IIRC it is still off because it is not wanted by many installations and adds a large footprint to the binary. The more useful surrogate-capabilities sub-component is auto-enabled on reverse-proxy traffic regardless of ESI. Plus still