Re: [PATCH] Deprecate log_icap and log_access configuration directives

2013-06-13 Thread Amos Jeffries
On 13/06/2013 2:44 a.m., Tsantilas Christos wrote: On 06/12/2013 10:56 AM, Henrik Nordström wrote: ons 2013-06-12 klockan 14:25 +1200 skrev Amos Jeffries: Please also note in the descriptive message that this alters the documented behaviour of Requests denied for logging will also not be

Re: [PATCH] Deprecate log_icap and log_access configuration directives

2013-06-13 Thread Tsantilas Christos
On 06/13/2013 02:59 PM, Amos Jeffries wrote: On 13/06/2013 2:44 a.m., Tsantilas Christos wrote: On 06/12/2013 10:56 AM, Henrik Nordström wrote: ons 2013-06-12 klockan 14:25 +1200 skrev Amos Jeffries: Please also note in the descriptive message that this alters the documented behaviour of

Re: [PATCH] Deprecate log_icap and log_access configuration directives

2013-06-13 Thread Henrik Nordström
tor 2013-06-13 klockan 23:59 +1200 skrev Amos Jeffries: As a temporary measure, how about adding a directive log_stats allow/deny acl acl acl ... and using it only for the statistcs gathering functions as done by log_access allow? That's fine for me. But should be named something more

Re: [PATCH] Deprecate log_icap and log_access configuration directives

2013-06-13 Thread Amos Jeffries
On 14/06/2013 12:39 a.m., Henrik Nordström wrote: tor 2013-06-13 klockan 23:59 +1200 skrev Amos Jeffries: As a temporary measure, how about adding a directive log_stats allow/deny acl acl acl ... and using it only for the statistcs gathering functions as done by log_access allow? That's fine

Re: [PATCH] Deprecate log_icap and log_access configuration directives

2013-06-13 Thread Alex Rousskov
On 06/13/2013 06:39 AM, Henrik Nordström wrote: tor 2013-06-13 klockan 23:59 +1200 skrev Amos Jeffries: As a temporary measure, how about adding a directive log_stats allow/deny acl acl acl ... and using it only for the statistcs gathering functions as done by log_access allow? That's

Re: [PATCH] Deprecate log_icap and log_access configuration directives

2013-06-13 Thread Henrik Nordström
tor 2013-06-13 klockan 08:16 -0600 skrev Alex Rousskov: I suggest stats_collection because it works better with allow/deny keywords that will follow: stats_collection deny internal +1 Regards Henrik

Re: [PATCH] Deprecate log_icap and log_access configuration directives

2013-06-13 Thread Tsantilas Christos
The last patch It adds the stats_collection access list. On 06/12/2013 05:25 AM, Amos Jeffries wrote: On 12/06/2013 1:36 a.m., Tsantilas Christos wrote: On 06/11/2013 02:14 PM, Amos Jeffries wrote: On 11/06/2013 10:16 p.m., Tsantilas Christos wrote: + this also goes for the