Re: [PATCH] Sending root certificate for validation

2013-06-18 Thread Tsantilas Christos
This patch forgotten. I am suggesting: - apply the patch as is - With a second patch move the SSL indexes from global.h to support.h Is it OK? On 06/10/2013 07:31 PM, Tsantilas Christos wrote: On 06/10/2013 03:16 PM, Amos Jeffries wrote: On 8/06/2013 4:20 a.m., Tsantilas Christos wrote:

[RFC] Annotation quoting

2013-06-18 Thread Tsantilas Christos
Some customers complaining that their annotations (set by url_rewriter) look wrong when logged to access.log. Here are a few examples of logged annotations: %22-%22 %22Default_Google%22 %22pg13,k12%22 Currently the logging code when needs to log an annotation: 1) first check for

Re: [PATCΗ] Quoted values in squid.conf

2013-06-18 Thread Tsantilas Christos
This discussion is also frozen... Alex and Kinki suggest the function style, and looks that is a good choice and there are very good reasons for doing this. Are we OK to implement it like this? @Alex What are you suggesting file(location) or parameters(location)? On 06/04/2013 05:55 PM,

Re: [RFC] Annotation quoting

2013-06-18 Thread Amos Jeffries
On 18/06/2013 8:21 p.m., Tsantilas Christos wrote: Some customers complaining that their annotations (set by url_rewriter) look wrong when logged to access.log. Here are a few examples of logged annotations: %22-%22 %22Default_Google%22 %22pg13,k12%22 Where are those %22

Re: [PATCH] Sending root certificate for validation

2013-06-18 Thread Amos Jeffries
On 18/06/2013 7:29 p.m., Tsantilas Christos wrote: This patch forgotten. I am suggesting: - apply the patch as is - With a second patch move the SSL indexes from global.h to support.h Is it OK? Yes that will do. Amos

Re: [RFC] Annotation quoting

2013-06-18 Thread Tsantilas Christos
On 06/18/2013 12:50 PM, Amos Jeffries wrote: On 18/06/2013 8:21 p.m., Tsantilas Christos wrote: Some customers complaining that their annotations (set by url_rewriter) look wrong when logged to access.log. Here are a few examples of logged annotations: %22-%22 %22Default_Google%22

Re: [PATCH] Sending root certificate for validation

2013-06-18 Thread Tsantilas Christos
On 06/18/2013 12:53 PM, Amos Jeffries wrote: On 18/06/2013 7:29 p.m., Tsantilas Christos wrote: This patch forgotten. I am suggesting: - apply the patch as is The patch applied to trunk - With a second patch move the SSL indexes from global.h to support.h For a stupid reason,

Jenkins build is back to normal : 3.HEAD-amd64-FreeBSD-7.2 #1891

2013-06-18 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-FreeBSD-7.2/1891/changes

Re: [PATCΗ] Quoted values in squid.conf

2013-06-18 Thread Alex Rousskov
On 06/18/2013 03:42 AM, Tsantilas Christos wrote: What are you suggesting file(location) or parameters(location)? parameters() or options() seems better to me because the code actually loads a squid.conf directive parameters. It cannot load directives themselves this way (we have an import

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-9.0-clang #276

2013-06-18 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-FreeBSD-9.0-clang/276/changes Changes: [Christos Tsantilas] Sending root certificate for validation This patch modify squid cert validation subsystem to sent to cert validator helper the complete certificates chain, not only the certificates

Re: [PATCH] Master transaction state object

2013-06-18 Thread Amos Jeffries
Done and applied as trunk rev.12915. Amos

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-9.0-clang #277

2013-06-18 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-FreeBSD-9.0-clang/277/changes Changes: [Amos Jeffries] Add Master Transaction class ... to store and propigate the shared state used end-to-end through Squid for logging or server-side component input. This excludes Job and Call pointers, but