What is The logic of Vary Headers cachiness?

2013-07-17 Thread Eliezer Croitoru
As I have seen some issues that indicate that the Vary headers cause some problems while caching.. I want to make sure I understand how a Vary headers should be treated before diving into some code. My assumption is that there are Vary headers that the servers might be considering while

Re: What is The logic of Vary Headers cachiness?

2013-07-17 Thread Amos Jeffries
On 17/07/2013 10:29 p.m., Eliezer Croitoru wrote: As I have seen some issues that indicate that the Vary headers cause some problems while caching.. I want to make sure I understand how a Vary headers should be treated before diving into some code. Um, the shodul be rather than what Squid is

Re: What is The logic of Vary Headers cachiness?

2013-07-17 Thread Henrik Nordström
ons 2013-07-17 klockan 23:34 +1200 skrev Amos Jeffries: Also, I think if the variant needs to be invalidated Squid currently coded to drop all variants and/or the main x-vary-* stub object during revalidation. The HTTP/1.1 specs need to be checked to see if that is right or if only the one

Re: [RFC] Time to talk about StringNG merge again?

2013-07-17 Thread Alex Rousskov
On 07/04/2013 11:51 PM, Kinkie wrote: void SBuf::reserveCapacity(size_type minCapacity) { Must(0 = minCapacity minCapacity = maxSize); reserveSpace(minCapacity-length()); } This does not look right. For example, if minCapacity is smaller than length(), we should do

Re: [PATCH] update port protocol parameter

2013-07-17 Thread Alex Rousskov
On 07/06/2013 08:22 AM, Amos Jeffries wrote: This patch updates the *_port directives protocol= parameter to accept to use AnyP::ProtocolVersion internal storage instead of opaque string text. The above says instead but the patch leaves the old string-based constructor. Do we still need that

Re: [PATCH] update port protocol parameter

2013-07-17 Thread Amos Jeffries
On 18/07/2013 1:36 p.m., Alex Rousskov wrote: On 07/06/2013 08:22 AM, Amos Jeffries wrote: This patch updates the *_port directives protocol= parameter to accept to use AnyP::ProtocolVersion internal storage instead of opaque string text. The above says instead but the patch leaves the old

Re: [PATCH] update port protocol parameter

2013-07-17 Thread Alex Rousskov
On 07/17/2013 08:16 PM, Amos Jeffries wrote: On 18/07/2013 1:36 p.m., Alex Rousskov wrote: On 07/06/2013 08:22 AM, Amos Jeffries wrote: +debugs(3, DBG_CRITICAL, FATAL: URLScheme(s-transport.protocol).const_str() _port: missing ']' on IPv6 address: token); +

Re: [PATCΗ] Quoted values in squid.conf

2013-07-17 Thread Amos Jeffries
Hi Christos, So sorry for the long delay in reply. This thread seems to be getting lost in may mailer filters. +1. I have another long list of tweaks below, BUT these ones are all very cosmetic polishing that can be done and comitted without another review. Thank you very much for

Re: [PATCH] reload into If-None-Match

2013-07-17 Thread Alex Rousskov
On 07/12/2013 10:48 AM, Amos Jeffries wrote: On 13/07/2013 12:31 a.m., Tsantilas Christos wrote: Finally I did not apply the last patch I posted because I found a bug. Squid hits an assertion in clientReplyContext::processExpired at client_side_reply.cc:245, assert(http-storeEntry()-lastmod

Re: [RFC] Time to talk about StringNG merge again?

2013-07-17 Thread Amos Jeffries
On 9/07/2013 8:16 p.m., Kinkie wrote: Also, I suggest splitting this into two methods, one with a required (first?) SBufCaseSensitive parameter and one without it. This will allow callers to specify n without specifying isCaseSensitive and vice versa. The shorter, inlined method will simply call

Re: [PATCΗ] Quoted values in squid.conf

2013-07-17 Thread Alex Rousskov
On 07/17/2013 10:22 PM, Amos Jeffries wrote: 2) Does not allow inside double quoted strings an escaped $ or % character if the parameter does not support macros. What about users who want to place config files in a directory path with spaces AND use per-worker ${process_number} macro on the