On 07/31/2013 06:18 AM, Kinkie wrote:
> On Wed, Jul 31, 2013 at 2:53 AM, Alex Rousskov wrote:
>> On 07/30/2013 03:56 AM, Kinkie wrote:
>>> len_ += sz;
>>> // TODO: this does NOT belong here, but to class-init or autoconf
>>> /* on Linux and FreeBSD, '\0' is not counted in return value *
On 07/31/2013 11:11 AM, Alex Rousskov wrote:
> On 07/31/2013 10:12 AM, Kinkie wrote:
> Not if the math overflowed down to a smaller value before it even got
> passed
> to reserveCapacity().
Ok. I'm going to check minSpace. maxSize+minSpace is definitely not
enough to over
On 07/31/2013 10:12 AM, Kinkie wrote:
Not if the math overflowed down to a smaller value before it even got
passed
to reserveCapacity().
>>>
>>> Ok. I'm going to check minSpace. maxSize+minSpace is definitely not
>>> enough to overflow size_type
>>
>>
>> minSpace is controlled comple
On 07/31/2013 06:18 AM, Kinkie wrote:
>>> >> typedef int32_t size_type;
>> >
>> > I think we should make it unsigned. I agree with your earlier
>> > observation that it is better to do that now rather than later or never.
> Yes, it is agreed. It's however something I'd prefer to do as a
> sepa
Christos, Amos,
Thank you for working on this! I hope we can avoid repeating the
same set of mistakes thrice by carefully considering the big picture and
upgrade path. Here is my understanding of how we want things to work,
based on the review of the reported bugs and this thread so far:
1.
>>> Not if the math overflowed down to a smaller value before it even got
>>> passed
>>> to reserveCapacity().
>>
>> Ok. I'm going to check minSpace. maxSize+minSpace is definitely not
>> enough to overflow size_type
>
>
> minSpace is controlled completely by the unknown caller code. It may be
> UI
On 07/31/2013 09:02 AM, Amos Jeffries wrote:
> Wider testing in production (by Ralf Hildenbrandt) has identified that
> the mDNS support added in 3.4 can produce a large number amount of
> multicast traffic from .arpa lookups even if mDNS is not setup on the
> local network.
Should not mDNS be tu
Wider testing in production (by Ralf Hildenbrandt) has identified that
the mDNS support added in 3.4 can produce a large number amount of
multicast traffic from .arpa lookups even if mDNS is not setup on the
local network.
Add a configuration option dns_multicast_local to turn mDNS lookups
ON
On 1/08/2013 12:58 a.m., Kinkie wrote:
On Wed, Jul 31, 2013 at 2:46 PM, Amos Jeffries wrote:
On 1/08/2013 12:18 a.m., Kinkie wrote:
On Wed, Jul 31, 2013 at 2:53 AM, Alex Rousskov
wrote:
On 07/30/2013 03:56 AM, Kinkie wrote:
lp:~squid/squid/stringng-cherrypick has the most uptodate code.
On Wed, Jul 31, 2013 at 2:46 PM, Amos Jeffries wrote:
> On 1/08/2013 12:18 a.m., Kinkie wrote:
>>
>> On Wed, Jul 31, 2013 at 2:53 AM, Alex Rousskov
>> wrote:
>>>
>>> On 07/30/2013 03:56 AM, Kinkie wrote:
>>>
lp:~squid/squid/stringng-cherrypick has the most uptodate code.
>>>
>>>
>>> I did no
On 1/08/2013 12:18 a.m., Kinkie wrote:
On Wed, Jul 31, 2013 at 2:53 AM, Alex Rousskov
wrote:
On 07/30/2013 03:56 AM, Kinkie wrote:
lp:~squid/squid/stringng-cherrypick has the most uptodate code.
I did not finish the review before running out of time, but I found one
or two bugs in r12761 (i
On Wed, Jul 31, 2013 at 2:53 AM, Alex Rousskov
wrote:
> On 07/30/2013 03:56 AM, Kinkie wrote:
>
>> lp:~squid/squid/stringng-cherrypick has the most uptodate code.
>
>
> I did not finish the review before running out of time, but I found one
> or two bugs in r12761 (in the code I have not looked at
On 07/30/2013 10:52 PM, Amos Jeffries wrote:
> On 31/07/2013 6:23 a.m., Tsantilas Christos wrote:
>> On 07/30/2013 08:12 PM, Amos Jeffries wrote:
>>> I just ran your patch past my set of test cases built from the user
>>> complaints so far:
>>>
>>>
>>> 2013/07/31 04:56:39| Processing: configuration
On 07/30/2013 11:15 PM, Amos Jeffries wrote:
> On 31/07/2013 6:47 a.m., Tsantilas Christos wrote:
>> On 07/30/2013 09:17 PM, Amos Jeffries wrote:
However Amos refers to an other case. For the following line:
"Simple Tokens"
we may want to retrieve the token "Simple
Do we ha
14 matches
Mail list logo
