Re: [PATCH] Vector refactor, part 2

2014-02-11 Thread Amos Jeffries
On 11/02/2014 8:58 p.m., Kinkie wrote: Hi, attached is the second part of Vector refactoring. It replaces Vector with std::vector in all clients except for Stack, which I believe to more sensible to replace with std::stack instead of reimplementing. Code has been farm-build-tested and

RFC: debugs() improvements

2014-02-11 Thread Kinkie
Hi all, there are two topics I'd like us to discuss about to share an agreement when the right time comes. I'm spreading the discussion over two threads in order not to cross wires and facilitate discussion. During recent discussion on IRC it was found out that there are not that many big

RFC: change in policy for include guards

2014-02-11 Thread Kinkie
Hi all, there are two topics I'd like us to discuss about to share an agreement when the right time comes. I'm spreading the discussion over two threads in order not to cross wires and facilitate discussion. The topic I'm thinking of is the policy of autoconf-detecting some system headers we

Re: Vector refactor, part 3: stack

2014-02-11 Thread Kinkie
I've had a strange assert (at HttpHeader.cc:1551, in ~HttpHeaderEntry), but I could not reproduce that nor find anything in p2 or p3 of the refactor patch which may trigger it. I'm running more tests at full debugging. Hit it again. Looking at HttpHeader, that code is really crappy. The root

Fwd: [CTTE #727708] Default init system for Debian

2014-02-11 Thread Amos Jeffries
Sigh. Amos Original Message Subject: [CTTE #727708] Default init system for Debian To: debian-devel-announce The technical committee was asked in #727708 to decide which init system would be the default init system for Debian. The decision is below: RESOLUTION We

Re: Fwd: [CTTE #727708] Default init system for Debian

2014-02-11 Thread Henrik Nordström
ons 2014-02-12 klockan 10:13 +1300 skrev Amos Jeffries: Sigh. Amos Why sigh? systemd have worked well for me for years now.. except Squid.. For Squid the main impact is that we really should have a dont daemonize yourself run mode which don't otherwise limit functionality. The -N option we

Re: Fwd: [CTTE #727708] Default init system for Debian

2014-02-11 Thread Amos Jeffries
On 2014-02-12 10:27, Henrik Nordström wrote: ons 2014-02-12 klockan 10:13 +1300 skrev Amos Jeffries: Sigh. Amos Why sigh? systemd have worked well for me for years now.. except Squid.. For Squid the main impact is that we really should have a dont daemonize yourself run mode which don't

Re: Fwd: [CTTE #727708] Default init system for Debian

2014-02-11 Thread Henrik Nordström
ons 2014-02-12 klockan 10:47 +1300 skrev Amos Jeffries: Exactly. More deep changes needed. Well, systemd (and most other service monitors) do manage services that background themselves as well, just not optimally. So it's more changes desired, not strictly needed. But seriously, it's a very

Re: Fwd: [CTTE #727708] Default init system for Debian

2014-02-11 Thread Amos Jeffries
On 2014-02-12 11:07, Henrik Nordström wrote: ons 2014-02-12 klockan 10:47 +1300 skrev Amos Jeffries: Exactly. More deep changes needed. Well, systemd (and most other service monitors) do manage services that background themselves as well, just not optimally. So it's more changes desired, not

Re: RFC: change in policy for include guards

2014-02-11 Thread Alex Rousskov
On 02/11/2014 04:48 AM, Kinkie wrote: The topic I'm thinking of is the policy of autoconf-detecting some system headers we use. While this is undoubtably good for C- and system- headers, it doesn't make much sense for pure C++ headers, which are very strongly defined by the standard and for

Re: Vector refactor, part 3: stack

2014-02-11 Thread Amos Jeffries
On 2014-02-12 06:19, Kinkie wrote: I've had a strange assert (at HttpHeader.cc:1551, in ~HttpHeaderEntry), but I could not reproduce that nor find anything in p2 or p3 of the refactor patch which may trigger it. I'm running more tests at full debugging. Hit it again. Looking at HttpHeader,

Re: Vector refactor, part 3: stack

2014-02-11 Thread Alex Rousskov
On 02/11/2014 03:28 PM, Amos Jeffries wrote: On 2014-02-12 06:19, Kinkie wrote: I suspect that HttpHeader.cc needs some love. Has anyone already thought about this topic or should I prepare a proposal? I'd like to share design ideas before going for an implementation attempt. Yes there is

Re: RFC: change in policy for include guards

2014-02-11 Thread Amos Jeffries
On 2014-02-12 11:26, Alex Rousskov wrote: On 02/11/2014 04:48 AM, Kinkie wrote: The topic I'm thinking of is the policy of autoconf-detecting some system headers we use. While this is undoubtably good for C- and system- headers, it doesn't make much sense for pure C++ headers, which are very

Re: Vector refactor, part 3: stack

2014-02-11 Thread Amos Jeffries
On 2014-02-12 04:45, Kinkie wrote: Hi, the attached patch is the missing piece of Vector refactoring: it replaces users of Stack with std::stack (or std::vector, in one case where it's needed due to also needing to iterate over the elements), and removes Vector, Stack and related unit tests.