Re: [PATCH] Bug 1961 pt2: store URI userinfo (aka login) in class URL

On 05/09/2014 01:31 PM, Amos Jeffries wrote: > +const SBuf &userInfo(void) const {return userInfo_;} Please avoid "(void)" in new code and use "()" for consistency with most C++ code. > +if (checklist->request->url.userInfo().isEmpty()) { > +debugs(28, 5, "URL has no user-info d

Re: [PATCH] Use SBuf for tunnel.cc I/O

On 05/11/2014 11:16 AM, Amos Jeffries wrote: > This patch adds a Comm::Write API for accepting SBuf output buffers. > Unlike the char* API the buffer can be appended to before write(2) is > completed and the appended bytes will be handled as part of the original > write request. That approach s

Re: [PATCH] experiment in private caching

On 05/11/2014 05:29 AM, Amos Jeffries wrote: > This patch seeks to reduce the constant MISS situation we have from > false failures doing Host: header verify. General comments: FWIW, I have a general feeling we are going to regret the proposed change, but I do not have enough specific reasons to

Jenkins build is back to normal : 3.HEAD-amd64-OpenBSD-5.4 #80

See

Jenkins build is back to normal : 3.HEAD-amd64-FreeBSD-9.1-clang #577

See

Re: Squid Won't Cache private

Dear Squid Developers, we are using squid 3.4.2.'--enable-http-violations' I can't cache a xml file with this headers: Cache-Control |no-cache| Connection |Keep-Alive| Content-Length |168| Content-Type|| I tried different things, different configs, googled, but i cant get

Jenkins build is back to normal : 3.HEAD-amd64-FreeBSD-9.1 #673

See

Jenkins build is back to normal : 3.HEAD-amd64-FreeBSD-7.2 #2195

See

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-10-clang #77

See Changes: [Francesco Chemolli] Merged ext_delayer_acl [Francesco Chemolli] Reverted r13409 due to incompatibility with BSD pmake -- [...truncated 28579 lines...] icmp->icmp

Jenkins build is back to normal : 3.HEAD-amd64-centos-6 #341

See

Re: [PATCH] Fix for Squid 3.4.5 segfault

On 05/12/2014 10:47 AM, Steve Hill wrote: > Squid 3.4.5 segfaults when formatting log lines for me. It looks like > this is down to fmt->data.timespec being uninitialised, and affects the > %tg format specifier. > > As far as I can tell, fmt->data.timespec is never set anywhere, and we > should

Re: [MERGE] Squid Patch (revision 10487)

On 2014-05-12 16:52, Amos Jeffries wrote: Here is the guts of the original patch as should be relevant to Squid-3.5 (or 3.4). http://master.squid-cache.org/~amosjeffries/patches/Pye_s35.patch Many thanks Amos, I've just tried this and it does indeed query sibling for stale content as we want.

[PATCH] Fix for Squid 3.4.5 segfault

Squid 3.4.5 segfaults when formatting log lines for me. It looks like this is down to fmt->data.timespec being uninitialised, and affects the %tg format specifier. As far as I can tell, fmt->data.timespec is never set anywhere, and we should probably be using fmt->data.string instead. The

Re: [MERGE] Squid Patch (revision 10487)

On 13/05/2014 2:25 a.m., Michael Pye wrote: > On 2014-05-11 18:40, Amos Jeffries wrote: >> Not as yet. Henrik pointed out a problem that needed testing: >> http://www.squid-cache.org/mail-archive/squid-dev/201005/0156.html >> >> I dont think we send only-if-cached any longer. >> >> Can you confirm

Re: [MERGE] Squid Patch (revision 10487)

On 2014-05-11 18:40, Amos Jeffries wrote: Not as yet. Henrik pointed out a problem that needed testing: http://www.squid-cache.org/mail-archive/squid-dev/201005/0156.html I dont think we send only-if-cached any longer. Can you confirm that, or answer Henriks question? Sorry - I can't confirm

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-10-clang #76

See Changes: [Amos Jeffries] Bug 2554: 32-bit wrap in AUFS counters -- [...truncated 28437 lines...] icmp->icmp_code = 0; ^ ../../../src/icmp/Icmp4.cc:95:28: note: forw

Jenkins build is back to normal : 3.HEAD-amd64-ubuntu-precise #710

See

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-10-clang #75

See Changes: [Francesco Chemolli] Changed subst_perlshell Makefile recipe to use the actual source file name -- [...truncated 28434 lines...] icmp->icmp_code = 0; ^ ..

Re: [PATCH] Tokenizer

Ping. Amos On 7/01/2014 12:14 p.m., Amos Jeffries wrote: > On 2014-01-07 10:23, Kinkie wrote: >> Hi, >> here's a merge proposal for Parser::Tokenizer, an implementation of >> the API suggested by Alex. >> >> The feature branch is available at lp:~squid/squid/sbuf-tokenizer > > in src/parser/To