> > The above configure concept would tie in with removing the --enable-qos
> > option altogether. There's no reason for the QOS code not to be included
> > that I can see (it has no dependencies, apart from the optional upstream
> > kernel patch), and with this patch and the isTosActive(), it's e
Andrew Beverley wrote:
My latest revision of the patch for netfilter marking will follow soon.
Before I post it, I will reply to comments on the previous version.
Omitting bits I'm happy with.
Question number 2: what is stubQosConfig.cc? Does that also need
updating for this patch?
I've
On Fri, 2010-08-13 at 18:19 -0600, Alex Rousskov wrote:
> On 08/11/2010 03:25 PM, Andrew Beverley wrote:
>
> > I've moved these, as well as most of the other QOS functions, into
> > Ip::Qos. I have also removed the QosConfig namespace, as it didn't seem
> > to fit with all these additional functio
> >
> > * Do you need an L suffix for large unsigned constants like 0x?
> > Please investigate. I do not know the answer, but I recall seeing such
> > suffixes elsewhere:
> > http://www.google.com/search?q=0x+vs+0xL
>
> I thought that indicated "long" type to be used. Wh
My latest revision of the patch for netfilter marking will follow soon.
Before I post it, I will reply to comments on the previous version.
> >> >
> >> > Question number 2: what is stubQosConfig.cc? Does that also need
> >> > updating for this patch?
> >> >
> >>
> >> stub* are cut down set of
On 08/21/2010 05:45 PM, Henrik Nordström wrote:
lör 2010-08-21 klockan 23:41 +0100 skrev Andrew Beverley:
I have documented all the functions and class data members. Could you
clarify whether *every* variable should be documented with doxygen
comments (including short-lived temporary ones withi
lör 2010-08-21 klockan 23:41 +0100 skrev Andrew Beverley:
> I have documented all the functions and class data members. Could you
> clarify whether *every* variable should be documented with doxygen
> comments (including short-lived temporary ones within functions), or
> just those that are part o
> * My understanding is that class data members and public class methods
> should be documented in the header. Others should be documented in the
> .cc files. You may want to double check this rule with Amos before
> moving comments though.
>
> * Many Qos data members are not documented, inclu
On Fri, 2010-08-20 at 12:44 -0600, Alex Rousskov wrote:
> On 08/20/2010 11:06 AM, Andrew Beverley wrote:
> > On Fri, 2010-08-13 at 18:19 -0600, Alex Rousskov wrote:
> >> On 08/11/2010 03:25 PM, Andrew Beverley wrote:
> >>
> >>> I've moved these, as well as most of the other QOS functions, into
> >>
On 08/20/2010 11:06 AM, Andrew Beverley wrote:
On Fri, 2010-08-13 at 18:19 -0600, Alex Rousskov wrote:
On 08/11/2010 03:25 PM, Andrew Beverley wrote:
I've moved these, as well as most of the other QOS functions, into
Ip::Qos. I have also removed the QosConfig namespace, as it didn't seem
to fi
On Fri, 2010-08-13 at 18:19 -0600, Alex Rousskov wrote:
> On 08/11/2010 03:25 PM, Andrew Beverley wrote:
>
> > I've moved these, as well as most of the other QOS functions, into
> > Ip::Qos. I have also removed the QosConfig namespace, as it didn't seem
> > to fit with all these additional functio
> Seems the netfilter guys found a major problem with strtoul().
> Thankfully the same fix should work for us as well.
>
>
> Luciano Coelho wrote:
>
> >
> > Not easily. I found that there is a bug in strtoul (and strtoull for
> > that matter) that causes the long to overflow if there are
Andrew,
Seems the netfilter guys found a major problem with strtoul().
Thankfully the same fix should work for us as well.
Luciano Coelho wrote:
>
> Not easily. I found that there is a bug in strtoul (and strtoull for
> that matter) that causes the long to overflow if there are valid digit
Alex Rousskov wrote:
On 08/11/2010 03:25 PM, Andrew Beverley wrote:
I've moved these, as well as most of the other QOS functions, into
Ip::Qos. I have also removed the QosConfig namespace, as it didn't seem
to fit with all these additional functions.
* A patch preamble with the proposed commi
On 08/11/2010 03:25 PM, Andrew Beverley wrote:
I've moved these, as well as most of the other QOS functions, into
Ip::Qos. I have also removed the QosConfig namespace, as it didn't seem
to fit with all these additional functions.
* A patch preamble with the proposed commit message would be nic
Andrew Beverley wrote:
stub* are cut down set of all non-inline Ip::QosConfig methods and any
globals defined in QosConfig.h. Changes to the API need to be mirrored
there. The functions inside usually call fatal() to alert a wrong
linkage clearly during testing. In this particular case the pars
> >> stub* are cut down set of all non-inline Ip::QosConfig methods and any
> >> globals defined in QosConfig.h. Changes to the API need to be mirrored
> >> there. The functions inside usually call fatal() to alert a wrong
> >> linkage clearly during testing. In this particular case the parse
>
On Wed, 11 Aug 2010 22:25:45 +0100, Andrew Beverley
wrote:
> Updated patch attached; comments below.
>
>> > If we can move to strtoul, I would like to change 'tos' to char
>> > throughout. Currently it is possible to set it to invalid values in
>> > squid.conf, which then cause problems with dump
Updated patch attached; comments below.
> > If we can move to strtoul, I would like to change 'tos' to char
> > throughout. Currently it is possible to set it to invalid values in
> > squid.conf, which then cause problems with dumpConfigLine.
> >
> > Question number 2: what is stubQosConfig.cc? D
Andrew Beverley wrote:
On Mon, 2010-08-02 at 12:03 -0600, Alex Rousskov wrote:
On 08/01/2010 05:47 PM, Andrew Beverley wrote:
Please find attached the first version of the netfilter mark patch. I've
not yet tested it extensively, but would welcome some initial feedback
or comments.
Thanks for
Thanks for the prompt response. Updated patch attached to my previous
email.
> > Please find attached the first version of the netfilter mark patch. I've
> > not yet tested it extensively, but would welcome some initial feedback
> > or comments.
>
> The mess around local port can be cleaned up (s
On Mon, 2010-08-02 at 12:03 -0600, Alex Rousskov wrote:
> On 08/01/2010 05:47 PM, Andrew Beverley wrote:
> > Please find attached the first version of the netfilter mark patch. I've
> > not yet tested it extensively, but would welcome some initial feedback
> > or comments.
Thanks for the prompt r
On 08/01/2010 05:47 PM, Andrew Beverley wrote:
Please find attached the first version of the netfilter mark patch. I've
not yet tested it extensively, but would welcome some initial feedback
or comments.
* It would be nice to get a proposed commit message describing the
changes as a patch prea
On Mon, 02 Aug 2010 00:47:15 +0100, Andrew Beverley
wrote:
> Please find attached the first version of the netfilter mark patch. I've
> not yet tested it extensively, but would welcome some initial feedback
> or comments.
>
> My comments are:
>
> - The existing TOS patch cannot be disabled at ru
Please find attached the first version of the netfilter mark patch. I've
not yet tested it extensively, but would welcome some initial feedback
or comments.
My comments are:
- The existing TOS patch cannot be disabled at runtime. As such, this
mark patch cannot be either. Would it be preferable t
25 matches
Mail list logo
