Re: [PATCH] HTTP/1.1 response caching upgrade

2012-10-23 Thread Dmitry Kurochkin
Amos Jeffries writes: > On 24.10.2012 10:56, Dmitry Kurochkin wrote: >> Amos Jeffries writes: >> >>> On 24.10.2012 09:11, Dmitry Kurochkin wrote: Hi Amos. > Co-Advisor results look good. No regressions. The following test cases succeed now: * shared cache MU

Re: [PATCH] HTTP/1.1 response caching upgrade

2012-10-23 Thread Amos Jeffries
On 24.10.2012 10:56, Dmitry Kurochkin wrote: Amos Jeffries writes: On 24.10.2012 09:11, Dmitry Kurochkin wrote: Hi Amos. Co-Advisor results look good. No regressions. The following test cases succeed now: * shared cache MUST use fresh request-headers when validating Authorization respo

Re: [PATCH] HTTP/1.1 response caching upgrade

2012-10-23 Thread Dmitry Kurochkin
Amos Jeffries writes: > On 24.10.2012 09:11, Dmitry Kurochkin wrote: >> Hi Amos. >> >> Amos Jeffries writes: >> >>> On 18.10.2012 04:42, Alex Rousskov wrote: On 10/16/2012 03:24 AM, Amos Jeffries wrote: > Updated patch with requested changes. Looks OK to me although I have not

Re: [PATCH] HTTP/1.1 response caching upgrade

2012-10-23 Thread Amos Jeffries
On 24.10.2012 09:11, Dmitry Kurochkin wrote: Hi Amos. Amos Jeffries writes: On 18.10.2012 04:42, Alex Rousskov wrote: On 10/16/2012 03:24 AM, Amos Jeffries wrote: Updated patch with requested changes. Looks OK to me although I have not verified each individual CC handling line. +

Re: [PATCH] HTTP/1.1 response caching upgrade

2012-10-23 Thread Dmitry Kurochkin
Hi Amos. Amos Jeffries writes: > On 18.10.2012 04:42, Alex Rousskov wrote: >> On 10/16/2012 03:24 AM, Amos Jeffries wrote: >>> Updated patch with requested changes. >> >> Looks OK to me although I have not verified each individual CC >> handling >> line. >> >>> +if ((mayStore |= rep->ca

Re: [PATCH] HTTP/1.1 response caching upgrade

2012-10-18 Thread Alex Rousskov
On 10/17/2012 06:22 PM, Amos Jeffries wrote: > On 18.10.2012 04:52, Alex Rousskov wrote: >> On 10/16/2012 03:24 AM, Amos Jeffries wrote: >>> Updated patch with requested changes. >> >> >>> +#if USE_HTTP_VIOLATIONS // response header Pragma is undefined in HTTP >>> +else { >>> +/

Re: [PATCH] HTTP/1.1 response caching upgrade

2012-10-17 Thread Amos Jeffries
On 18.10.2012 04:52, Alex Rousskov wrote: On 10/16/2012 03:24 AM, Amos Jeffries wrote: Updated patch with requested changes. +#if USE_HTTP_VIOLATIONS // response header Pragma is undefined in HTTP +else { +// Expensive calculation. So only do it IF the CC: header is not

Re: [PATCH] HTTP/1.1 response caching upgrade

2012-10-17 Thread Amos Jeffries
On 18.10.2012 04:42, Alex Rousskov wrote: On 10/16/2012 03:24 AM, Amos Jeffries wrote: Updated patch with requested changes. Looks OK to me although I have not verified each individual CC handling line. +if ((mayStore |= rep->cache_control->Public())) { +} else if ((mayStor

Re: [PATCH] HTTP/1.1 response caching upgrade

2012-10-17 Thread Alex Rousskov
On 10/16/2012 03:24 AM, Amos Jeffries wrote: > Updated patch with requested changes. > +#if USE_HTTP_VIOLATIONS // response header Pragma is undefined in HTTP > +else { > +// Expensive calculation. So only do it IF the CC: header is not > present. > + > +/* HACK:

Re: [PATCH] HTTP/1.1 response caching upgrade

2012-10-17 Thread Alex Rousskov
On 10/16/2012 03:24 AM, Amos Jeffries wrote: > Updated patch with requested changes. Looks OK to me although I have not verified each individual CC handling line. > +if ((mayStore |= rep->cache_control->Public())) { > +} else if ((mayStore |= (rep->cache_control->mustRevalidate()

Re: [PATCH] HTTP/1.1 response caching upgrade

2012-10-16 Thread Amos Jeffries
Updated patch with requested changes. Amos On 16/10/2012 12:31 p.m., Amos Jeffries wrote: On 16.10.2012 09:56, Alex Rousskov wrote: On 10/14/2012 01:17 AM, Amos Jeffries wrote: On prompting from bug 3670 which outlines how Auth transactions are now wrongly non-cacheable. I have performed a s

Re: [PATCH] HTTP/1.1 response caching upgrade

2012-10-15 Thread Amos Jeffries
On 16.10.2012 09:56, Alex Rousskov wrote: On 10/14/2012 01:17 AM, Amos Jeffries wrote: On prompting from bug 3670 which outlines how Auth transactions are now wrongly non-cacheable. I have performed a small audit of the HttpStateData::cacheableReply() method and this patch contains the result.

Re: [PATCH] HTTP/1.1 response caching upgrade

2012-10-15 Thread Alex Rousskov
On 10/14/2012 01:17 AM, Amos Jeffries wrote: > On prompting from bug 3670 which outlines how Auth transactions are now > wrongly non-cacheable. I have performed a small audit of the > HttpStateData::cacheableReply() method and this patch contains the result. > > trunk rev 11361 converted Cache-Con

Re: [PATCH] HTTP/1.1 response caching upgrade

2012-10-15 Thread Kinkie
there's a bit of dead code in there (#if 0..#endif) I can't understand the actual workings of the code, but assuming it is correct I like its style better. +0 from me. Kinkie On Sun, Oct 14, 2012 at 9:17 AM, Amos Jeffries wrote: > On prompting from bug 3670 which outlines how Auth transaction

[PATCH] HTTP/1.1 response caching upgrade

2012-10-14 Thread Amos Jeffries
On prompting from bug 3670 which outlines how Auth transactions are now wrongly non-cacheable. I have performed a small audit of the HttpStateData::cacheableReply() method and this patch contains the result. trunk rev 11361 converted Cache-Control header from using a single mask bitmap (shared