Re: [PATCH] Polish log formats

2010-12-01 Thread Amos Jeffries
On 01/12/10 06:39, Henrik Nordström wrote: tis 2010-11-30 klockan 03:25 +1300 skrev Amos Jeffries: So could you explain those condition please? It's not clear from the code that they did anything beyond logging at the end of header parsing. Or do you mean that by being done there they logged mu

Re: [PATCH] Polish log formats

2010-11-30 Thread Henrik Nordström
tis 2010-11-30 klockan 03:25 +1300 skrev Amos Jeffries: > So could you explain those condition please? It's not clear from the > code that they did anything beyond logging at the end of header parsing. > Or do you mean that by being done there they logged multiple lines per > request? Checking.

Re: [PATCH] Polish log formats

2010-11-29 Thread Amos Jeffries
On 30/11/10 02:17, Henrik Nordström wrote: While I do not know anybody using the obsoleted or removed features, it may be a good idea to warn about those logging changes on squid-users and see if there are any reasonable objections. referer_log is a little different. Can't be fully emulated b

Re: [PATCH] Polish log formats

2010-11-29 Thread Henrik Nordström
> While I do not know anybody using the obsoleted or removed features, it > may be a good idea to warn about those logging changes on squid-users > and see if there are any reasonable objections. referer_log is a little different. Can't be fully emulated by a custom log format. the log format

Re: [PATCH] Polish log formats

2010-11-28 Thread Alex Rousskov
On 11/28/2010 05:08 AM, Amos Jeffries wrote: This polishes up the various log line formatting code sitting around Squid in accordance with the SourceLayout plan. Adds: * namespace Log::Format for log display functionality. Each line formater is a global function inside here. The log format enum