Re: [PATCH] cache_peer standby=N

2014-04-29 Thread Amos Jeffries
On 29/04/2014 8:46 a.m., Alex Rousskov wrote: On 04/27/2014 10:02 PM, Amos Jeffries wrote: We should state the problem with idles clearly (yes it is difficult to word), We already do that: +max-conn limit works poorly when there is a relatively +

Re: [PATCH] cache_peer standby=N

2014-04-29 Thread Alex Rousskov
On 04/29/2014 05:48 AM, Amos Jeffries wrote: On 29/04/2014 8:46 a.m., Alex Rousskov wrote: On 04/27/2014 10:02 PM, Amos Jeffries wrote: We should state the problem with idles clearly (yes it is difficult to word), We already do that: + max-conn limit works poorly when

Re: [PATCH] cache_peer standby=N

2014-04-29 Thread Amos Jeffries
On 30/04/2014 2:10 a.m., Alex Rousskov wrote: On 04/29/2014 05:48 AM, Amos Jeffries wrote: On 29/04/2014 8:46 a.m., Alex Rousskov wrote: On 04/27/2014 10:02 PM, Amos Jeffries wrote: We should state the problem with idles clearly (yes it is difficult to word), We already do that: +

Re: [PATCH] cache_peer standby=N

2014-04-29 Thread Tsantilas Christos
To summarize, the requested changes are: *in cf.data.pre: replace: max-conn limit works poorly when there is a relatively large number of idle persistent connections with the peer because the limiting code does not know that Squid can often reuse some of those idle connections. with: max-conn

Re: [PATCH] cache_peer standby=N

2014-04-29 Thread Amos Jeffries
On 30/04/2014 4:00 a.m., Tsantilas Christos wrote: To summarize, the requested changes are: *in cf.data.pre: replace: max-conn limit works poorly when there is a relatively large number of idle persistent connections with the peer because the limiting code does not know that Squid can

Re: [PATCH] cache_peer standby=N

2014-04-28 Thread Alex Rousskov
On 04/27/2014 10:02 PM, Amos Jeffries wrote: We should state the problem with idles clearly (yes it is difficult to word), We already do that: + max-conn limit works poorly when there is a relatively + large number of idle persistent connections with

Re: [PATCH] cache_peer standby=N

2014-04-27 Thread Amos Jeffries
On 26/04/2014 9:33 p.m., Tsantilas Christos wrote: Hi all. This patch implements standby=N option for cache_peer configuration parameter. This feature already discussed under the steady peer connection pool and [PREVIEW] cache_peer standby=N squid-dev mail threads. This patch support SSL

Re: [PATCH] cache_peer standby=N

2014-04-27 Thread Alex Rousskov
On 04/27/2014 06:09 AM, Amos Jeffries wrote: in cf.data.pre: * the new documentation for cache_peer max-conn= now states that idle connections count against teh limit Yes, they do. The patch did not change that. then goes on to: A peer exceeding the limit is not used for new

Re: [PATCH] cache_peer standby=N

2014-04-27 Thread Amos Jeffries
On 28/04/2014 5:19 a.m., Alex Rousskov wrote: On 04/27/2014 06:09 AM, Amos Jeffries wrote: in cf.data.pre: * the new documentation for cache_peer max-conn= now states that idle connections count against teh limit Yes, they do. The patch did not change that. then goes on to: A