Re: EventDialer cbdataReference abuse

2008-02-24 Thread Alex Rousskov
On Sat, 2008-02-23 at 14:42 +0100, Henrik Nordström wrote: The idea with cbdata is that when you are given a cbdata enabled object use cbdataReference on it to get a reference safe to be saved between call events. Sorry, my fault. I did not realize that cbdata API defines cbdata reference as

EventDialer cbdataReference abuse

2008-02-23 Thread Henrik Nordström
http://www.squid-cache.org/Versions/v3/HEAD/changesets/11438.patch This is plain wrong use of cbdataReference(). cbdataReference returns a reference to the cbdata object, and you are meant to use cbdataReferenceDone on that reference when done. The current implementation happens to return the

Re: EventDialer cbdataReference abuse

2008-02-23 Thread Henrik Nordström
lör 2008-02-23 klockan 13:34 +0100 skrev Henrik Nordström: The idea with cbdata is that when you are given a cbdata enabled object use cbdataReference on it to get a reference safe to be saved between call events. Then use cbdataReferenceValid to verify it's validity if needed,