Re: More patches for squid2-HEAD

2009-05-20 Thread Mark Nottingham
On 2-HEAD. On 14/05/2009, at 6:36 PM, Mark Nottingham wrote: On 23/04/2009, at 10:38 AM, Mark Nottingham wrote: http://www.squid-cache.org/bugs/show_bug.cgi?id=2643 http://www.squid-cache.org/bugs/show_bug.cgi?id=2631 These are the last two remaining. There's been some discussion on

Re: More patches for squid2-HEAD

2009-05-14 Thread Mark Nottingham
On 23/04/2009, at 10:38 AM, Mark Nottingham wrote: http://www.squid-cache.org/bugs/show_bug.cgi?id=2643 http://www.squid-cache.org/bugs/show_bug.cgi?id=2631 These are the last two remaining. There's been some discussion on them, but I believe the issues have been resolved in the most

Re: More patches for squid2-HEAD

2009-04-23 Thread Henrik Nordstrom
tor 2009-04-23 klockan 13:22 +1000 skrev Mark Nottingham: OK. Henrik? FWIW, I think this is the right way to do it -- a flag saying that monitoring should be direct is backwards-compatible, easy for users to understand, and addresses the use case. Almost. The flag should make the

Re: More patches for squid2-HEAD

2009-04-22 Thread Mark Nottingham
On 21/04/2009, at 10:44 AM, Mark Nottingham wrote: http://www.squid-cache.org/bugs/show_bug.cgi?id=2642 Seems uncontroversial, applying. http://www.squid-cache.org/bugs/show_bug.cgi?id=2643 Amos, any thoughts about the revised patch (monitor-direct)?

Re: More patches for squid2-HEAD

2009-04-22 Thread Amos Jeffries
On 21/04/2009, at 10:44 AM, Mark Nottingham wrote: snip http://www.squid-cache.org/bugs/show_bug.cgi?id=2643 Amos, any thoughts about the revised patch (monitor-direct)? I still don't agree that this is anything close to the Right Way to do it. Easy, yes, but thats all. Please hold off

Re: More patches for squid2-HEAD

2009-04-22 Thread Mark Nottingham
On 23/04/2009, at 2:11 PM, Amos Jeffries wrote: On 21/04/2009, at 10:44 AM, Mark Nottingham wrote: snip http://www.squid-cache.org/bugs/show_bug.cgi?id=2643 Amos, any thoughts about the revised patch (monitor-direct)? I still don't agree that this is anything close to the Right Way

Re: More patches for squid2-HEAD

2009-04-20 Thread Amos Jeffries
Mark Nottingham wrote: Unless I hear otherwise, I'm going to apply the patches attached to the following bugs: http://www.squid-cache.org/bugs/show_bug.cgi?id=2631 response in bugzilla. http://www.squid-cache.org/bugs/show_bug.cgi?id=2632 IMO, this should be number of times squid tries

Re: More patches for squid2-HEAD

2009-04-20 Thread Mark Nottingham
Responses inline, and a couple more: http://www.squid-cache.org/bugs/show_bug.cgi?id=2642 http://www.squid-cache.org/bugs/show_bug.cgi?id=2643 On 20/04/2009, at 4:46 PM, Amos Jeffries wrote: Mark Nottingham wrote: Unless I hear otherwise, I'm going to apply the patches attached to the

Re: More patches for squid2-HEAD

2009-04-20 Thread Mark Nottingham
Responses inline, and a couple more: http://www.squid-cache.org/bugs/show_bug.cgi?id=2642 http://www.squid-cache.org/bugs/show_bug.cgi?id=2643 On 20/04/2009, at 4:46 PM, Amos Jeffries wrote: Mark Nottingham wrote: Unless I hear otherwise, I'm going to apply the patches attached to the

Re: More patches for squid2-HEAD

2009-04-20 Thread Amos Jeffries
Responses inline, and a couple more: http://www.squid-cache.org/bugs/show_bug.cgi?id=2642 http://www.squid-cache.org/bugs/show_bug.cgi?id=2643 On 20/04/2009, at 4:46 PM, Amos Jeffries wrote: Mark Nottingham wrote: Unless I hear otherwise, I'm going to apply the patches attached to the

Re: More patches for squid2-HEAD

2009-04-20 Thread Mark Nottingham
Yeah, this came up in another bug as well, don't remember where, but really this whole section needs to be reworked pretty extensively; this is just a way to fine-tune the current behaviour until we figure out what the right thing to do should be (and I suspect that's not a trivial task).

Re: More patches for squid2-HEAD

2009-04-20 Thread Amos Jeffries
Responses inline, and a couple more: http://www.squid-cache.org/bugs/show_bug.cgi?id=2642 I can't tell from the patch which one is being remove. +1 if its the one directly in mainReconfigure() peerMonitorInit() should probably check for duplicate calls somehow too. But this is good for a

Re: More patches for squid2-HEAD

2009-04-20 Thread Mark Nottingham
On 21/04/2009, at 1:24 PM, Amos Jeffries wrote: Responses inline, and a couple more: http://www.squid-cache.org/bugs/show_bug.cgi?id=2642 I can't tell from the patch which one is being remove. +1 if its the one directly in mainReconfigure() Yep. peerMonitorInit() should probably

Re: More patches for squid2-HEAD

2009-04-20 Thread Amos Jeffries
Yeah, this came up in another bug as well, don't remember where, but really this whole section needs to be reworked pretty extensively; this is just a way to fine-tune the current behaviour until we figure out what the right thing to do should be (and I suspect that's not a trivial task).

More patches for squid2-HEAD

2009-04-19 Thread Mark Nottingham
Unless I hear otherwise, I'm going to apply the patches attached to the following bugs: http://www.squid-cache.org/bugs/show_bug.cgi?id=2631 http://www.squid-cache.org/bugs/show_bug.cgi?id=2632 http://www.squid-cache.org/bugs/show_bug.cgi?id=2515 -- Mark Nottingham m...@yahoo-inc.com