On 06/23/2014 11:58 PM, Amos Jeffries wrote:
On 24/06/2014 4:07 p.m., Alex Rousskov wrote:
* Do not abandon writing a collapsed cache entry when we cannot cache
the entry in RAM if the entry can be cached on disk instead. Both shared
memory cache and the disk cache have to refuse to cache the
We can't know except by hammering it.
Did you run coadvisor and polygraph against it?
If not, and if the branch is public, it's trivial tor un them against
it now (thanks TMF, thanks Pavel!). It doesn't guarantee to catch all
cases, but at least it should raise confidence.
On Tue, Jun 24, 2014 at
On 06/24/2014 12:55 PM, Kinkie wrote:
Did you run coadvisor and polygraph against it?
Co-Advisor does not have collapsed forwarding cases (there are no
explicit RFC 2616 MUSTs that cover CF although some cases can be
certainly added to test some MUSTs in a CF context).
Polygraph can be used
Amos already +1-ed the patch, I have no insights to add so unless
someone speaks up real fast, we proceed.
On Tue, Jun 24, 2014 at 9:29 PM, Alex Rousskov
rouss...@measurement-factory.com wrote:
On 06/24/2014 12:55 PM, Kinkie wrote:
Did you run coadvisor and polygraph against it?
Co-Advisor
On 06/24/2014 01:44 PM, Kinkie wrote:
Amos already +1-ed the patch, I have no insights to add so unless
someone speaks up real fast, we proceed.
Committed to trunk as r13476 and r13477.
Thank you,
Alex.
On Tue, Jun 24, 2014 at 9:29 PM, Alex Rousskov
rouss...@measurement-factory.com
On 24/06/2014 4:07 p.m., Alex Rousskov wrote:
Hello,
The attached patch contains several changes to improve the
probability of getting a collapsed forwarding hit:
* Allow STORE_MEMORY_CLIENTs to open disk files if needed and possible.
STORE_*_CLIENT designation is rather buggy
