Re: [PATCH] rock fixes and improvements

2014-06-24 Thread Alex Rousskov
On 04/29/2014 05:29 AM, Amos Jeffries wrote: +1. All good apart form one minor nit: src/tests/stub_store.cc * the new checkCacheable() needs to be STUB_RETVAL(false). That can be added on merge. Finally merged as trunk r13475. Please note that another, unaudited fix for a frequent

Re: [PATCH] rock fixes and improvements

2014-04-29 Thread Amos Jeffries
+1. All good apart form one minor nit: src/tests/stub_store.cc * the new checkCacheable() needs to be STUB_RETVAL(false). That can be added on merge. Thank you for all these Amos

Re: [PATCH] rock fixes and improvements

2014-04-28 Thread Amos Jeffries
On 27/04/2014 6:09 a.m., Alex Rousskov wrote: Hello, The attached patch contains several fixes and improvements of the shared memory and rock disk caching code, some of them quite important. Here is the summary (detailed change descriptions are quoted at the end of this message): in