Re: building async-calls

2007-12-17 Thread Robert Collins
On Sun, 2007-12-16 at 21:57 +0900, Adrian Chadd wrote: On Sun, Dec 16, 2007, Tsantilas Christos wrote: OK Adrian I fixed this too. You can build the async-calls without enabling of ICAP client. Next question - if I read this code right, a class is instanced for every async

Re: building async-calls

2007-12-17 Thread Tsantilas Christos
Hi Adrian, As I am seeing squid3 spends time in EventScheduler::schedule method. This method did not affected by the new AsyncCall code. Also this method is similar with squid 2.6 eventAdd function. The only I can say is that possibly we are scheduling a huge number of events in squid3. If the

Re: building async-calls

2007-12-17 Thread Adrian Chadd
On Mon, Dec 17, 2007, Tsantilas Christos wrote: Hi Adrian, If you just worry about performance of AsyncCalls/JobCalls design lets waiting to have a progress in AsyncCalls development and see how performs. Hey I'm glad to, as long as people test resource use regressions as they're developing.

Re: building async-calls

2007-12-16 Thread Tsantilas Christos
Hi Adrian, I commit some changes to async-calls branch and now compiles (but does not link) without ICAP client enabled. Currently you have to enable ICAP client to build async-calls. The reason is that the src/ICAP/AsyncJob.o used in AsyncCalls but built only as part of ICAP client library.

Re: building async-calls

2007-12-16 Thread Adrian Chadd
On Sun, Dec 16, 2007, Tsantilas Christos wrote: Hi Adrian, I commit some changes to async-calls branch and now compiles (but does not link) without ICAP client enabled. Currently you have to enable ICAP client to build async-calls. The reason is that the src/ICAP/AsyncJob.o used in

Re: building async-calls

2007-12-16 Thread Tsantilas Christos
Adrian Chadd wrote: On Sun, Dec 16, 2007, Tsantilas Christos wrote: Currently you have to enable ICAP client to build async-calls. The reason is that the src/ICAP/AsyncJob.o used in AsyncCalls but built only as part of ICAP client library. OK Adrian I fixed this too. You can build the

Re: building async-calls

2007-12-16 Thread Adrian Chadd
On Sun, Dec 16, 2007, Tsantilas Christos wrote: OK Adrian I fixed this too. You can build the async-calls without enabling of ICAP client. Next question - if I read this code right, a class is instanced for every async callback being scheduled, is this true? Yes this is true. An

Re: building async-calls

2007-12-16 Thread Tsantilas Christos
Adrian Chadd wrote: On Sun, Dec 16, 2007, Tsantilas Christos wrote: Yes this is true. An AsyncCall class instanced for every async callback. And the comm code is going to register one of these per comm events? Yes. Have you benchmarked what that'll do to performance? :) Maybe has some

Re: building async-calls

2007-12-16 Thread Adrian Chadd
On Sun, Dec 16, 2007, Tsantilas Christos wrote: Have you benchmarked what that'll do to performance? :) Maybe has some performance penalty. But if there is a performance decrease, I do not think that it is huge. Normally creating a class is not more costly than creating a C struct and

Re: building async-calls

2007-12-16 Thread Amos Jeffries
On Sun, Dec 16, 2007, Tsantilas Christos wrote: Have you benchmarked what that'll do to performance? :) Maybe has some performance penalty. But if there is a performance decrease, I do not think that it is huge. Normally creating a class is not more costly than creating a C struct and

Re: building async-calls

2007-12-16 Thread Adrian Chadd
On Mon, Dec 17, 2007, Amos Jeffries wrote: Adrian, I've tried to do some profiling myself recently but am stuck getting those nice stats you post out of it. (Last time I did profiling was in VisualStudio). Could you send me or the list a how-to on using the cpu-profiling feature, from

Re: building async-calls

2007-12-16 Thread Amos Jeffries
On Mon, Dec 17, 2007, Amos Jeffries wrote: Adrian, I've tried to do some profiling myself recently but am stuck getting those nice stats you post out of it. (Last time I did profiling was in VisualStudio). Could you send me or the list a how-to on using the cpu-profiling feature, from

building async-calls

2007-12-15 Thread Adrian Chadd
trying to build async-calls: client_side_request.h:67: error: expected class-name before ???{??? token cc1plus: warnings being treated as errors client_side_request.h:67: warning: ???class ClientHttpRequest??? has virtual functions but non-virtual destructor client_side_request.h: In member