Re: cvs commit: squid3/lib MemPool.cc

2007-05-23 Thread Amos Jeffries
Alex Rousskov wrote: rousskov2007/05/22 10:40:06 MDT Modified files: lib MemPool.cc Log: Bug #1966 fix: Use rounded String MemPool sizes in the hard-coded pool config to avoid warnings that the configured pool size does not match the actual size.

Re: cvs commit: squid3/lib MemPool.cc

2007-05-23 Thread Henrik Nordstrom
tor 2007-05-24 klockan 00:59 +1200 skrev Amos Jeffries: Did you run make check before committing any of the days changes? I'm getting 7 of 14 core unit tests fail. Two on MemPool.cc:240, the rest on silent segfault. Assertion failed: (aLabel != NULL aSize) at MemPool.cc:240 Hmm...

Re: cvs commit: squid3/lib MemPool.cc

2007-05-23 Thread Robert Collins
On Wed, 2007-05-23 at 22:49 +0200, Henrik Nordstrom wrote: Mem::Init needs to be called via the setUp() method, not from an automatic instantiation constructor.. Actually I spent quite some time making it work correctly without setUp. I think manual setup is very annoying and error prone: if

Re: cvs commit: squid3/lib MemPool.cc

2007-05-23 Thread Henrik Nordstrom
tor 2007-05-24 klockan 06:58 +1000 skrev Robert Collins: On Wed, 2007-05-23 at 22:49 +0200, Henrik Nordstrom wrote: Mem::Init needs to be called via the setUp() method, not from an automatic instantiation constructor.. Actually I spent quite some time making it work correctly without

Re: cvs commit: squid3/lib MemPool.cc

2007-05-23 Thread Alex Rousskov
On Thu, 2007-05-24 at 00:59 +1200, Amos Jeffries wrote: Alex Rousskov wrote: rousskov2007/05/22 10:40:06 MDT Modified files: lib MemPool.cc Log: Bug #1966 fix: Use rounded String MemPool sizes in the hard-coded pool config to avoid warnings that