source code reorg makefiles

2009-05-11 Thread Robert Collins
I have one small request vis-a-vis the source code reorg. Please don't undo the non-recursive make support. I put a lot of effort into getting it where it was up to (even though that wasn't propogated across the entire code base). It makes a substantial difference to correctness, performance and

Re: source code reorg makefiles

2009-05-11 Thread Amos Jeffries
Robert Collins wrote: I have one small request vis-a-vis the source code reorg. Please don't undo the non-recursive make support. I put a lot of effort into getting it where it was up to (even though that wasn't propogated across the entire code base). It makes a substantial difference to

3.0 assertion in comm.cc:572

2009-05-11 Thread Amos Jeffries
We have one user with a fairly serious production machine hitting this assertion. It's an attempted comm_read of closed FD after reconfigure. Nasty, but I think the asserts can be converted to a nop return. Does anyone know of a subsystem that would fail badly after a failed read with all its

Re: [squid-users] Error making squid-3.1.0.7-20090412 on Mac OS X 10.4

2009-05-11 Thread vollkommen
Here's what I did and the outcome, with squid-3.HEAD-20090511: patch -p0 b9683.patch vi src/asn.cc /* template cbdata_type CbDataListint::CBDATA_CbDataList; */ Then 2) 3). /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I../.. -I../../include -I../../src -I

Re: source code reorg makefiles

2009-05-11 Thread Robert Collins
On Tue, 2009-05-12 at 01:48 +1200, Amos Jeffries wrote: Can you explain a bit more detail please? what are you seeing us do wrong? we are not trying to remove anything at this point AFAIK. acl is the one I noticed; but I had the others building non-recursively too. Non-recursive make is

Re: [squid-users] CARP Failover behavior - multiple parents chosen for URL

2009-05-11 Thread Chris Woodfield
Moving this to squid-dev due to increasingly propellerhead-like content... :) Looking over the code and some debugging output, it's pretty clear what's happening here. The carpSelectParent() function does the appropriate hashing of each URL+parent hash and the requisite ranking of the

Re: 3.0 assertion in comm.cc:572

2009-05-11 Thread Adrian Chadd
2009/5/11 Amos Jeffries squ...@treenet.co.nz: We have one user with a fairly serious production machine hitting this assertion. It's an attempted comm_read of closed FD after reconfigure. Nasty, but I think the asserts can be converted to a nop return. Does anyone know of a subsystem that

Re: One final (?) set of patches for 2.HEAD

2009-05-11 Thread Mark Nottingham
All applied to 2-HEAD. On 09/05/2009, at 12:43 PM, Amos Jeffries wrote: Mark Nottingham wrote: Just a few more; HTCP logging http://www.squid-cache.org/bugs/show_bug.cgi?id=2627 +1. ignore-must-revalidate http://www.squid-cache.org/bugs/show_bug.cgi?id=2645 +1. Create request

Re: [squid-users] CARP Failover behavior - multiple parents chosen for URL

2009-05-11 Thread Mark Nottingham
A patch to make PEER_TCP_MAGIC_COUNT configurable is on 2-HEAD; http://www.squid-cache.org/Versions/v2/HEAD/changesets/12208.patch Cheers, On 12/05/2009, at 1:15 PM, Chris Woodfield wrote: 1. Adjust PEER_TCP_MAGIC_COUNT from 10 to 1, so that a parent is marked DEAD after only one

Re: [squid-users] CARP Failover behavior - multiple parents chosen for URL

2009-05-11 Thread Amos Jeffries
Moving this to squid-dev due to increasingly propellerhead-like content... :) Looking over the code and some debugging output, it's pretty clear what's happening here. The carpSelectParent() function does the appropriate hashing of each URL+parent hash and the requisite ranking of the