Re: debugs from an interesting CBDATA case study

2014-01-21 Thread Amos Jeffries
On 14/01/2014 3:31 p.m., Alex Rousskov wrote: On 01/07/2014 08:35 AM, Alex Rousskov wrote: 2) [Add cbdata debugging to] find which object stores the invalid cbdata pointer. Then find how that invalid pointer gets to that object. I think it happens here: #8 0x0834f190 in

Re: [PATCH] use nullptr more?

2014-01-21 Thread Kinkie
On Tue, Jan 21, 2014 at 2:31 AM, Amos Jeffries squ...@treenet.co.nz wrote: On 2014-01-21 12:47, Alex Rousskov wrote: On 01/20/2014 02:28 PM, Amos Jeffries wrote: On 2014-01-21 08:05, Alex Rousskov wrote: On 01/20/2014 08:15 AM, Kinkie wrote: the attached patch is an attempt

Re: [RFC] FTP gw source layout

2014-01-21 Thread Tsantilas Christos
On 01/20/2014 08:45 PM, Alex Rousskov wrote: Hello, FTP gateway[1] code[2] work well, and we are polishing it for the official submission. The biggest change we need to make is to rearrange where the new code lives in Squid src directory. In this email, I am proposing how to structure

Re: [RFC] FTP gw source layout

2014-01-21 Thread Henrik Nordström
mån 2014-01-20 klockan 11:45 -0700 skrev Alex Rousskov: FTP gateway[1] code[2] work well, and we are polishing it for the official submission. The biggest change we need to make is to rearrange where the new code lives in Squid src directory. For the record I have no opinion on either of

Re: [RFC] FTP gw source layout

2014-01-21 Thread Alex Rousskov
[ A specific revised proposal is at the end of this email, after the discussion. ] On 01/20/2014 03:30 PM, Amos Jeffries wrote: On 2014-01-21 07:45, Alex Rousskov wrote: I propose the following arrangement for the official submission: src/out/FtpServer.* # code shared by old and new FTP

Re: [RFC] FTP gw source layout

2014-01-21 Thread Amos Jeffries
On 2014-01-22 10:37, Alex Rousskov wrote: [ A specific revised proposal is at the end of this email, after the discussion. ] On 01/20/2014 03:30 PM, Amos Jeffries wrote: On 2014-01-21 07:45, Alex Rousskov wrote: I propose the following arrangement for the official submission:

Re: [RFC] FTP gw source layout

2014-01-21 Thread Alex Rousskov
On 01/21/2014 03:54 PM, Amos Jeffries wrote: [ On a side note shall we make a proper effort to fix that confusion by deprecating our use of the terms and call bits client or server by functionality? it would be as easy to describe these area-based parts as client-facing or server-facing areas

Re: [PATCH] client-side redesign pt1 - Comm::TcpReceiver

2014-01-21 Thread Alex Rousskov
On 01/07/2014 02:52 AM, Amos Jeffries wrote: Updated patch attaced for audit. This one includes all the currently known bits for server-side delay pools so no audit omissions this time around. On 4/01/2014 8:16 a.m., Alex Rousskov wrote: On 12/03/2013 10:05 PM, Amos Jeffries wrote: This