Re: [PATCH] rock fixes and improvements

2014-04-29 Thread Amos Jeffries
+1. All good apart form one minor nit: src/tests/stub_store.cc * the new checkCacheable() needs to be STUB_RETVAL(false). That can be added on merge. Thank you for all these Amos

Re: [PATCH] cache_peer standby=N

2014-04-29 Thread Amos Jeffries
On 29/04/2014 8:46 a.m., Alex Rousskov wrote: On 04/27/2014 10:02 PM, Amos Jeffries wrote: We should state the problem with idles clearly (yes it is difficult to word), We already do that: +max-conn limit works poorly when there is a relatively +

Re: [PATCH] ConnStateData flexible transport support

2014-04-29 Thread Amos Jeffries
On 29/04/2014 9:12 a.m., Alex Rousskov wrote: On 04/28/2014 07:10 AM, Amos Jeffries wrote: * ssl-bump transforms the transportVersion from whatever it was previously (usually HTTP or HTTPS) to HTTPS. +/// the transport protocol currently being spoken on this connection +

Re: [PATCH] cache_peer standby=N

2014-04-29 Thread Alex Rousskov
On 04/29/2014 05:48 AM, Amos Jeffries wrote: On 29/04/2014 8:46 a.m., Alex Rousskov wrote: On 04/27/2014 10:02 PM, Amos Jeffries wrote: We should state the problem with idles clearly (yes it is difficult to word), We already do that: + max-conn limit works poorly when

Re: [PATCH] ConnStateData flexible transport support

2014-04-29 Thread Alex Rousskov
On 04/29/2014 06:03 AM, Amos Jeffries wrote: I'm fine with transferProtocol or just protocol (although that may get as common as conn has become). Whichever suits you. Let's avoid protocol for the reasons you mentioned and use transferProtocol. This variable can be altered whenever

How long is a domain or url can be?

2014-04-29 Thread Eliezer Croitoru
I am working on external_acl helper and I want to work with a DB of urls and domains. I know that there is a limit for domains size and urls size but I am not sure where to look for it(rfc?) or what is it? Since the DB in hands is mysql I have the options to use one of two or three variable

Re: /bzr/squid3/trunk/ r13384: Bug 1961: pt1: URL handling redesign

2014-04-29 Thread Tsantilas Christos
On 04/28/2014 04:57 AM, Amos Jeffries wrote: On 28/04/2014 5:35 a.m., Tsantilas Christos wrote: Unfortunately this is not build with ecap. The ecap uses the HttpMsg::protocol, to describe protocol for both requests and responses. Looks that HttpReply::protocol was never set (Am I loosing

Re: [PATCH] cache_peer standby=N

2014-04-29 Thread Amos Jeffries
On 30/04/2014 2:10 a.m., Alex Rousskov wrote: On 04/29/2014 05:48 AM, Amos Jeffries wrote: On 29/04/2014 8:46 a.m., Alex Rousskov wrote: On 04/27/2014 10:02 PM, Amos Jeffries wrote: We should state the problem with idles clearly (yes it is difficult to word), We already do that: +

Re: How long is a domain or url can be?

2014-04-29 Thread Kinkie
http://www.boutell.com/newfaq/misc/urllength.html Squid defines MAX_URL at 8KiB (in src/defines.h) On Tue, Apr 29, 2014 at 4:40 PM, Eliezer Croitoru elie...@ngtech.co.il wrote: I am working on external_acl helper and I want to work with a DB of urls and domains. I know that there is a limit

Re: [PATCH] cache_peer standby=N

2014-04-29 Thread Tsantilas Christos
To summarize, the requested changes are: *in cf.data.pre: replace: max-conn limit works poorly when there is a relatively large number of idle persistent connections with the peer because the limiting code does not know that Squid can often reuse some of those idle connections. with: max-conn

Re: How long is a domain or url can be?

2014-04-29 Thread Eliezer Croitoru
Thanks, I have seen this url and I remembered that there was something inside squid. I assumed that based on this link it should be pretty high. I noticed that apache web server has the limit of 128KB for a url. So I am a bit confused but I am thinking about url filtering DB. Eliezer On

Re: [PATCH] cache_peer standby=N

2014-04-29 Thread Amos Jeffries
On 30/04/2014 4:00 a.m., Tsantilas Christos wrote: To summarize, the requested changes are: *in cf.data.pre: replace: max-conn limit works poorly when there is a relatively large number of idle persistent connections with the peer because the limiting code does not know that Squid can

Re: How long is a domain or url can be?

2014-04-29 Thread Francesco
Well, Squid can't send you more than 8 KiB, so I'd consider that as a limit. Most browser will send much shorter URLs than that, if the page I refereced is to be believed. Kinkie On 29 Apr 2014, at 18:02, Eliezer Croitoru elie...@ngtech.co.il wrote: Thanks, I have seen this url and

Re: How long is a domain or url can be?

2014-04-29 Thread Amos Jeffries
On 30/04/2014 4:02 a.m., Eliezer Croitoru wrote: Thanks, I have seen this url and I remembered that there was something inside squid. I assumed that based on this link it should be pretty high. I noticed that apache web server has the limit of 128KB for a url. So I am a bit confused

Re: /bzr/squid3/trunk/ r13384: Bug 1961: pt1: URL handling redesign

2014-04-29 Thread Amos Jeffries
On 30/04/2014 2:47 a.m., Tsantilas Christos wrote: On 04/28/2014 04:57 AM, Amos Jeffries wrote: On 28/04/2014 5:35 a.m., Tsantilas Christos wrote: Unfortunately this is not build with ecap. The ecap uses the HttpMsg::protocol, to describe protocol for both requests and responses. Looks that

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-10 #55

2014-04-29 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-FreeBSD-10/55/changes Changes: [Amos Jeffries] Fix order dependency between cache_dir and maximum_object_size parse_cachedir() has a call to update_maxobjsize() which limits the store_maxobjsize variable used as the internal maximum_object_size

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-10-clang #55

2014-04-29 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-FreeBSD-10-clang/55/changes Changes: [Amos Jeffries] Fix order dependency between cache_dir and maximum_object_size parse_cachedir() has a call to update_maxobjsize() which limits the store_maxobjsize variable used as the internal

Build failed in Jenkins: 3.HEAD-amd64-OpenBSD-5.4 #58

2014-04-29 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-OpenBSD-5.4/58/ -- Started by upstream project 3.HEAD-amd64-centos-6 build number 317 originally caused by: Started by an SCM change Building remotely on ypg-openbsd-54 (gcc farm amd64-openbsd 5.4

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-10 #56

2014-04-29 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-FreeBSD-10/56/changes Changes: [Amos Jeffries] Resolve 'dying from an unhandled exception: c' CbcPointer is used from code outside of Job protection where it is safe to use Must(). In order to get a useful backtrace we need to assert immediately

Build failed in Jenkins: 3.HEAD-amd64-OpenBSD-5.4 #59

2014-04-29 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-OpenBSD-5.4/59/ -- Started by upstream project 3.HEAD-amd64-centos-6 build number 318 originally caused by: Started by an SCM change Building remotely on ypg-openbsd-54 (gcc farm amd64-openbsd 5.4