Re: cvs commit: squid3/src ftp.cc

2007-08-13 Thread Guido Serassio
Hi Amos, At 01.57 13/08/2007, Amos Jeffries wrote: amosjeffries2007/08/12 17:57:28 MDT Modified files: src ftp.cc Log: Fix bug 1560 : Bad filedescriptor in ftpSend actions. Something is missing in your commit: if /usr/bin/g++-3.4 -DHAVE_CONFIG_H

Re: squid3-ipv6 squid3/src HttpHeader.cc,1.18.4.8,1.18.4.9 cache_manager.cc,1.7.8.3,1.7.8.4 client_db.cc,1.5.4.14,1.5.4.15 event.cc,1.5.8.5,1.5.8.6

2007-08-13 Thread Alex Rousskov
On Fri, 2007-08-10 at 23:35 +1200, Amos Jeffries wrote: Any objections to these going into 3-HEAD? Baring the seconds precision drop to 3dp (aka ms), its all whitespace. White space changes are obviously OK. If change in precision affects statistics reporting only, then it should be OK as well.

Re: cvs commit: squid3/src ftp.cc

2007-08-13 Thread Alex Rousskov
On Mon, 2007-08-13 at 12:01 +0200, Guido Serassio wrote: Now fixed. If you have time, it may be better to replace a virtual FtpStateData::haveControlChannel(char*) into a static FtpStateData::HaveControlChannel(FtpStateData*, char*) and let it check the ftpState pointer itself. This will avoid

Re: Squid 3 build error using Visual Studio

2007-08-13 Thread Alex Rousskov
On Sat, 2007-08-11 at 23:06 +0200, Serassio Guido wrote: Hi, Trying to build the current Squid 3 source using Visual Studio 2005 on Windows, I get the following error. Any C++ suggestion ? Compiling... mem.cc c:\work\nt-3.0\src\StoreEntryStream.h(119) : error C2512:

Re: cvs commit: squid3/src BodyPipe.cc BodyPipe.h

2007-08-13 Thread Amos Jeffries
rousskov2007/08/13 10:48:20 MDT snip The new code also keeps track of the number of outstanding events and skips that number if the consumer leaves. TODO: when AscyncCall support is improved, should we just schedule calls directly to consumer? It could be a much cleaner

Documentation bugs

2007-08-13 Thread Mark Nottingham
I've filed a number of bugs against squid.conf; http://www.squid-cache.org/bugs/show_bug.cgi?id=1952 http://www.squid-cache.org/bugs/show_bug.cgi?id=1953 http://www.squid-cache.org/bugs/show_bug.cgi?id=1954 http://www.squid-cache.org/bugs/show_bug.cgi?id=1955

Re: Documentation bugs

2007-08-13 Thread Henrik Nordstrom
On tis, 2007-08-14 at 11:25 +1000, Mark Nottingham wrote: What's the best way to get these incorporated? To do what you just did.. keep reminding us. Regards Henrik signature.asc Description: This is a digitally signed message part