ACL for header_replace

2008-11-13 Thread timdau
(I sent this email individually to Henrick but he suggested I email here)

I have a strong need for bug ID 1195, which is a feature request to
enable ACL's for header_replace.

http://www.squid-cache.org/bugs/show_bug.cgi?id=1195

Would someone be willing at accept a small amount of money to provide
this patch?  Like $100?

Ideally the patch would be good enough to eventually be incorporated
into mainstream squid, but initially I would apply it to 3.0 stable or
any stable version you want.

Thanks for your consideration,
--
Paul


Snapshots on HEAD

2008-11-13 Thread Amos Jeffries

As some of you may have noticed there have been no snapshots on HEAD for
about a week now. I'll stick my hand up for causing it. But in a good way.

I've added a dependency on snapshots so they only generate when the
TestBed gives the code a clean bill of health.

This has brought to view several assertions which have been occurring in
the IO and IP layers. I'd like to add this test layer to 3.1 also, which
presently shows the errors but doesn't stop snapshots. The current issues
need to be resolved first.

I've spent some time this week trying to find fixes without much luck.
It's open season on them if anyone can figure it out.

The issues I'm aware of so far are:

 * errors in DiskIO when no module is available (NULL result from 'smart'
module location).

 * unknown segfault in testUfs handling. possibly due to the above.

 * FreeBSD-specific failure to set (ss|sin)_len on generated sockaddr_*

Amos



access_log acl not observing my_port

2008-11-13 Thread Stephen Thorne
G'day,

I've been looking into a problem we've observed where this situation
does not work as expected, this is in squid-2.7.STABLE4:

acl direct myport 8080
access_log /var/log/squid/direct_proxy.log common direct

I did some tracing through the code and established that this chain of
events occurs:
httpRequestFree calls clientAclChecklistCreate calls aclChecklistCreate

But aclChecklistCacheInit is the function that populates the
checklist-my_port, which is required for a myport acl to work, and it
isn't called.

I have attached a patch that fixes this particular problem for me, which
simply calls aclChecklistCacheInit in clientAclChecklistCreate.

-- 
Regards,
Stephen Thorne
Development Engineer
NetBox Blue - 1300 737 060

Scanned by the NetBox from NetBox Blue
(http://netboxblue.com/)


Scanned by the NetBox from NetBox Blue
(http://netboxblue.com/)

--- squid/src/client_side.c 2008-11-14 15:07:55.0 +1000
+++ squid/src/client_side.c.new 2008-11-14 15:08:32.0 +1000
@@ -211,6 +211,7 @@
 ch = aclChecklistCreate(acl,
http-request,
conn-rfc931);
+aclChecklistCacheInit(ch);
 
 /*
  * hack for ident ACL. It needs to get full addresses, and a


Re: access_log acl not observing my_port

2008-11-13 Thread Adrian Chadd
g'day!

Just create a ticket in the Squid bugzilla and put the patch into there.

Thanks for your contribution!



Adrian


2008/11/13 Stephen Thorne [EMAIL PROTECTED]:
 G'day,

 I've been looking into a problem we've observed where this situation
 does not work as expected, this is in squid-2.7.STABLE4:

 acl direct myport 8080
 access_log /var/log/squid/direct_proxy.log common direct

 I did some tracing through the code and established that this chain of
 events occurs:
 httpRequestFree calls clientAclChecklistCreate calls aclChecklistCreate

 But aclChecklistCacheInit is the function that populates the
 checklist-my_port, which is required for a myport acl to work, and it
 isn't called.

 I have attached a patch that fixes this particular problem for me, which
 simply calls aclChecklistCacheInit in clientAclChecklistCreate.

 --
 Regards,
 Stephen Thorne
 Development Engineer
 NetBox Blue - 1300 737 060

 Scanned by the NetBox from NetBox Blue
 (http://netboxblue.com/)


 Scanned by the NetBox from NetBox Blue
 (http://netboxblue.com/)