Re: /bzr/squid3/trunk/ r9532: Regression Fix: Bug 2586: Memory leaks on reconfigure

2009-02-24 Thread Alex Rousskov
On 02/23/2009 05:28 PM, Amos Jeffries wrote: revno: 9532 committer: Christos Tsantilas chtsa...@users.sourceforge.net branch nick: TRUNK timestamp: Tue 2009-02-24 01:18:23 +0200 message: Regression Fix: Bug 2586: Memory leaks on

Re: /bzr/squid3/trunk/ r9532: Regression Fix: Bug 2586: Memory leaks on reconfigure

2009-02-24 Thread Christos Tsantilas
revno: 9532 committer: Christos Tsantilas chtsa...@users.sourceforge.net branch nick: TRUNK timestamp: Tue 2009-02-24 01:18:23 +0200 message: Regression Fix: Bug 2586: Memory leaks on reconfigure The patch is not correct.

Re: /bzr/squid3/trunk/ r9532: Regression Fix: Bug 2586: Memory leaks on reconfigure

2009-02-24 Thread Tsantilas Christos
Alex Rousskov wrote: On 02/23/2009 05:28 PM, Amos Jeffries wrote: Sigh, another design flaw in the current config handling. Exactly how are they in use, and which ones? NP: reconfigure and shutdown both call the free-up after all client connections are supposed to be dead. And all non-memory

Re: Sbuf review at r9331

2009-02-24 Thread Kinkie
- check that the function names in debugs() statements match their actual name (there's been quite a lot of shuffling) Please use debugs(..., HERE blah) for that sort of thing at levels 1. I've also just added MYNAME for prettier but identical use on the top two levels. Now done. --

Re: Associating accesses with cache.log entries

2009-02-24 Thread Mark Nottingham
Not sure I follow. ctx_enter is called relatively late, in httpProcessReplyHeader and destroy_MemObject; I'd think for this case we need to have a request id associated quite early, probably around parseHttpRequest. Also, AFAICT Ctx_Descrs and Ctx_Current_Level isn't really a reliable

Re: Associating accesses with cache.log entries

2009-02-24 Thread Henrik Nordstrom
ons 2009-02-25 klockan 12:10 +1100 skrev Mark Nottingham: What am I missing? The most straightforward way that I can see to do this is to add an identifier to clientHttpRequest and pass that to debug where available... That is what ctx_enter is about... There is not a single location