Re: multiple store-dir issues
2009/7/20 Henrik Nordstrom : >> I've fixed a potentially risky situation in Lusca relating to the >> initialisation of the storeIOState cbdata type. Each storedir has a >> different idea of how the allocation should be free()'ed. > > Risky in what sense? Ah. I just re-re-re-read the code again and I now understand what is going on. There are multiple definitions of "storeIOState cbdata" being allocated instead of one. The definitions are local to each module. Ok. Sorry for the noise. I'll commit a fix to COSS for the initialisation issue someone reported during reconfigure. Adrian
Re: Bug for Today 2662
lör 2009-07-18 klockan 20:02 +1000 skrev Robert Collins: > So the patch from gentoo - s/CXX_HOST/CXX_FOR_BUILD/ - and its nearly > right. The only problem is determining the build machine cxx. sadly > autoconf and automake don't have good built in foo for this (at least > according to their manuals). So I'd do this > http://archives.postgresql.org/pgsql-hackers/2005-05/msg01520.php autotools documentation suggest a slight extension to this, setting the variable to some hardcoded value (i.e. cc or gcc) if cross-compilation is detected as $CC is then set to the cross-compiler and not very usable. Regards Henrik
Re: multiple store-dir issues
sön 2009-07-19 klockan 16:06 +0800 skrev Adrian Chadd: > I've fixed a potentially risky situation in Lusca relating to the > initialisation of the storeIOState cbdata type. Each storedir has a > different idea of how the allocation should be free()'ed. Risky in what sense? All your patch does is layering yet another free callback ontop of the cbdata free callback which was already fs specific. How does that improve things or make them less risky? Regards Henrik
multiple store-dir issues
G'day, I've fixed a potentially risky situation in Lusca relating to the initialisation of the storeIOState cbdata type. Each storedir has a different idea of how the allocation should be free()'ed. The relevant commit in Lusca is r14208 - http://code.google.com/p/lusca-cache/source/detail?r=14208 . I'd like this approach to be included in Squid-2.HEAD and backported to Squid-2.7 / Squid-2.6. Thanks, adrian
