Re: [PATCH v2] Do not release entries that may be kept in local memory cache.

2012-07-06 Thread Dmitry Kurochkin
Hi Amos. Amos Jeffries squ...@treenet.co.nz writes: On 6/07/2012 6:29 a.m., Alex Rousskov wrote: On 07/05/2012 11:38 AM, Dmitry Kurochkin wrote: Alex Rousskov writes: I suggest adding StoreController::keepInLocalMemory(e) that will correctly check whether memory caching is enabled at all

[RFC] Drop --enable-ntlm-fail-open

2012-07-06 Thread Amos Jeffries
While building the helper changes it has become clear that the --enable-ntlm-fail-open feature has been half missing for quite some time. The SMB helper sends the LD code back to Squid when the directive is compiled in, but there is no Squid code handling such responses, back as far as squid-2.

Re: [RFC] Drop --enable-ntlm-fail-open

2012-07-06 Thread Kinkie
On Fri, Jul 6, 2012 at 2:53 PM, Amos Jeffries squ...@treenet.co.nz wrote: While building the helper changes it has become clear that the --enable-ntlm-fail-open feature has been half missing for quite some time. The SMB helper sends the LD code back to Squid when the directive is compiled in,

Re: [PATCH v2] Do not release entries that may be kept in local memory cache.

2012-07-06 Thread Alex Rousskov
On 07/05/2012 09:02 PM, Amos Jeffries wrote: It sounds like another analysis of the places calling trimMemory() is needed. StoreEntry::trimMemory() is only called from StoreEntry::swapOut(), before we are starting to swap data out (or skipping swap because the entry is not swappable). Ideally,

Re: [PATCH] Add request_header_add option and [request|reply]_header_* manglers fixes

2012-07-06 Thread Tsantilas Christos
On 07/01/2012 02:25 PM, Amos Jeffries wrote: Thank you. In most places the problem is that AccessLogEntry is the closest thing we have to a XactionData object for the whole HTTP transaction. (I still have patches waiting around to polish up and submit for audit creating that master transaction

Re: [PATCH] Add request_header_add option and [request|reply]_header_* manglers fixes

2012-07-06 Thread Alex Rousskov
On 07/06/2012 08:41 AM, Tsantilas Christos wrote: On 07/01/2012 02:25 PM, Amos Jeffries wrote: Thank you. In most places the problem is that AccessLogEntry is the closest thing we have to a XactionData object for the whole HTTP transaction. (I still have patches waiting around to polish up and

Re: [PATCH] Add request_header_add option and [request|reply]_header_* manglers fixes

2012-07-06 Thread Tsantilas Christos
On 07/06/2012 05:55 PM, Alex Rousskov wrote: On 07/06/2012 08:41 AM, Tsantilas Christos wrote: On 07/01/2012 02:25 PM, Amos Jeffries wrote: Thank you. In most places the problem is that AccessLogEntry is the closest thing we have to a XactionData object for the whole HTTP transaction. (I

Re: Generic helper I/O format

2012-07-06 Thread Henrik Nordström
tor 2012-07-05 klockan 16:00 +1200 skrev Amos Jeffries: The blob only exists in this discussion for two reasons; the old helpers backward compatibility requires it, and you wanted to discuss a body field for the responses. Even not understanding properly the specifics of why you wanted to

Re: Generic helper I/O format

2012-07-06 Thread Amos Jeffries
On 5/07/2012 4:16 p.m., Robert Collins wrote: On Thu, Jul 5, 2012 at 4:00 PM, Amos Jeffries wrote: Why do we need backwards compat in the new protocol? As an alternative, consider setting a protocol= option on the helpers, making the default our latest-and-greatest,a nd folk running

Re: [PATCH v2] Do not release entries that may be kept in local memory cache.

2012-07-06 Thread Alex Rousskov
On 07/06/2012 07:11 PM, Amos Jeffries wrote: On 7/07/2012 2:36 a.m., Alex Rousskov wrote: On 07/05/2012 09:02 PM, Amos Jeffries wrote: It sounds like another analysis of the places calling trimMemory() is needed. StoreEntry::trimMemory() is only called from StoreEntry::swapOut(), before we