Re: [RFC] squid-3.6 unit tests

2014-08-24 Thread Amos Jeffries
On 24/08/2014 12:01 p.m., Amos Jeffries wrote:
 On 24/08/2014 3:59 a.m., Alex Rousskov wrote:

 If the proposed changes take a few months to implement, then yes, I
 agree, we should not wait. If it is a matter of a week or two, I suggest
 doing it now. This is your call though.

 
 It should be a relatively quick job. I will give it a shot while waiting
 on boilerplate.
 

Spoke too soon. We will have to sort out the automake subdir-objects
issues first.

Amos



Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-9.1-clang #638

2014-08-24 Thread noc
See 
http://build.squid-cache.org/job/3.HEAD-amd64-FreeBSD-9.1-clang/638/changes

Changes:

[Amos Jeffries] Cleanup: remove SQUID_NO_STRING_BUFFER_PROTECT and 
SQUID_UNIT_TEST macros

These macros were used solely to prevent cppunit and operating system
includes from generating build errors and warnings via Squid protection
from unsafe use of sprintf, strdup and other allocator and string
functions.

The protection against these functions has long ago been move to
source-maintenance script instead of runtime checking. Making these
macros obsolete.

--
[...truncated 4249 lines...]
libtool: compile:  ccache clang++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I/usr/local/include 
-I/usr/include -I/usr/include -I../../../libltdl -Werror -Qunused-arguments 
-D_REENTRANT -g -O2 -I/usr/local/include -MT Iterator.lo -MD -MP -MF 
.deps/Iterator.Tpo -c ../../../src/adaptation/Iterator.cc  -fPIC -DPIC -o 
.libs/Iterator.o
libtool: compile:  ccache clang++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I/usr/local/include 
-I/usr/include -I/usr/include -I../../../libltdl -Werror -Qunused-arguments 
-D_REENTRANT -g -O2 -I/usr/local/include -MT Iterator.lo -MD -MP -MF 
.deps/Iterator.Tpo -c ../../../src/adaptation/Iterator.cc -o Iterator.o 
/dev/null 21
mv -f .deps/Iterator.Tpo .deps/Iterator.Plo
/bin/sh ../../libtool --tag=CXX--mode=compile ccache clang++ 
-DHAVE_CONFIG_H-I../../.. -I../../../include  -I../../../lib -I../../../src 
 -I../../include -I/usr/local/include -I/usr/include  -I/usr/include  
-I../../../libltdl  -Werror -Qunused-arguments  -D_REENTRANT -g -O2 
-I/usr/local/include -MT Message.lo -MD -MP -MF .deps/Message.Tpo -c -o 
Message.lo ../../../src/adaptation/Message.cc
libtool: compile:  ccache clang++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I/usr/local/include 
-I/usr/include -I/usr/include -I../../../libltdl -Werror -Qunused-arguments 
-D_REENTRANT -g -O2 -I/usr/local/include -MT Message.lo -MD -MP -MF 
.deps/Message.Tpo -c ../../../src/adaptation/Message.cc  -fPIC -DPIC -o 
.libs/Message.o
libtool: compile:  ccache clang++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I/usr/local/include 
-I/usr/include -I/usr/include -I../../../libltdl -Werror -Qunused-arguments 
-D_REENTRANT -g -O2 -I/usr/local/include -MT Message.lo -MD -MP -MF 
.deps/Message.Tpo -c ../../../src/adaptation/Message.cc -o Message.o /dev/null 
21
mv -f .deps/Message.Tpo .deps/Message.Plo
/bin/sh ../../libtool --tag=CXX--mode=compile ccache clang++ 
-DHAVE_CONFIG_H-I../../.. -I../../../include  -I../../../lib -I../../../src 
 -I../../include -I/usr/local/include -I/usr/include  -I/usr/include  
-I../../../libltdl  -Werror -Qunused-arguments  -D_REENTRANT -g -O2 
-I/usr/local/include -MT Service.lo -MD -MP -MF .deps/Service.Tpo -c -o 
Service.lo ../../../src/adaptation/Service.cc
libtool: compile:  ccache clang++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I/usr/local/include 
-I/usr/include -I/usr/include -I../../../libltdl -Werror -Qunused-arguments 
-D_REENTRANT -g -O2 -I/usr/local/include -MT Service.lo -MD -MP -MF 
.deps/Service.Tpo -c ../../../src/adaptation/Service.cc  -fPIC -DPIC -o 
.libs/Service.o
libtool: compile:  ccache clang++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I/usr/local/include 
-I/usr/include -I/usr/include -I../../../libltdl -Werror -Qunused-arguments 
-D_REENTRANT -g -O2 -I/usr/local/include -MT Service.lo -MD -MP -MF 
.deps/Service.Tpo -c ../../../src/adaptation/Service.cc -o Service.o /dev/null 
21
mv -f .deps/Service.Tpo .deps/Service.Plo
/bin/sh ../../libtool --tag=CXX--mode=compile ccache clang++ 
-DHAVE_CONFIG_H-I../../.. -I../../../include  -I../../../lib -I../../../src 
 -I../../include -I/usr/local/include -I/usr/include  -I/usr/include  
-I../../../libltdl  -Werror -Qunused-arguments  -D_REENTRANT -g -O2 
-I/usr/local/include -MT ServiceConfig.lo -MD -MP -MF .deps/ServiceConfig.Tpo 
-c -o ServiceConfig.lo ../../../src/adaptation/ServiceConfig.cc
libtool: compile:  ccache clang++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I/usr/local/include 
-I/usr/include -I/usr/include -I../../../libltdl -Werror -Qunused-arguments 
-D_REENTRANT -g -O2 -I/usr/local/include -MT ServiceConfig.lo -MD -MP -MF 
.deps/ServiceConfig.Tpo -c ../../../src/adaptation/ServiceConfig.cc  -fPIC 
-DPIC -o .libs/ServiceConfig.o
libtool: compile:  ccache clang++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I/usr/local/include 
-I/usr/include -I/usr/include -I../../../libltdl -Werror -Qunused-arguments 
-D_REENTRANT -g -O2 -I/usr/local/include -MT ServiceConfig.lo -MD -MP -MF 

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-9.1 #740

2014-08-24 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-FreeBSD-9.1/740/changes

Changes:

[Amos Jeffries] Cleanup: remove SQUID_NO_STRING_BUFFER_PROTECT and 
SQUID_UNIT_TEST macros

These macros were used solely to prevent cppunit and operating system
includes from generating build errors and warnings via Squid protection
from unsafe use of sprintf, strdup and other allocator and string
functions.

The protection against these functions has long ago been move to
source-maintenance script instead of runtime checking. Making these
macros obsolete.

--
[...truncated 4188 lines...]
libtool: compile:  /usr/local/bin/ccache g++ -DHAVE_CONFIG_H -I../../.. 
-I../../../include -I../../../lib -I../../../src -I../../include 
-I/usr/local/include -I/usr/include -I/usr/include -I../../../libltdl -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Wshadow -Werror -pipe -D_REENTRANT 
-g -O2 -I/usr/local/include -MT DynamicGroupCfg.lo -MD -MP -MF 
.deps/DynamicGroupCfg.Tpo -c ../../../src/adaptation/DynamicGroupCfg.cc -o 
DynamicGroupCfg.o /dev/null 21
mv -f .deps/DynamicGroupCfg.Tpo .deps/DynamicGroupCfg.Plo
/bin/sh ../../libtool --tag=CXX--mode=compile /usr/local/bin/ccache g++ 
-DHAVE_CONFIG_H-I../../.. -I../../../include  -I../../../lib -I../../../src 
 -I../../include -I/usr/local/include -I/usr/include  -I/usr/include  
-I../../../libltdl  -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Wshadow 
-Werror -pipe -D_REENTRANT -g -O2 -I/usr/local/include -MT Elements.lo -MD -MP 
-MF .deps/Elements.Tpo -c -o Elements.lo ../../../src/adaptation/Elements.cc
libtool: compile:  /usr/local/bin/ccache g++ -DHAVE_CONFIG_H -I../../.. 
-I../../../include -I../../../lib -I../../../src -I../../include 
-I/usr/local/include -I/usr/include -I/usr/include -I../../../libltdl -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Wshadow -Werror -pipe -D_REENTRANT 
-g -O2 -I/usr/local/include -MT Elements.lo -MD -MP -MF .deps/Elements.Tpo -c 
../../../src/adaptation/Elements.cc  -fPIC -DPIC -o .libs/Elements.o
libtool: compile:  /usr/local/bin/ccache g++ -DHAVE_CONFIG_H -I../../.. 
-I../../../include -I../../../lib -I../../../src -I../../include 
-I/usr/local/include -I/usr/include -I/usr/include -I../../../libltdl -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Wshadow -Werror -pipe -D_REENTRANT 
-g -O2 -I/usr/local/include -MT Elements.lo -MD -MP -MF .deps/Elements.Tpo -c 
../../../src/adaptation/Elements.cc -o Elements.o /dev/null 21
mv -f .deps/Elements.Tpo .deps/Elements.Plo
/bin/sh ../../libtool --tag=CXX--mode=compile /usr/local/bin/ccache g++ 
-DHAVE_CONFIG_H-I../../.. -I../../../include  -I../../../lib -I../../../src 
 -I../../include -I/usr/local/include -I/usr/include  -I/usr/include  
-I../../../libltdl  -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Wshadow 
-Werror -pipe -D_REENTRANT -g -O2 -I/usr/local/include -MT Initiate.lo -MD -MP 
-MF .deps/Initiate.Tpo -c -o Initiate.lo ../../../src/adaptation/Initiate.cc
libtool: compile:  /usr/local/bin/ccache g++ -DHAVE_CONFIG_H -I../../.. 
-I../../../include -I../../../lib -I../../../src -I../../include 
-I/usr/local/include -I/usr/include -I/usr/include -I../../../libltdl -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Wshadow -Werror -pipe -D_REENTRANT 
-g -O2 -I/usr/local/include -MT Initiate.lo -MD -MP -MF .deps/Initiate.Tpo -c 
../../../src/adaptation/Initiate.cc  -fPIC -DPIC -o .libs/Initiate.o
libtool: compile:  /usr/local/bin/ccache g++ -DHAVE_CONFIG_H -I../../.. 
-I../../../include -I../../../lib -I../../../src -I../../include 
-I/usr/local/include -I/usr/include -I/usr/include -I../../../libltdl -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Wshadow -Werror -pipe -D_REENTRANT 
-g -O2 -I/usr/local/include -MT Initiate.lo -MD -MP -MF .deps/Initiate.Tpo -c 
../../../src/adaptation/Initiate.cc -o Initiate.o /dev/null 21
mv -f .deps/Initiate.Tpo .deps/Initiate.Plo
/bin/sh ../../libtool --tag=CXX--mode=compile /usr/local/bin/ccache g++ 
-DHAVE_CONFIG_H-I../../.. -I../../../include  -I../../../lib -I../../../src 
 -I../../include -I/usr/local/include -I/usr/include  -I/usr/include  
-I../../../libltdl  -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Wshadow 
-Werror -pipe -D_REENTRANT -g -O2 -I/usr/local/include -MT Initiator.lo -MD -MP 
-MF .deps/Initiator.Tpo -c -o Initiator.lo ../../../src/adaptation/Initiator.cc
libtool: compile:  /usr/local/bin/ccache g++ -DHAVE_CONFIG_H -I../../.. 
-I../../../include -I../../../lib -I../../../src -I../../include 
-I/usr/local/include -I/usr/include -I/usr/include -I../../../libltdl -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Wshadow -Werror -pipe -D_REENTRANT 
-g -O2 -I/usr/local/include -MT Initiator.lo -MD -MP -MF .deps/Initiator.Tpo -c 
../../../src/adaptation/Initiator.cc  -fPIC -DPIC -o .libs/Initiator.o
libtool: compile:  /usr/local/bin/ccache g++ -DHAVE_CONFIG_H -I../../.. 
-I../../../include -I../../../lib -I../../../src -I../../include 

Build failed in Jenkins: 3.HEAD-amd64-centos-7-clang #11

2014-08-24 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/11/changes

Changes:

[Amos Jeffries] Cleanup: remove SQUID_NO_STRING_BUFFER_PROTECT and 
SQUID_UNIT_TEST macros

These macros were used solely to prevent cppunit and operating system
includes from generating build errors and warnings via Squid protection
from unsafe use of sprintf, strdup and other allocator and string
functions.

The protection against these functions has long ago been move to
source-maintenance script instead of runtime checking. Making these
macros obsolete.

--
[...truncated 11175 lines...]
make[3]: Leaving directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src/ident'
Making uninstall in log
make[3]: Entering directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src/log'
make[3]: Nothing to be done for `uninstall'.
make[3]: Leaving directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src/log'
Making uninstall in ipc
make[3]: Entering directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src/ipc'
make[3]: Nothing to be done for `uninstall'.
make[3]: Leaving directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src/ipc'
Making uninstall in mgr
make[3]: Entering directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src/mgr'
make[3]: Nothing to be done for `uninstall'.
make[3]: Leaving directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src/mgr'
Making uninstall in snmp
make[3]: Entering directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src/snmp'
make[3]: Nothing to be done for `uninstall'.
make[3]: Leaving directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src/snmp'
Making uninstall in adaptation
make[3]: Entering directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src/adaptation'
Making uninstall in icap
make[4]: Entering directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src/adaptation/icap'
make[4]: Nothing to be done for `uninstall'.
make[4]: Leaving directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src/adaptation/icap'
make[4]: Entering directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src/adaptation'
make[4]: Nothing to be done for `uninstall-am'.
make[4]: Leaving directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src/adaptation'
make[3]: Leaving directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src/adaptation'
make[3]: Entering directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src'
 ( cd 
'http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_inst/libexec'
  rm -f diskd unlinkd )
 /usr/bin/rm -f -f 
http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_inst/etc/mime.conf
 /usr/bin/rm -f -f 
http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_inst/etc/squid.conf
 ( cd 
'http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_inst/share'
  rm -f mib.txt )
 ( cd 
'http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_inst/share/man/man8'
  rm -f squid.8 )
 ( cd 
'http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_inst/sbin'
  rm -f squid )
 ( cd 
'http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_inst/etc'
  rm -f squid.conf.default squid.conf.documented mime.conf.default )
make[3]: Leaving directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src'
make[2]: Leaving directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/src'
Making uninstall in tools
make[2]: Entering directory 
`http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/ws/btlayer-00-default/squid-3.HEAD-BZR/_build/tools'
Making uninstall in purge
make[3]: Entering directory