Re: problems with the squid-2.5 connection pinning

2006-04-15 Thread Adrian Chadd
On Sat, Apr 15, 2006, Steven Wilton wrote: > I'm planning on deploying this patch out on our servers as soon as I get > the chance. I'll let you know how it goes. Excellent! Let me know how it goes and I'll merge it over. I'll then deploy it on a couple of caches and report back. Adrian

Re: problems with the squid-2.5 connection pinning

2006-04-15 Thread Adrian Chadd
On Sat, Apr 15, 2006, Kinkie wrote: > IIRC they do. They just accept the new challenge and re-auth. Only case > when the user gets an auth-prompt is when a 407 is sent back on an > AUTHENTICATE packet. > But closing the connection is in any case less prone to interpretation > doubts. Could someon

wccp2

2006-04-17 Thread Adrian Chadd
Everyone, I've decided to tidy up the wccp2 code and get it import-ready for squid-2. My aims: * configurable standard and dynamic services * handle multiple routers * stay "sane" during a cache configuration reload I'm basing it on Steven Wiltons code in our monotone repository (http://www.cach

Re: wccp2

2006-04-17 Thread Adrian Chadd
On Mon, Apr 17, 2006, Adrian Chadd wrote: > So the bits left: > > * finish the dynamic service configuration options > * spend some time thinking about what should happen during a cache > configuration reload > * dump the config out properly through cachemgr * dynamic ser

Re: Hi there

2006-04-17 Thread Adrian Chadd
I approved your subscription. Welcome to the fold! adrian On Tue, Apr 18, 2006, Doug Dixon wrote: > Hi all > > I've been a user of Squid for a few years now, and am interested in > devoting some time to Squid-3.0 development, bugfixing and testing. > > I'd be most interested in helping to

wccp2 and squid reload semantics

2006-04-17 Thread Adrian Chadd
Hiya, I've completed the WCCP2 configuration changes. Here's an example setup from the cachemgr config output: wccp2_router 192.168.2.2:2048 wccp2_version 4 wccp2_forwarding_method 1 wccp2_return_method 1 wccp2_service dynamic 80 wccp2_service standard 0 wccp2_service_info 80 priority=240 flags=s

Re: wccp2 and squid reload semantics

2006-04-17 Thread Adrian Chadd
Hm, reading the IETF draft again does show a "shutdown" command which we should probably send if we've removed a service/router. adrian On Tue, Apr 18, 2006, Henrik Nordstrom wrote: > tis 2006-04-18 klockan 10:49 +0800 skrev Adrian Chadd: > > > What should the cac

Re: wccp2 and squid reload semantics

2006-04-17 Thread Adrian Chadd
On Tue, Apr 18, 2006, Henrik Nordstrom wrote: > Not critical on reconfigure, as we still most likely still accept > redirected traffic and the router will automatically take us offline > after a short while. > > What is more important is to send the shutdown event when Squid is > actually shut do

Re: wccp2

2006-04-17 Thread Adrian Chadd
On Mon, Apr 17, 2006, Adrian Chadd wrote: > > * finish the dynamic service configuration options Done. > > * spend some time thinking about what should happen during a cache > > configuration reload Steven already did this. > > * dump the config out properly thro

Re: wccp2

2006-04-18 Thread Adrian Chadd
On Tue, Apr 18, 2006, Henrik Nordstrom wrote: > One more task for the TODO: > > Port to Squid-3. To begin with it shouldn't be much more than making it > compile by a C++ compiler. It shouldn't be that hard; the only remotely evil bit is the parser. I'll wait for it to be stable before I port i

wccpv2 md5 update

2006-04-21 Thread Adrian Chadd
Hiya, My WCCPv2 MD5 authentication work seems to work fine for me. I think all the configuration sugar needed to define WCCPv2 cache services is complete. Here's an example: wccp2_router 192.168.2.1:2048 wccp2_version 4 wccp2_forwarding_method 1 wccp2_return_method 1 wccp2_service standard 0 pa

Re: squid-3 - cleanup of select_* stuff.

2006-04-22 Thread Adrian Chadd
On Sat, Apr 22, 2006, Robert Collins wrote: > Meta comment on this after chatting with adrian - I dont think this will > itself make the IO stuff beautiful. But it should allow writing some > test helper routines so that anything I find time to fix has a test for > it that ensures it stays fixed.

Re: next weekend...

2006-04-25 Thread Adrian Chadd
its on macosx, so it should appear in BSD. On Tue, Apr 25, 2006, Robert Collins wrote: > So, I did some more today, courtesy of ANZAC day. Hopefully next weekend > I'll get another chance to cut some code. I'm thinking of changing > strtok -> strtok_r in the parser. > > How portable is strtok_r

COSS questions

2006-05-03 Thread Adrian Chadd
Hiya, Just a warning: This work has been done on Squid-2.5 - I've checked the COSS code in Squid-3 and as far as I can tell nothing to fix this has been checked in. I'd love to be proved wrong though. :) I've noticed over the last few years that the COSS code, although fast, is a tad bit unstabl

Re: reply body modification

2006-05-06 Thread Adrian Chadd
Could you share the patch? adrian On Sat, May 06, 2006, Michael Ulbrich wrote: > Hi all, > > I'm running an experimental version of squid-2.5.STABLE12 with patches > that allow for modifiying the client reply body. Patches have been > applied mostly to client_side.c and especially clientSend

Re: [VOTE] Squid-3.0.PRE4 release criteria

2006-05-06 Thread Adrian Chadd
I agree too. I think part of the reason behind squid-3 falling 'behind' has been all the cute stuff being done to it rather than concentrating on getting something stable. Get something stable, ship it out the door, then concentrate on more code base tidying. Adrian On Sat, May 06, 2006, Guido

[EMAIL PROTECTED]: Re: [squid-users] acl and cache]

2006-05-12 Thread Adrian Chadd
Is this something outstanding that should be fixed in squid-2.5/squid-3? I'll merge in the squid-2.5 changes into my local branch and let everyone know if there are any issues. Adrian - Forwarded message from Henrik Nordstrom <[EMAIL PROTECTED]> - From: Henrik Nordstrom <[EMAIL PROTECT

COSS work update

2006-05-12 Thread Adrian Chadd
Hi everyone, I've made progress with my COSS work: * COSS now seems to work fine with 64-bit file offsets; I'm doing all of my testing with 10 gigabyte stripes and I'll test it with larger once the code is stable * I've fixed the object reading race condition: this needed me to flesh out t

aufs write doesn't lseek

2006-05-14 Thread Adrian Chadd
Hiya, I just noticed that the aufs squidaio_do_write() doesn't call lseek() before write(). This means that the offset value when aioWrite() is called isn't paid attention to. Adrian

Re: aufs write doesn't lseek

2006-05-15 Thread Adrian Chadd
On Mon, May 15, 2006, Henrik Nordstrom wrote: > m??n 2006-05-15 klockan 12:54 +0800 skrev Adrian Chadd: > > > I just noticed that the aufs squidaio_do_write() doesn't call lseek() before > > write(). This means that the offset value when aioWrite() is called isn't &g

Re: aufs write doesn't lseek

2006-05-15 Thread Adrian Chadd
On Mon, May 15, 2006, Henrik Nordstrom wrote: > m??n 2006-05-15 klockan 18:05 +0800 skrev Adrian Chadd: > > > Its a shame I can't queue multiple read()s and write()s to the same FD; > > threads > > don't have a 'local' seek pointer to an FD as far

Re: aufs write doesn't lseek

2006-05-15 Thread Adrian Chadd
On Mon, May 15, 2006, Henrik Nordstrom wrote: > Doubtful. The infrastructure required for native pread/pwrite support is > just a small subset of what is required for POSIX AIO.. (ability to > schedule absolute I/O without relying on the file pointer). *nod* > But lets not worry about that. If

Re: aufs write doesn't lseek

2006-05-15 Thread Adrian Chadd
like aio/sfs :) adrian On Mon, May 15, 2006, Henrik Nordstrom wrote: > m??n 2006-05-15 klockan 19:23 +0800 skrev Adrian Chadd: > > > Yeah, there's not much I can do in that case. Unless they have a > > good (read: good for lots of queued IO on a single disk FD) imp

Re: 2.6 beginning to take shape

2006-05-15 Thread Adrian Chadd
Can you hang off merging the epoll+ssl stuff for a few days? I've got some improvements to the epoll code which I'd like to merge in soon. What I'll do is merge in the squid-2.6 tree into my monotone branch and fix dependencies; which should almost make the head branch of my monotone repository loo

Re: NTLM forwarding in 2.6 ?

2006-05-16 Thread Adrian Chadd
Are you referring to connection pinning so NTLM authentication works through a proxy server? On Tue, May 16, 2006, Baumgaertel, Oliver wrote: > > Hi. > > Are there any plans to add NTLM forwarding to the Stable 2.6 release? > > I ask because we will need that in the coming months and I'd like t

Re: aufs write doesn't lseek

2006-05-16 Thread Adrian Chadd
On Tue, May 16, 2006, Kinkie wrote: > > it is quite trivial to emulate, thanks to dup() creating a new file > > pointer.. > > > > dup > > lseek > > read/write > > close > > Would it be that hard to just use multiple FDs to the same storage file > and then leave the OS to schedule the I/O

Re: aufs write doesn't lseek

2006-05-16 Thread Adrian Chadd
On Tue, May 16, 2006, Kinkie wrote: > Would it be that hard to just use multiple FDs to the same storage file > and then leave the OS to schedule the I/O? Ah! I was trying to minimise the amount of hackery to AUFS -and- minimise writing an IO scheduler. If I had multiple FDs then I have a proble

COSS update: rebuilds from dirty store

2006-05-16 Thread Adrian Chadd
Hiya, I've removed the COSS-rebuild-from-log code as it was broken/incomplete and have implemented a somewhat working COSS-rebuild-from-disk code. The rebuild happens asyncronously using AUFS ops or POSIX AIO ops. The basics are at http://www.squid-cache.org/~adrian/. I've put a snapshot tarball

Re: NTLM forwarding in 2.6 ?

2006-05-16 Thread Adrian Chadd
I'm still not what sure what you mean; do you mean clients will speak NTLM to the intranet server but have squid configured as a web proxy? Adrian On Tue, May 16, 2006, Baumgaertel, Oliver wrote: > > > We have several layers of Proxies: > > User -> Region -> Region -> inner farm -|Firewall|-

proposed aufs changes

2006-05-18 Thread Adrian Chadd
Hi everyone, I'd like to propose using pread() and pwrite() in the AUFS AIO read/write code. This allows multiple concurrent readers/writers to be accessing the same filedescriptor which enables COSS to use AIO. Does anyone have a problem with this? Can it be changed to just use it, or should I t

Re: proposed aufs changes

2006-05-18 Thread Adrian Chadd
On Thu, May 18, 2006, Adrian Chadd wrote: > Hi everyone, > > I'd like to propose using pread() and pwrite() in the AUFS AIO > read/write code. This allows multiple concurrent readers/writers > to be accessing the same filedescriptor which enables COSS > to use AIO. > &g

Re: proposed aufs changes

2006-05-18 Thread Adrian Chadd
On Thu, May 18, 2006, Henrik Nordstrom wrote: > tor 2006-05-18 klockan 15:16 +0800 skrev Adrian Chadd: > > > Does anyone have a problem with this? Can it be changed to just > > use it, or should I try to make it a configure/compiletime option? > > Just use it. They

Change to store swapmeta: addition of a new type

2006-05-18 Thread Adrian Chadd
Part of my COSS rewrite required a little 'help' from the store system to hand over a little more metadata. This metadata is then used during the COSS store rebuild. I've added a new metadata type which records the object size if known. Since its always known for COSS stores it means the object si

Re: COSS in squid-2.6

2006-05-20 Thread Adrian Chadd
On Sat, May 20, 2006, Adrian Chadd wrote: > I've got COSS ready for Squid-2.6; the diff is attached. > It includes the changes needed to the swapmeta information. > Please comment on it; I'd like to commit this relatively > soon and then get some documentation written before

Re: Change to store swapmeta: addition of a new type

2006-05-20 Thread Adrian Chadd
On Sat, May 20, 2006, Henrik Nordstrom wrote: > fre 2006-05-19 klockan 08:32 +0800 skrev Adrian Chadd: > > > I've added a new metadata type which records the object size if known. > > Since its always known for COSS stores it means the object size is > > written in

Errorpage and local time?

2006-05-21 Thread Adrian Chadd
Hiya, Someone popped up on squid-dev asking how to change the errorpage time from "GMT" to local time. Is there a run-time option lurking somewhere to set that? If not, does anyone mind if I add a runtime option to allow people to set the errorpage time (and possibly allow both GMT and local to be

Re: Squid-2.6 update

2006-05-22 Thread Adrian Chadd
I'll add kqueue() support once squid-2.6 hits PRE and has had some testing. It ain't difficult to add; I just want some testing to be done on the current squid-2.6+epoll code before I rush in and change things to make kqueue() and Solaris /dev/poll easier to implement. On Mon, May 22, 2006, Henri

squid-2.6 build broken

2006-05-23 Thread Adrian Chadd
Hiya, I've just updated to the latest squid-2.6 source and have found the code isn't building. Any ideas? [EMAIL PROTECTED]:~/work/squid/squid-2.6$ gcc -v Using built-in specs. Target: i486-linux-gnu Configured with: ../src/configure -v --enable-languages=c,c++,java,f95,objc,ada,treelang --prefi

commloops revisited

2006-05-24 Thread Adrian Chadd
I'd like to break the comm code out into per-commtype files; much like squid-3. Here's my first cut. They compile and run; I haven't done much testing on them. There's plenty more tidying up which can be done after this is in - mostly involving tidying up commSetSelect() and making the commDeferFD

Re: commloops revisited

2006-05-24 Thread Adrian Chadd
On Wed, May 24, 2006, Henrik Nordstrom wrote: > > Here's my first cut. They compile and run; I haven't done much > > testing on them. There's plenty more tidying up which can be done > > after this is in - mostly involving tidying up commSetSelect() and > > making the commDeferFD/commResumeFD call

Re: commloops revisited

2006-05-24 Thread Adrian Chadd
> > Before commit this needs to be refined it a bit first. Do you have a > > branch created for this in your monotone or devel.squid-cache? > > Nope; its just sitting in a checked out tree. I can stuff it in a > branch on devel if needs be. I'll create a commloops-2.6 branch today. I think this s

Re: commloops revisited

2006-05-24 Thread Adrian Chadd
[snip] > But it's a bit too much rework of the internals to match the 2.6 > release. This not only touches the comm loop, but pretty much every > single protocol module. > > This should be done in Squid-3. In Squid-2 the goal is just to make it > work, not be pretty. I'm going to leave it all u

Re: 2.6.PRE1 is out the door

2006-05-29 Thread Adrian Chadd
On Tue, May 30, 2006, Henrik Nordstrom wrote: > - Some benchmarking is needed to see if comm_poll is really worth to > keep, or if comm_select is actually better. The current comm_poll > implementation looks extremely inefficient (same as it always been in > 2.x).. Poll should be better - it'll

Re: 2.6.PRE1 is out the door

2006-05-30 Thread Adrian Chadd
On Mon, May 29, 2006, Jason Titus wrote: > Have you considered using libevent as a way to abstract out the polling > method? Seems like it might make porting easier and give you kqueue as > well... > > http://www.monkey.org/~provos/libevent/ Yup. People keep pointing libevent at me. The main t

Re: Pawel porting kqueue()

2006-06-08 Thread Adrian Chadd
This was bounced to me as moderator and I approved it; things then got confused. From: Pawel Worach <[EMAIL PROTECTED]> Subject: Squid 2.6 has kqueue()! Hi folks, With some great help from Henrik I backported Adrian's kqueue event loop support for squid 2.6. It sits in cvs as of a couple of minu

Re: Join request

2006-06-08 Thread Adrian Chadd
No worries; just send in a subscribe request and I'll approve it. I'm interested in caching Bittorrent files; its something I'm going to take a look after sometime after my exams (and after COSS, and after squid-2.6 is stable..) On Wed, Jun 07, 2006, Osama Saleh wrote: > > Dear Sir, > > My nam

cachemgr.cgi and port scanning

2006-06-10 Thread Adrian Chadd
I'm sure this has popped up before, but: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=133131 An example of someone using cachemgr.cgi to portscan arbitrary hosts. What do you all think about adding in some basic configuration to lock down which port/host the installed cachemgr.cgi is permitt

Re: cachemgr.cgi and port scanning

2006-06-10 Thread Adrian Chadd
Woo, yay for Adrian being behind the times. Cool. Adrian On Sat, Jun 10, 2006, Henrik Nordstrom wrote: > l??r 2006-06-10 klockan 20:32 +0800 skrev Adrian Chadd: > > > An example of someone using cachemgr.cgi to portscan arbitrary hosts. > > What do you all think about ad

Re: Merge some other enh bugs in 2.6 ?

2006-06-15 Thread Adrian Chadd
On Thu, Jun 15, 2006, Guido Serassio wrote: > - #1235: New options to ignore Cache-Control headers when necessary > - #1423: Could use TCP_CORK to optimize cache hits I'd leave these until squid-2.6 has been made stable. (I'll get back into squid coding next week and I'll concentrate on fixing

COSS and Squid-2.6

2006-06-22 Thread Adrian Chadd
Hiya, I'm back and concentrating on COSS fixes in Squid-2.6. I've just fixed a crash-on-rebuild bug; for those of you who are testing Squid-2.6 then please give the latest code a try. Thanks! Adrian

Re: Occasional Zero Sized Reply error with 2.6

2006-06-23 Thread Adrian Chadd
On Fri, Jun 23, 2006, Guido Serassio wrote: > Hi Henrik, > > I'm observing some occasional Zero Sized Reply error using 2.6 on > native Windows. > Reloading the page, it works fine. I'm seeing it in my polygraph testing under 2.6 + COSS. It may be related. Adrian

Re: squid-3 vs 2.6

2006-06-25 Thread Adrian Chadd
On Sun, Jun 25, 2006, Doug Dixon wrote: > We are at the point where we need to stop being general, and start > being very specific, about HOW Squid-3 is "not stable". What are the > measures of stability? How do we prove to each other that Squid-3 is > stable or unstable? IMHO we lost out b

Re: squid-3 vs 2.6

2006-06-26 Thread Adrian Chadd
On Tue, Jun 27, 2006, Henrik Nordstrom wrote: > > > - COSS ng (or whatever to call what Adrian is doing to COSS). > > > Some of > > > this actually fits better in Squid-3 with it's re-factored I/O > > > framework. > > This is already on Adrians schedule. Not sure there need to be a > bugzilla

Re: Open issues for 2.6

2006-06-27 Thread Adrian Chadd
I do keep getting these during polygraph testing: 041.64| Xaction.cc:74: error: 8/10 (c14) premature end of msg body 1151460879.419466# obj: http://:8080/w0e4091fe.60215fc4:0006/t01/_000186bd flags: basic,GET,chb, size: 39200/41790 xact: 0e4091fe.60215fc4:0009b992 [no data to dump] Polygrap

COSS+*UFS rebuild failures in squid-2.6

2006-06-29 Thread Adrian Chadd
There's been some rebuild failures showing up in squid-2.6 when its used with COSS and another store type (eg AUFS). The basic reasoning is this: each storedir (aufs, diskd, ufs, and COSS which I'm to blame for) assumes that if it sees an fresher object during rebuild the older storeentry object i

patch: squid-2.6 rebuilds

2006-07-02 Thread Adrian Chadd
Hiya, Here's my initial patch to make things slightly saner during cachedir rebuilds. Its resulted in a correct-looking rebuild from a cache w/ COSS+AUFS which crashed during rebuild. I haven't contacted the owner of the bugzilla entry to see if this patch fixes his particular problem but I do be

object locality question

2006-07-06 Thread Adrian Chadd
Hi everyone, I'm investigating what I need to do to make the next version of the cyclic FS handle locality. I'm reading a bunch of old papers (circa 1998-2000) on the topic to try and get more of a handle on things; does anyone here have some opinions on how a filestore could take object locality

coss fixes

2006-07-09 Thread Adrian Chadd
I've attached a patch which should fix a couple of the crashes people have reported whilst using COSS. This doesn't fix the "swapin md5 mismatch" errors. Comments please; I'll commit this sometime tomorrow afternoon if no-one raises any problems. Adrian Index: store_dir_coss.c ==

Re: Tproxy patch

2006-07-12 Thread Adrian Chadd
On Wed, Jul 12, 2006, Henrik Nordstrom wrote: > Redefining it like this isn't entirely safe as there may have been type > declarations dependent on in in the included headers. But hopefully > those where included by squid.h before it got redefined... > > Ah, there it is. We should be including sys

logfile writing

2006-07-16 Thread Adrian Chadd
Hiya, I've written some code to push logfile writing into an external process, freeing up the main squid process from the potentially blocking stdio writes. This code isn't ready to be merged into squid-2.6. Its meant more as a prototype. I haven't even reviewed it for 'correctness' besides runni

Re: logfile writing

2006-07-16 Thread Adrian Chadd
On Mon, Jul 17, 2006, Henrik Nordstrom wrote: > Instead of the linked list of separately maintained buffers, have you > considered using MemBuf:s? Nope! I just did this quick hack to mirror stuff I've done in the past under Linux/BSD to try and stuff IPC IO into page-aligned buffers to exploit CO

Re: logfile writing

2006-07-16 Thread Adrian Chadd
On Mon, Jul 17, 2006, Henrik Nordstrom wrote: > m??n 2006-07-17 klockan 09:07 +0800 skrev Adrian Chadd: > > > > You flush any pending buffers first, right? > > > > This patch doesn't do that yet. It wasn't that important as buffered data > > doesn'

Re: [squid-users] 2.6S1 WCCP2 problems

2006-07-17 Thread Adrian Chadd
On Mon, Jul 17, 2006, Shoebottom, Bryan wrote: > Hey, > > It's a 6500 with 12.1(26)E code on it. It works with 2.5 stable code with > the WCCP2 patch applied. If you're not afraid of a little risk, try this: I think these will turn on wccp packet logging: debug ip wccp packet debug ip wccp eve

Re: COSS Crash + WCCP while rebuilding

2006-07-27 Thread Adrian Chadd
On Thu, Jul 27, 2006, Steven Wilton wrote: > I'd like to propose the attached patches for squid. > > The first is a config option for wccp2 to make squid wait until all > cache_dirs have finished rebuilding before squid will register itself with > WCCP. This will allow the rebuild to happen quick

Re: COSS Crash + WCCP while rebuilding

2006-07-27 Thread Adrian Chadd
On Thu, Jul 27, 2006, Steven wrote: > > They make me use Outlook at work :) > > Here I go again. Cool! I'm happy for you to commit the store_swapmeta patch. Adrian

Re: Squid 2.6 STABLE2 + COSS

2006-07-31 Thread Adrian Chadd
On Mon, Jul 31, 2006, Steven Wilton wrote: > I've been doing a fair amount of work on the COSS code in squid 2.6, and > I've been testing it under fairly heavy load, and appear to have sorted out > a majority of the bugs. I think that the code would be useful to include > in squid 2.6STABLE2, b

Re: Squid 2.6 STABLE2 + COSS

2006-07-31 Thread Adrian Chadd
On Mon, Jul 31, 2006, Steven Wilton wrote: > >The code does only touch the coss directory (except for the comments in > >cf.data.pre) if that makes any difference. > > > > Or maybe I should check whether it's been released before posting :) Why? There'll be a squid-2.6stable3 at this rate. :)

Re: Proposed COSS patch

2006-08-01 Thread Adrian Chadd
On Tue, Aug 01, 2006, Steven wrote: > As mentioned yesterday, I've been doing a fair amount of work on COSS over > the past few weeks. Attached is a patch that I've come up with that fixes > a couple of bugs, and adds a couple of configuration options to COSS. Looks fine to me. Its good to see so

Re: Proposed COSS patch

2006-08-02 Thread Adrian Chadd
On Tue, Aug 01, 2006, Steven wrote: > As mentioned yesterday, I've been doing a fair amount of work on COSS over > the past few weeks. Attached is a patch that I've come up with that fixes > a couple of bugs, and adds a couple of configuration options to COSS. .. and they've been committed! Than

Re: Download hanging

2006-08-05 Thread Adrian Chadd
On Sat, Aug 05, 2006, Steven wrote: > I had a problem today where a download for a particular file was hanging > forever after 128k. It looks like the store entry had the release > request flag set, but because all the data had been sent to the client > and the server side was being deferred, there

Re: Download hanging

2006-08-05 Thread Adrian Chadd
On Sat, Aug 05, 2006, Henrik Nordstrom wrote: > Ideally delay pools would kick the I/O going again when the pool have > been filled up, and we could then get rid of the periodic repoll of > deferred connections relying almost exclusively on > storeDeferRead/storeResumeRead signaling to indicate wh

new branch: s26_logfile_daemon

2006-08-07 Thread Adrian Chadd
Hiya, I've created a new branch with my logging daemon framework. Its pretty rough and very vaguely tested. I'd like some feedback on the general direction I'm taking with the aim to get it committed within the next couple of weeks or so. Adrian

logfile daemon stuff

2006-08-08 Thread Adrian Chadd
I've implemented the following in the 26_logfile_daemon branch in sourceforge: * The logging buffer in squid doesn't grow to infinity - its set to a hardcoded limit and will log warnings if this limit is reached. * Rotate now works * Restart/reconfigure now works - the logfile helper is killed

Re: logfile daemon stuff

2006-08-08 Thread Adrian Chadd
On Wed, Aug 09, 2006, Henrik Nordstrom wrote: > One note: I assume you do know that ipcCreate() currently redirects > stderr to cache.log at the time the ipc channel is created. This is why > all helpers is restarted on "squid -k rotate". Ah! I vaguely remember that. > I think it would be a good

Re: CONNECT invalid-request

2006-08-09 Thread Adrian Chadd
On Wed, Aug 09, 2006, Liudas Bak?ys wrote: > Hi, > > I have upgraded squid-2.5.STABLE14 to squid-2.6.STABLE2 recently. > After upgrade I notice that ?CONNECT? method doesn?t work (for > example connections to HTTPS servers). Squid returns ?invalid > request? error page (ERR_INVALID_REQ). I have

comm optimisation

2006-08-11 Thread Adrian Chadd
Hiya, This is a simple hack to attempt to remove the mempoolalloc/free done for each comm_write(). This is against squid-2.6. http://www.creative.net.au/diffs/20060811-comm-1.diff Its dirty and meant as a proof of concept. I noticed that ~8% of the total mempool allocations in some of my profili

Re: comm optimisation

2006-08-12 Thread Adrian Chadd
I've committed the comm optimisation with a few slight modifications. Just for fun, I've put the output of one of the profiling runs (via gprof) on my website. http://www.creative.net.au/diffs/trace.4.txt Its ~400k. Now, I know that the time quantas in gprof can be a bit "wrong" but I believe th

Re: comm optimisation

2006-08-12 Thread Adrian Chadd
On Sat, Aug 12, 2006, Adrian Chadd wrote: > Its ~400k. Now, I know that the time quantas in gprof can be a bit "wrong" > but I believe the call graph and the function call counts are correct. > This is on my Athlon 1800+ XP running 2.6, handling ~230 requests a second. >

Re: 2.6 HEAD doesn't compile

2006-08-12 Thread Adrian Chadd
On Sun, Aug 13, 2006, Henrik Nordstrom wrote: > /home/henrik/SRC/squid/commit-2.6/src/comm.c: In function > 'CommWriteStateCallbackAndFree': > /home/henrik/SRC/squid/commit-2.6/src/comm.c:85: warning: comparison between > pointer and integer > > I assume this is from Adrians comm_write optimizat

Re: 2.6 HEAD doesn't compile

2006-08-12 Thread Adrian Chadd
On Sun, Aug 13, 2006, Adrian Chadd wrote: > On Sun, Aug 13, 2006, Henrik Nordstrom wrote: > > /home/henrik/SRC/squid/commit-2.6/src/comm.c: In function > > 'CommWriteStateCallbackAndFree': > > /home/henrik/SRC/squid/commit-2.6/src/comm.c:85: warning: comparison

Re: Another COSS patch

2006-08-14 Thread Adrian Chadd
On Mon, Aug 14, 2006, Steven wrote: > > Ar there any objections to me committing the attached patch for COSS in > squid 2.6. I've been running this patch for the past week on one of our > caches, and it appears to be working well. Its fine by me. What would be good now is a "configuration guide

Re: Another COSS patch

2006-08-15 Thread Adrian Chadd
On Tue, Aug 15, 2006, Henrik Nordstrom wrote: > On Mon, 2006-08-14 at 17:00 +0800, Adrian Chadd wrote: > > > What would be good now is a "configuration guide" for COSS just so people > > have some idea of how to configure, use, troubleshoot and tune it. > > C

Re: cvs commit: squid/src cf.data.pre

2006-08-15 Thread Adrian Chadd
Henrik's scripts will take the first line as a "summary" when generating the changelogs. It might be a good idea to try writing a one-line summary at the beginning of each commit message. Adrian On Wed, Aug 16, 2006, [EMAIL PROTECTED] wrote: > swilton 2006/08/15 20:33:22 MDT > > Modifi

Re: Another COSS patch

2006-08-15 Thread Adrian Chadd
On Wed, Aug 16, 2006, Steven Wilton wrote: > > > Have you looked at the documentation update Reuben sent? > > > > Yup; then Steven went off and tweaked it all again! > > > > I'm not sure what document you're referring to. Is there another document > that should be updated? Or is the wiki the

small optimisation: client_side.c

2006-08-18 Thread Adrian Chadd
Hiya, My profiling shows that an appreciable chunk of the memory pool allocator is MEM_CLIENT_SOCK_BUF as Squid winds its way through object data 4k at a time. I had a brief look at the code and it seems that the buffers are almost always being used once and exist just for the lifetime of the sto

Re: cvs commit: squid/src Makefile.am access_log.c cache_cf.c cf.data.pre logfile.c protos.h store_log.c structs.h typedefs.h

2006-08-19 Thread Adrian Chadd
> Please, don't commit new changes just after a new STABLE release, but > leave me te time to do the equivalent release of the nt-2.6 Sourgeforge > branch. > > Whene you have done your commit I'was sleeping, and now the 2.6 > repository on Sourgeforge on which is based nt-2.6 is "dirty". I did

Re: Low portability of logfile-daemon support

2006-08-19 Thread Adrian Chadd
On Sat, Aug 19, 2006, Guido Serassio wrote: > Hi Adrian, > > I'm doing my usual build test on 2.6 and I have found a portability problem: > > asprintf(), used in logfile.c, is not available on Irix, Solaris and > Windows, and may be other platforms. > > It's possible to use something else inste

Re: Low portability of logfile-daemon support

2006-08-19 Thread Adrian Chadd
On Sat, Aug 19, 2006, Guido Serassio wrote: > >Perhaps replace it with a memBufPrintf to be consistent with the rest of > >the code? > > Sure, correct. It only uses asprintf to write the control data (rotate and buffering.) It doesn't use asprintf to write the logfile data out. Adrian

Re: 3.0 bugfix-fest saturday 2nd - Sunday 3rd september - #squiddev on irc.freenode.net

2006-08-20 Thread Adrian Chadd
On Sun, Aug 20, 2006, Robert Collins wrote: > On Sunday, I'll be doing the same again, modulo a commitment I already > have in the middle of the day. > > Adrian Chadd will be online with me, from a few hours later. > > I think it would be fantastic if we can do a foll

Re: Another COSS patch

2006-08-21 Thread Adrian Chadd
On Mon, Aug 21, 2006, Steven Wilton wrote: > As promised, I've added a WIKI page in the FAQ section. Nice, thanks! Adrian

Re: EventLoop shutdown procedure..

2006-08-22 Thread Adrian Chadd
On Mon, Aug 21, 2006, Robert Collins wrote: > I'd like to make the shutdown procedure async as well - allowing things > like swap log writing to use calls elsewhere in the codebase that are > async - like the disk engines. Can this wait until squid-3 is released and stable? Pretty please? :)

Re: Faq-O-Matic is broken

2006-08-23 Thread Adrian Chadd
Hiya, Yeah, just kill FoM. I think the Wiki has taken its place. Adrian On Wed, Aug 23, 2006, Kinkie wrote: > Faq-O-Matic as available at http://www.squid-cache.org/~fom/fom.cgi > > I suggest we discontinue it, unless there's something not already > covered in the FAQ. > > Kinkie

Wikimedia having issues

2006-08-23 Thread Adrian Chadd
Hiya, Mark from Wikimedia has popped up and noted that there's been some issues with the Squid-2.6 deployment. Specifically, people are being prompted to download pages rather than display them. It only started after they installed Squid-2.6. The bugtraq entry is: http://bugzilla.wikimedia.org/s

Re: Wikimedia having issues

2006-08-24 Thread Adrian Chadd
On Thu, Aug 24, 2006, Henrik Nordstrom wrote: > tor 2006-08-24 klockan 10:27 +0800 skrev Adrian Chadd: > > > Mark from Wikimedia has popped up and noted that there's been some > > issues with the Squid-2.6 deployment. Specifically, people are > > being prompted

Re: Squid developer & configuration assignments

2006-08-24 Thread Adrian Chadd
On Fri, Aug 25, 2006, Henrik Nordstrom wrote: > From time to time I and a few other developers gets more requests than > we can handle, and I wonder if there is interest in setting up an > internal mailing list where we can ask if there is another squid > developer who can take the assignment. > >

Re: [PATCH] Make URN support an optional component

2006-08-27 Thread Adrian Chadd
I like the intention of this patch but: * I don't think we should be messing around with everything before we've at least -released- Squid-3 (And it pains me to say this, because _I_ want to start taking as much of a knife to the codebase to make it sane as much as you do.) * I think we rea

Re: [PATCH] Make URN support an optional component

2006-08-27 Thread Adrian Chadd
On Sun, Aug 27, 2006, Robert Collins wrote: > I'll hold it in a branch indefinately then. If we get some good traction > this coming weekend - the bug-fixing-fest - I will be much happier about > it sitting in a branch for a month, maybe two, than if we dont. Oh, it'll happen. It'll be useful if

squid 2.6 parser work

2006-08-29 Thread Adrian Chadd
Hiya, I've been doing some work on Squid-2.6 to optimise the parser code. I've been working with Mark Nottingham from Yahoo! who has been running various throughput tests on Squid-2.6. I've been concentrating on the client-side stuff - request parsing, reply parsing/building. There's plenty of ot

Re: squid 2.6 parser work

2006-08-29 Thread Adrian Chadd
On Tue, Aug 29, 2006, Adrian Chadd wrote: > * Hint to memPoolAlloc/memPoolFree that they shouldn't xfree() certain > buffers, > such as the buffers being allocated to strings and stmem buffers. s/xfree()/memset(buf, 0, ..)/ adrian

Re: [squid-users] Profiling patch redo, need help.

2006-08-29 Thread Adrian Chadd
On Mon, Aug 28, 2006, Pranav Desai wrote: > I think I did join, but I never received the acknowledgement mail. > Maybe I will try it again. I've manually added you now. > >You can just include the patch in the body of your email rather than as > >an attachment. Or, if its more than a couple hund

<    3   4   5   6   7   8   9   10   11   12   >