Re: X-Vary-Options patch

2008-06-07 Thread Henrik Nordstrom
On lör, 2008-06-07 at 10:43 +0800, Adrian Chadd wrote: I think some of their stuff was backed out of Squid-2.7 before release. The Vary invalidation patch was backed out from 2.7 as it's incomplete and broke things. But this X-Vary-Options patch never got committed. Thread stops after your

Re: X-Vary-Options patch

2008-06-07 Thread Mark Nottingham
+1 to what H says. I'm definitely interested in this area, but want to think through it a bit more. We can get a certain amount of functionality without any extension; e.g., canonicalising selecting headers to take care of whitespace and case issues, and perhaps even ordering (this doesn't

Re: X-Vary-Options patch

2008-06-06 Thread Mark Nottingham
Squid devs: Did this make its way into 2.7? Tim: AIUI, the following header: X-Vary-Options: Accept-Encoding; list-contains=gzip will bucket the cache for this URI into two entries; those whose Accept-Encoding contains the list value gzip, and those that don't. Is that correct? Also, I'm

Re: X-Vary-Options patch

2008-06-06 Thread Adrian Chadd
I think some of their stuff was backed out of Squid-2.7 before release. What we -should- do is create a wiki page to document all the crazy stuff about Vary: and coordinate things a little better. I'd really like to see more sensible vary handling go into Squid and there certainly seems like

Re: X-Vary-Options patch

2008-02-26 Thread Adrian Chadd
G'day, I'm happy to commit this to Squid-2.HEAD as-is. Can you throw it in a Bugzilla report and spit me the number? Thanks, Adrian On Fri, Feb 08, 2008, Tim Starling wrote: There are two major sources of suboptimal hit rate on Wikipedia which relate to the Vary header: * In

Re: X-Vary-Options patch

2008-02-15 Thread pokeman
can you please send the TAGs what i made change in squid.conf Robert Collins wrote: On Fri, 2008-02-08 at 16:26 +1100, Tim Starling wrote: The added features of the patch are conditional, and are enabled by the configure option --enable-vary-options. Unless there is non-trivial

Re: X-Vary-Options patch

2008-02-11 Thread Robert Collins
On Fri, 2008-02-08 at 16:26 +1100, Tim Starling wrote: The added features of the patch are conditional, and are enabled by the configure option --enable-vary-options. Unless there is non-trivial process required for regular vary headers with this enabled, I don't think it needs to be