Adrian wrote:
> -fd_set slowfds;
> +char slowfds[SQUID_MAXFD];
> -static fd_set delay_no_delay;
> +static int delay_no_delay[SQUID_MAXFD];
Firstly, either decide on an int array or a char array to replace
the current bitmask. On a typical 8k FD cache, that's either
8kb or 32kb rather th
On Sun, 7 Mar 2004, Adrian Chadd wrote:
> -#if !HAVE_POLL
> +#if HAVE_POLL
> +static char global_readfds[SQUID_MAXFD];
> +static char global_writefds[SQUID_MAXFD];
Are these even used in poll?
Have you verified that fd_set is the culpit to your problems by using the
assert given earlier?
Regar
On Thu, Mar 04, 2004, Adrian Chadd wrote:
> I can't leave that in - pinger/unlinkd use an fd_set.
> Gah, I'll have to do a little bit of tidying up to deal with
> the nreadfds and nwritefds in a more efficient fashion.
> Thanks.
Right. Here's what I have. Its a bit evil, but broken fdset manipula
On Thu, Mar 04, 2004, Henrik Nordstrom wrote:
> > > Ok. I must've missed them. Let me go through the codebase and remove
> > > all references to fd_set when you're not actually using select().
> >
> > Ok, the only use I can see is in the slowfds use. The other use of
> > fd_set is in the select()
On Thu, 4 Mar 2004, Adrian Chadd wrote:
> On Thu, Mar 04, 2004, Adrian Chadd wrote:
>
> > > You need to remove far more fd_set references if this is the problem.
> > > There is also seveal delay pool related fd_set usage in comm_poll, and a
> > > few other places I think.
> >
> > Ok. I must'v
On Thu, 4 Mar 2004, Adrian Chadd wrote:
> > More likely the way FD_SETSIZE is extended is broken for your libc
> > headers..
>
> I agree, but its becoming a pain to work around this.
Please verify the assert I sent. If it triggers we at least know this is
the problem.
Which libc are you using?
On Thu, Mar 04, 2004, Adrian Chadd wrote:
> > You need to remove far more fd_set references if this is the problem.
> > There is also seveal delay pool related fd_set usage in comm_poll, and a
> > few other places I think.
>
> Ok. I must've missed them. Let me go through the codebase and remov
On Thu, Mar 04, 2004, Henrik Nordstrom wrote:
> On Wed, 3 Mar 2004, Adrian Chadd wrote:
>
> > I'm still having issues with squid-2.5 and delay pools.
> > The FDSET stuff is _very_ broken when you're using >1024 fds.
>
> More likely the way FD_SETSIZE is exten
On Wed, 3 Mar 2004, Adrian Chadd wrote:
> I'm still having issues with squid-2.5 and delay pools.
> The FDSET stuff is _very_ broken when you're using >1024 fds.
More likely the way FD_SETSIZE is extended is broken for your libc
headers..
You need to remove far more fd_set re
hi,
I'm still having issues with squid-2.5 and delay pools.
The FDSET stuff is _very_ broken when you're using >1024 fds.
Here is a simple patch to 2.5 only which removes the whole
fdset thing.
I'd like to commit this so the delay pools stuff in 2.5
works for >1024 fds with
10 matches
Mail list logo
