Re: logic error in httpHdrRangeSpecParseCreate

2007-09-08 Thread Pierangelo Masarati
Wenzhuo Zhang wrote: Hi, squid developers When reading squid-2.6-STABLE15 source code, I found a logical error in the if statement at src/HttpHdrRange.c line 96: if (!((p = strchr(field, '-')) || (p - field = flen))) { If p is NULL, (p - field) is meaningless. If p is not NULL, the

Re: logic error in httpHdrRangeSpecParseCreate

2007-09-08 Thread Adrian Chadd
On Sat, Sep 08, 2007, Pierangelo Masarati wrote: I'm not a Squid developer, but your diagnosis sounds right. Just in case, I think you should file a bug http://www.squid-cache.org/bugs/ so the fix, if confirmed, can be tracked. You analysed a bug; you're a squid developer now! Adrian

logic error in httpHdrRangeSpecParseCreate

2007-09-07 Thread Wenzhuo Zhang
Hi, squid developers When reading squid-2.6-STABLE15 source code, I found a logical error in the if statement at src/HttpHdrRange.c line 96: if (!((p = strchr(field, '-')) || (p - field = flen))) { If p is NULL, (p - field) is meaningless. If p is not NULL, the latter expression