Re: r13497: Converts the PortCfgPointer to reference counted

2014-07-16 Thread Amos Jeffries
On 16/07/2014 9:31 a.m., Alex Rousskov wrote: On 07/14/2014 11:59 PM, Amos Jeffries wrote: On 15/07/2014 5:02 a.m., Alex Rousskov wrote: On 07/14/2014 03:48 AM, Amos Jeffries wrote: -if (!s.valid()) { +if (!s) { // it is possible the call or accept() was still queued when

Re: r13497: Converts the PortCfgPointer to reference counted

2014-07-15 Thread Amos Jeffries
On 15/07/2014 5:02 a.m., Alex Rousskov wrote: On 07/14/2014 03:48 AM, Amos Jeffries wrote: Converts the PortCfgPointer to reference counted This change should have gone through an audit IMO, but I appreciate having an entire Sunday to react to the will commit shortly notice for a not yet

Re: r13497: Converts the PortCfgPointer to reference counted

2014-07-14 Thread Alex Rousskov
On 07/14/2014 03:48 AM, Amos Jeffries wrote: Converts the PortCfgPointer to reference counted This change should have gone through an audit IMO, but I appreciate having an entire Sunday to react to the will commit shortly notice for a not yet posted patch. -if (!s.valid()) { +if

Re: r13497: Converts the PortCfgPointer to reference counted

2014-07-14 Thread Alex Rousskov
On 07/14/2014 11:02 AM, Alex Rousskov wrote: On 07/14/2014 03:48 AM, Amos Jeffries wrote: -if (!s.valid()) { +if (!s) { // it is possible the call or accept() was still queued when the port was reconfigured debugs(33, 2, HTTP accept failure: port reconfigured.);