Re: [squid-dev] [PATCH] Revalidate without Last-Modified

On 9/09/2016 11:01 p.m., Eduard Bagdasaryan wrote: > Made a couple of fixes: > > * avoid needless updates when a [revalidation] reply lacks Last-Modified > > * compilation errors while running test-builds.sh > > Also attached a port to v3.5. Applied to 4.x as rev.14845. Amos

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

Made a couple of fixes: * avoid needless updates when a [revalidation] reply lacks Last-Modified * compilation errors while running test-builds.sh Also attached a port to v3.5. Eduard. Bug 4471: revalidation doesn't work when expired cached object lacks Last-Modified. The bug was caused by

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

On 08/30/2016 04:35 AM, Eduard Bagdasaryan wrote: > 2016-08-28 1:12 GMT+03:00 Alex Rousskov : >> Not all HTCP clients are Squids, but how does Squid code treat such an >> HTCP TST response? > It seems that Squid does not care whether HTCP response contains LMT

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

2016-08-28 1:12 GMT+03:00 Alex Rousskov : > I worry about the message recipient comparing received > effective LMT with the actual (absent!) LMT of the object they have in > the cache and then deciding that the resource has changed (and their > cached copy is

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

On 08/27/2016 08:33 AM, Amos Jeffries wrote: > If the response Squid would emit to the client proxy would contain a > synthesized Last-Modified header - then the same synthetic value should > be sent in HTCP. I agree with that decision logic. > I think Squid should be emitting a synthetic L-M

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

On 08/27/2016 05:22 AM, Eduard Bagdasaryan wrote: > 2016-08-25 18:52 GMT+03:00 Alex Rousskov > : > >> 3. Sending an HTCP message to another service. >> >> > -hdr.putTime(Http::HdrType::LAST_MODIFIED, e->lastmod); >> > +if (e &&

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

On 27/08/2016 11:22 p.m., Eduard Bagdasaryan wrote: > 2016-08-25 18:52 GMT+03:00 Alex Rousskov: > >> 3. Sending an HTCP message to another service. >> >> > -hdr.putTime(Http::HdrType::LAST_MODIFIED, e->lastmod); >> > +if (e && e->lastModified() > -1) >> > +

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

2016-08-25 18:52 GMT+03:00 Alex Rousskov : > 3. Sending an HTCP message to another service. > > > -hdr.putTime(Http::HdrType::LAST_MODIFIED, e->lastmod); > > +if (e && e->lastModified() > -1) > > +

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

On 26/08/2016 3:52 a.m., Alex Rousskov wrote: > On 08/25/2016 04:04 AM, Eduard Bagdasaryan wrote: > >> Therefore, we could use the timestamp if Last-Modified is unavailable. > > I do not understand why the patch hides the lastmod field behind a basic > getter. If we assert that a timestamp-based

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

On 08/25/2016 04:04 AM, Eduard Bagdasaryan wrote: > Therefore, we could use the timestamp if Last-Modified is unavailable. I do not understand why the patch hides the lastmod field behind a basic getter. If we assert that a timestamp-based last modification value should be used in many cases,

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

2016-08-21 15:58 GMT+03:00 Amos Jeffries : > please dont move the StoreEntry 'lastmod' member variable which exists > between the "ON-DISK STORE_META_STD TLV field" marker comments. > A delta should be the actual difference value -N < 0 < +N. > please take the opportunity

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

On 08/23/2016 09:17 AM, Amos Jeffries wrote: > On 24/08/2016 12:07 a.m., Eduard Bagdasaryan wrote: >> 2016-08-21 15:58 GMT+03:00 Amos Jeffries : >>> To change anything between those markers we have to do a full cache >>> versioning and up/down-grade compatibility dance. >>

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

2016-08-21 15:58 GMT+03:00 Amos Jeffries : > To change anything between those markers we have to do a full cache > versioning and up/down-grade compatibility dance. Could you please clarify what versioning problems you are talking about? It seems that StoreEntry's

Re: [squid-dev] [PATCH] Revalidate without Last-Modified

On 21/08/2016 9:08 a.m., Eduard Bagdasaryan wrote: > Hello, > > This patch fixes bug 4471. > > The bug was caused by the fact that Squid used only Last-Modified header > value for evaluating entry's last modification time while making an > internal revalidation request. So, without Last-Modified