Re: [squid-dev] [PATCH] splicing resumed sessions

2015-04-14 Thread Tsantilas Christos
Hi Amos, I make a new patch for squid-3.5. Use this one it should be OK. It include changes from r14013. On 04/13/2015 03:49 PM, Amos Jeffries wrote: On 11/04/2015 10:01 p.m., Tsantilas Christos wrote: Patch applied as r14012. I am attaching the t13 patch for squid-3.5 too. I've

Re: [squid-dev] [PATCH] splicing resumed sessions

2015-04-13 Thread Amos Jeffries
On 11/04/2015 10:01 p.m., Tsantilas Christos wrote: Patch applied as r14012. I am attaching the t13 patch for squid-3.5 too. I've backported the server_name ACL patch before this one and your 3.5 patch does not seem to apply well on top of it. However the regular backport method bzr merge

Re: [squid-dev] [PATCH] splicing resumed sessions

2015-04-11 Thread Tsantilas Christos
Patch applied as r14012. I am attaching the t13 patch for squid-3.5 too. On 04/11/2015 06:18 AM, Amos Jeffries wrote: On 11/04/2015 1:49 a.m., Tsantilas Christos wrote: I am attaching patch for trunk and squid-3.5 Thank you. Looks pretty good now. On 04/09/2015 04:13 PM, Amos Jeffries

Re: [squid-dev] [PATCH] splicing resumed sessions

2015-04-10 Thread Amos Jeffries
On 11/04/2015 1:49 a.m., Tsantilas Christos wrote: I am attaching patch for trunk and squid-3.5 Thank you. Looks pretty good now. On 04/09/2015 04:13 PM, Amos Jeffries wrote: * Ssl::Bio::sslFeatures::parseV3Hello() - similar issues with s/Client Hello/ClientHello/ and SSL Extension as

Re: [squid-dev] [PATCH] splicing resumed sessions

2015-04-09 Thread Tsantilas Christos
A new version of the patch. This is removes the ssl_bump_resuming_sessions directive, includes many fixes over the previous patch. Also include support for NPN and ALPN tls extensions, required to correctly bump SSL connections. Please read carefully the patch preamble , specially the

Re: [squid-dev] [PATCH] splicing resumed sessions

2015-04-09 Thread Alex Rousskov
On 04/09/2015 07:13 AM, Amos Jeffries wrote: So for now this patch is okay, but we/you should already be thinking about how to auto-translate NPN from clients into ALPN to servers. Please keep in mind that it is not possible to translate something and still splice a new SSL session (the

Re: [squid-dev] [PATCH] splicing resumed sessions

2015-04-08 Thread Alex Rousskov
On 04/08/2015 07:13 PM, Amos Jeffries wrote: On 4/04/2015 9:17 a.m., Alex Rousskov wrote: On 03/27/2015 05:58 AM, Amos Jeffries wrote: Indeed. Its the hostname vs SNI case we can check and SHOULD do so. The raw-IP ones we can skip the check. Some nasties will still get passed, but less than

Re: [squid-dev] [PATCH] splicing resumed sessions

2015-03-27 Thread Amos Jeffries
On 25/03/2015 8:35 p.m., Tsantilas Christos wrote: On 03/21/2015 07:45 AM, Amos Jeffries wrote: On 21/03/2015 10:47 a.m., Alex Rousskov wrote: On 03/20/2015 12:11 PM, Amos Jeffries wrote: On 21/03/2015 4:35 a.m., Alex Rousskov wrote: On 03/20/2015 02:06 AM, Amos Jeffries wrote: On 18/03/2015

Re: [squid-dev] [PATCH] splicing resumed sessions

2015-03-20 Thread Amos Jeffries
On 18/03/2015 6:21 a.m., Tsantilas Christos wrote: This patch adds the ssl_bump_resuming_sessions directive that controls SslBump behavior when dealing with resuming SSL/TLS sessions. Without these changes, SslBump usually terminates all resuming sessions with an error because such sessions do

Re: [squid-dev] [PATCH] splicing resumed sessions

2015-03-20 Thread Amos Jeffries
On 18/03/2015 6:21 a.m., Tsantilas Christos wrote: This patch adds the ssl_bump_resuming_sessions directive that controls SslBump behavior when dealing with resuming SSL/TLS sessions. Without these changes, SslBump usually terminates all resuming sessions with an error because such sessions do

Re: [squid-dev] [PATCH] splicing resumed sessions

2015-03-20 Thread Amos Jeffries
On 21/03/2015 4:35 a.m., Alex Rousskov wrote: On 03/20/2015 02:06 AM, Amos Jeffries wrote: On 18/03/2015 6:21 a.m., Tsantilas Christos wrote: This patch adds the ssl_bump_resuming_sessions directive that controls SslBump behavior when dealing with resuming SSL/TLS sessions. Without these

Re: [squid-dev] [PATCH] splicing resumed sessions

2015-03-20 Thread Alex Rousskov
On 03/20/2015 12:11 PM, Amos Jeffries wrote: On 21/03/2015 4:35 a.m., Alex Rousskov wrote: On 03/20/2015 02:06 AM, Amos Jeffries wrote: On 18/03/2015 6:21 a.m., Tsantilas Christos wrote: This patch adds the ssl_bump_resuming_sessions directive that controls SslBump behavior when dealing with