Re: [squid-dev] Drop cache_object protocol support

2023-01-26 Thread Alex Rousskov
On 1/26/23 04:12, Amos Jeffries wrote: On 26/01/2023 3:30 am, Alex Rousskov wrote: On 1/25/23 07:29, Amos Jeffries wrote: On 25/01/2023 5:34 pm, Alex Rousskov wrote: IMO, we should not keep any code that is only needed for Squid v3.1 and earlier. Squid v3.2 and later should http-based cache

Re: [squid-dev] Drop cache_object protocol support

2023-01-26 Thread Amos Jeffries
On 26/01/2023 3:30 am, Alex Rousskov wrote: On 1/25/23 07:29, Amos Jeffries wrote: On 25/01/2023 5:34 pm, Alex Rousskov wrote: On 1/24/23 20:57, Amos Jeffries wrote: Blocker #2: The squidclient tool still sends cache_object: scheme when given "mgr:" on the CLI. We need to upgrade that first

Re: [squid-dev] Drop cache_object protocol support

2023-01-25 Thread Eduard Bagdasaryan
On 25.01.2023 16:58, Eduard Bagdasaryan wrote: On 25.01.2023 15:29, Amos Jeffries wrote: On 25/01/2023 5:34 pm, Alex Rousskov wrote: On 1/24/23 20:57, Amos Jeffries wrote: Blocker #1: The cachemgr_passwd directly still needs to be cleanly removed, eg replaced by a manager_access ACL based

Re: [squid-dev] Drop cache_object protocol support

2023-01-25 Thread Alex Rousskov
On 1/25/23 07:29, Amos Jeffries wrote: On 25/01/2023 5:34 pm, Alex Rousskov wrote: On 1/24/23 20:57, Amos Jeffries wrote: Blocker #2: The squidclient tool still sends cache_object: scheme when given "mgr:" on the CLI. We need to upgrade that first Looks like we are in agreement on that.

Re: [squid-dev] Drop cache_object protocol support

2023-01-25 Thread Eduard Bagdasaryan
On 25.01.2023 15:29, Amos Jeffries wrote: On 25/01/2023 5:34 pm, Alex Rousskov wrote: On 1/24/23 20:57, Amos Jeffries wrote: Blocker #1:  The cachemgr_passwd directly still needs to be cleanly removed, eg replaced by a manager_access ACL based mechanism. I do not see a relationship: I have

Re: [squid-dev] Drop cache_object protocol support

2023-01-25 Thread Amos Jeffries
On 25/01/2023 5:34 pm, Alex Rousskov wrote: On 1/24/23 20:57, Amos Jeffries wrote: Blocker #1:  The cachemgr_passwd directly still needs to be cleanly removed, eg replaced by a manager_access ACL based mechanism. I do not see a relationship: I have not tested it, but the existing

Re: [squid-dev] Drop cache_object protocol support

2023-01-24 Thread Alex Rousskov
On 1/24/23 20:57, Amos Jeffries wrote: Blocker #1:  The cachemgr_passwd directly still needs to be cleanly removed, eg replaced by a manager_access ACL based mechanism. I do not see a relationship: I have not tested it, but the existing CacheManager::ParseHeaders() code already extracts

Re: [squid-dev] Drop cache_object protocol support

2023-01-24 Thread Amos Jeffries
On 25/01/2023 8:23 am, Alex Rousskov wrote: On 1/24/23 12:22, Eduard Bagdasaryan wrote: Today we can query cache manager in two ways: 1. with cache_object:// URL scheme 2. with an HTTP request having the 'squid-internal-mgr' path prefix. I guess that when (2) was initially added at e37bd29,

Re: [squid-dev] Drop cache_object protocol support

2023-01-24 Thread Alex Rousskov
On 1/24/23 12:22, Eduard Bagdasaryan wrote: Today we can query cache manager in two ways: 1. with cache_object:// URL scheme 2. with an HTTP request having the 'squid-internal-mgr' path prefix. I guess that when (2) was initially added at e37bd29, its implementation was somewhat incomplete