Re: cvs commit: squid/src cache_cf.c

2008-02-10 Thread Guido Serassio
Hi Henrik, At 03:01 08/02/2008, Henrik Nordstrom wrote: hno 2008/02/07 19:01:16 MST Modified files: src cache_cf.c Log: Make include support wildcard patterns Revision ChangesPath 1.488 +14 -4 squid/src/cache_cf.c Bad news here: glob() and

two xasserts in squid3

2008-02-10 Thread Tsantilas Christos
Hi all, There is something which confuse me. The xassert function implemented in squid3 in two places, in the file src/debug.cc and in the lib/assert.c file. Also the assert macro declared in src/Debug.h file and in the include/assert.h file. Is there any reason for these two implementations

Re: two xasserts in squid3

2008-02-10 Thread Amos Jeffries
> Hi all, > There is something which confuse me. > The xassert function implemented in squid3 in two places, in the file > src/debug.cc and in the lib/assert.c file. Also the assert macro > declared in src/Debug.h file and in the include/assert.h file. > > Is there any reason for these two imp

Re: cvs commit: squid3/src cf.data.pre

2008-02-10 Thread Amos Jeffries
> hno 2008/02/08 04:20:28 MST > > Modified files: > src cf.data.pre > Log: > Restrict the cgi-bin refresh pattern to just */cgi-bin/* > > Revision ChangesPath > 1.500 +1 -1 squid3/src/cf.data.pre > > That would be a violation of the RFC would it

Re: two xasserts in squid3

2008-02-10 Thread Robert Collins
On Mon, 2008-02-11 at 10:15 +1300, Amos Jeffries wrote: > What I'm seeing with the auto-docs work is that a lot of header > files > include squid.h or protos.h for one or two simple things. That file > brings with it a host of type-dependencies, directly or indirectly > that > clutter up the who

Re: two xasserts in squid3

2008-02-10 Thread Amos Jeffries
> > On Mon, 2008-02-11 at 10:15 +1300, Amos Jeffries wrote: >> What I'm seeing with the auto-docs work is that a lot of header >> files >> include squid.h or protos.h for one or two simple things. That file >> brings with it a host of type-dependencies, directly or indirectly >> that >> clutter u

Re: cvs commit: squid/src cache_cf.c

2008-02-10 Thread Henrik Nordström
sön 2008-02-10 klockan 12:28 +0100 skrev Guido Serassio: > Hi Henrik, > > At 03:01 08/02/2008, Henrik Nordstrom wrote: > >hno 2008/02/07 19:01:16 MST > > > > Modified files: > > src cache_cf.c > > Log: > > Make include support wildcard patterns > > > > Revisio

Re: two xasserts in squid3

2008-02-10 Thread Adrian Chadd
On Mon, Feb 11, 2008, Amos Jeffries wrote: > FWIW the keyword 'typedef' is as evil in C++ as #define, and only 'goto' > is worse (and completely unnecessary since functional-C deprecated > pascal). Goto is fine. You just need to know how and when to use it. My use of goto in new Squid C code I w

Re: two xasserts in squid3

2008-02-10 Thread Amos Jeffries
> On Mon, Feb 11, 2008, Amos Jeffries wrote: > >> FWIW the keyword 'typedef' is as evil in C++ as #define, and only 'goto' >> is worse (and completely unnecessary since functional-C deprecated >> pascal). > > Goto is fine. You just need to know how and when to use it. > > My use of goto in new Squi

Re: two xasserts in squid3

2008-02-10 Thread Adrian Chadd
On Mon, Feb 11, 2008, Amos Jeffries wrote: > > I end up with -one- exit location in the function and I don't have to > > bum around using extra functions or massively nested conditional > > constructs to achieve it. In fact, I've used goto in a few places to > > tidy up the code.. > > If you need

Re: two xasserts in squid3

2008-02-10 Thread Amos Jeffries
> On Mon, Feb 11, 2008, Amos Jeffries wrote: > >> > I end up with -one- exit location in the function and I don't have to >> > bum around using extra functions or massively nested conditional >> > constructs to achieve it. In fact, I've used goto in a few places to >> > tidy up the code.. >> >> If

Re: two xasserts in squid3

2008-02-10 Thread Adrian Chadd
On Mon, Feb 11, 2008, Amos Jeffries wrote: > > It took me quite a while to get over the "goto is evil, never ever use it" > > koolaid. But then, in C++, you should be using exceptions, not weird > > flow control tricks. :) > > I've never fully subscribed to that generalisation. But the arguments

Re: two xasserts in squid3

2008-02-10 Thread Robert Collins
On Mon, 2008-02-11 at 11:49 +0900, Adrian Chadd wrote: > On Mon, Feb 11, 2008, Amos Jeffries wrote: > > > > I end up with -one- exit location in the function and I don't have to > > > bum around using extra functions or massively nested conditional > > > constructs to achieve it. In fact, I've us

Re: HEAD squid3/src SquidString.h,1.15,1.16 String.cci,1.11,1.12

2008-02-10 Thread Adrian Chadd
On Mon, Feb 11, 2008, Amos Jeffries wrote: > > Oh &^%^%$!! > > Whats the Best way to undo this? > Commit a diff which reverts it? :) Adrian > Amos > > Amos Jeffries wrote: > >Update of cvs.devel.squid-cache.org:/cvsroot/squid/squid3/src > > > >Modified Files: > > SquidString.h String.

Re: HEAD squid3/src SquidString.h,1.15,1.16 String.cci,1.11,1.12

2008-02-10 Thread Amos Jeffries
Oh &^%^%$!! Whats the Best way to undo this? Amos Amos Jeffries wrote: Update of cvs.devel.squid-cache.org:/cvsroot/squid/squid3/src Modified Files: SquidString.h String.cci Log Message: Several String fixes. - Add two missing includes when configured --disable-inline - SegFault when new

Re: two xasserts in squid3

2008-02-10 Thread Robert Collins
On Mon, 2008-02-11 at 16:03 +1300, Amos Jeffries wrote: > typedef has its place in C particularly for portability issues, but > that > is vastly reduced in C++. I've only seen the event/callback > function-pointers as a required use for it nowadays. That only because > none has shown me a better

Re: HEAD squid3/src SquidString.h,1.15,1.16 String.cci,1.11,1.12

2008-02-10 Thread Amos Jeffries
Adrian Chadd wrote: On Mon, Feb 11, 2008, Amos Jeffries wrote: Oh &^%^%$!! Whats the Best way to undo this? Commit a diff which reverts it? :) This was to cvs.devel.squid-cache.org HEAD. Same way the Arthur (I think) buggered up HEAD earlier. Is it Best to do a reverse patch in that case