Valgrind results

2008-03-23 Thread Amos Jeffries
Just doing a quick check with valgrind I'm seeing a lot of errors in the event system. Syscall param epoll_ctl(event) points to uninitialised byte(s) with a wide range of events like: ==25761==at 0x4559A59: epoll_ctl (in /lib/libc-2.7.so) ==25761==by 0x8171C2F: comm_read(int, char*,

Re: Valgrind results

2008-03-23 Thread Adrian Chadd
You can ignore that. If you care that much about the epoll error then just bzero() the data being passed into epoll_ctl() before its called. adrian On Mon, Mar 24, 2008, Amos Jeffries wrote: Just doing a quick check with valgrind I'm seeing a lot of errors in the event system. Syscall

Re: Valgrind results

2008-03-23 Thread Amos Jeffries
Adrian Chadd wrote: You can ignore that. If you care that much about the epoll error then just bzero() the data being passed into epoll_ctl() before its called. I care about every potential cause of trouble in squid. Particularly avoidable ones that pop up all the time. 'Zero errors' policy

[MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage

2008-03-23 Thread Amos Jeffries
Fix memory leak in Linux builds. # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: [EMAIL PROTECTED] # target_branch: file:///src/squid/bzr/trunk/ # testament_sha1: 17d43699f1813e00a034e95f491c5dbb84d791c3 # timestamp: 2008-03-23 23:19:37 +1200 # base_revision_id: [EMAIL PROTECTED] #

Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage

2008-03-23 Thread Bundle Buggy
Bundle Buggy has detected this merge request. For details, see: http://squid-cache.org/bundlebuggy//request/%3C20080323112051.7AD57E6FE9%40treenet.co.nz%3E

Re: Valgrind results

2008-03-23 Thread Adrian Chadd
On Mon, Mar 24, 2008, Amos Jeffries wrote: Adrian Chadd wrote: You can ignore that. If you care that much about the epoll error then just bzero() the data being passed into epoll_ctl() before its called. I care about every potential cause of trouble in squid. Particularly avoidable ones

Re: Valgrind results

2008-03-23 Thread Amos Jeffries
Adrian Chadd wrote: On Mon, Mar 24, 2008, Amos Jeffries wrote: Adrian Chadd wrote: You can ignore that. If you care that much about the epoll error then just bzero() the data being passed into epoll_ctl() before its called. I care about every potential cause of trouble in squid. Particularly

Re: Valgrind results

2008-03-23 Thread Adrian Chadd
On Mon, Mar 24, 2008, Amos Jeffries wrote: Thats cool. There's just bigger fish to fry. :) Like why '--with-valgrind' doesn't enable the initialisation code somebody already added to squid for those minor ones Trying leakfinder + valgrind now. Heh, valgrind makes it mostly easy to

Re: [MERGE] Replace leaking addrinfo in comm_connect_addr() with sockaddr_storage

2008-03-23 Thread Bernhard Schmidt
Amos Jeffries [EMAIL PROTECTED] wrote: Fix memory leak in Linux builds. This one seems to break outgoing IPv4 connects (on a dualstacked Squid) bzr trunk revision 8902 fails with | While trying to retrieve the URL: http://www.heise.de/ | | The following error was encountered: | | *

Re: [squid-core] v3 roadmap

2008-03-23 Thread Alex Rousskov
On Sun, 2008-03-23 at 15:24 +1300, Amos Jeffries wrote: Henrik Nordstrom wrote: On Wed, 2008-03-19 at 11:15 +1300, Amos Jeffries wrote: - I'm kind of in favour of it as a pure file-movements-only alteration. 3.2 has no feature-requests yet and back-porting across a