Re: Strategy

2008-09-21 Thread Amos Jeffries
Alex Rousskov wrote: On Sun, 2008-09-21 at 01:05 +0200, Kinkie wrote: On Sat, Sep 20, 2008 at 9:26 PM, Alex Rousskov [EMAIL PROTECTED] wrote: On Sat, 2008-09-20 at 13:31 +0200, Kinkie wrote: On Fri, Sep 19, 2008 at 9:08 PM, Alex Rousskov [EMAIL PROTECTED] wrote: On Fri, 2008-08-22 at 10:24

Re: [MERGE] Connection pinning patch

2008-09-21 Thread Amos Jeffries
Tsantilas Christos wrote: Hi all, This patch fixes the bug 1632 (http://www.squid-cache.org/bugs/show_bug.cgi?id=1632) It is based on the original squid2.5 connection pinning patch developed by Henrik (http://devel.squid-cache.org/projects.html#pinning) and the related squid 2.6 connection

Re: [MERGE] Connection pinning patch

2008-09-21 Thread Amos Jeffries
Amos Jeffries has voted approve. Status is now: Semi-approved For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C48D53750.8020104%40users.sourceforge.net%3E Project: Squid

Re: [MERGE] Connection pinning patch

2008-09-21 Thread Adrian Chadd
Its a 900-odd line patch; granted, a lot of it is boiler plate for config parsing and management, but I recall the issues connection pinning had when it was introduced and I'd hate to try and be the one debugging whatever crazy stuff pops up in 3.1 combined with the changes to the workflow

Re: [MERGE] Connection pinning patch

2008-09-21 Thread Tsantilas Christos
Adrian Chadd wrote: Its a 900-odd line patch; granted, a lot of it is boiler plate for config parsing and management, but I recall the issues connection pinning had when it was introduced and I'd hate to try and be the one debugging whatever crazy stuff pops up in 3.1 combined with the changes

Re: Strategy

2008-09-21 Thread Kinkie
On Sun, Sep 21, 2008 at 1:36 PM, Amos Jeffries [EMAIL PROTECTED] wrote: Alex Rousskov wrote: On Sun, 2008-09-21 at 01:05 +0200, Kinkie wrote: On Sat, Sep 20, 2008 at 9:26 PM, Alex Rousskov [EMAIL PROTECTED] wrote: On Sat, 2008-09-20 at 13:31 +0200, Kinkie wrote: On Fri, Sep 19, 2008 at

Re: Strategy

2008-09-21 Thread Alex Rousskov
On Sun, 2008-09-21 at 22:26 +0200, Kinkie wrote: Still, WordList is ready for merging, while String a long way off. It's build-tested, it's run-tested, and it's a fairly straightforward porting of the current codebase. It may be a waste of time in the end, but if it's mergeable, not merging

Re: Strategy

2008-09-21 Thread Alex Rousskov
On Sun, 2008-09-21 at 23:36 +1200, Amos Jeffries wrote: Alex Rousskov wrote: * Look for simpler warts with localized impact. We have plenty of them and your energy would be well spent there. If you have a choice, do not try to improve something as fundamental and as critical as String.

Re: [MERGE] Connection pinning patch

2008-09-21 Thread Alex Rousskov
On Mon, 2008-09-22 at 00:07 +0800, Adrian Chadd wrote: Its a 900-odd line patch; granted, a lot of it is boiler plate for config parsing and management, but I recall the issues connection pinning had when it was introduced and I'd hate to try and be the one debugging whatever crazy stuff pops

Re: [MERGE] Connection pinning patch

2008-09-21 Thread Adrian Chadd
2008/9/22 Alex Rousskov [EMAIL PROTECTED]: It would help if there was a document describing what connection pinning is and what are the known pitfalls. Do we have such a document? Is RFC 4559 enough? I'll take another read. I think we should look at documenting these sorts of features

Re: [MERGE] Connection pinning patch

2008-09-21 Thread Amos Jeffries
2008/9/22 Alex Rousskov [EMAIL PROTECTED]: It would help if there was a document describing what connection pinning is and what are the known pitfalls. Do we have such a document? Is RFC 4559 enough? I'll take another read. I think we should look at documenting these sorts of features

[MERGE] Address comments from Alex and Amos.

2008-09-21 Thread Benno Rice
Address comments from Alex and Amos. - Add some comments describing various function purposes. - Remove some debugging debugs that had crept in. - Use debugs() in preference to debug()(). - Adjust some debug levels. # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: [EMAIL

Re: [MERGE] Address comments from Alex and Amos.

2008-09-21 Thread Bundle Buggy
Bundle Buggy has detected this merge request. For details, see: http://bundlebuggy.aaronbentley.com/project/squid/request/%3C200809220055.m8M0t8nY051276%40harfy.jeamland.net%3E Project: Squid

Re: Strategy

2008-09-21 Thread Amos Jeffries
On Sun, 2008-09-21 at 22:26 +0200, Kinkie wrote: Still, WordList is ready for merging, while String a long way off. It's build-tested, it's run-tested, and it's a fairly straightforward porting of the current codebase. It may be a waste of time in the end, but if it's mergeable, not merging

Re: Strategy

2008-09-21 Thread Adrian Chadd
Put this stuff on hold, get Squid-3.1 out of the way, sort out the issues surrounding that before you start throwing more code into Squid-3 trunk, and -then- have this discussion. We can sort this stuff out in a short period of time if its our only focus. Adrian 2008/9/22 Amos Jeffries [EMAIL

Re: Strategy

2008-09-21 Thread Adrian Chadd
And in the meantime, if someone (eg kinkie) wants to work on this stuff some more, I suggest sitting down and writing some of the support code which would use it. Write a HTTP parser, HTTP response builder, do some benchmaking, perhaps glue it to something like libevent or some other comm

Upgrade bzr on squid-cache.org to 1.6.1?

2008-09-21 Thread Benno Rice
Whenever I communicate with bzr on squid-cache.org it complains about the server not speaking network protocol version 3. I understand that this probably isn't a show-stopper of any nature but would it be an idea to update bzr on squid-cache.org at some point? -- Benno Rice [EMAIL

Re: Strategy

2008-09-21 Thread Alex Rousskov
On Mon, 2008-09-22 at 13:45 +1200, Amos Jeffries wrote: On Sun, 2008-09-21 at 23:36 +1200, Amos Jeffries wrote: Alex Rousskov wrote: * Look for simpler warts with localized impact. We have plenty of them and your energy would be well spent there. If you have a choice, do not try

Re: Strategy

2008-09-21 Thread Alex Rousskov
On Mon, 2008-09-22 at 10:36 +0800, Adrian Chadd wrote: Put this stuff on hold, get Squid-3.1 out of the way, sort out the issues surrounding that before you start throwing more code into Squid-3 trunk, and -then- have this discussion. If this stuff is WordList, then put this stuff on hold is

Re: Strategy

2008-09-21 Thread Adrian Chadd
only focus should really have been our main focus at that short period of time, not the only thing we care about. Sheesh. :P Adrian 2008/9/22 Alex Rousskov [EMAIL PROTECTED]: On Mon, 2008-09-22 at 10:36 +0800, Adrian Chadd wrote: Put this stuff on hold, get Squid-3.1 out of the way, sort

Re: [MERGE] Address comments from Alex and Amos.

2008-09-21 Thread Alex Rousskov
On Mon, 2008-09-22 at 10:55 +1000, Benno Rice wrote: Address comments from Alex and Amos. - Add some comments describing various function purposes. - Remove some debugging debugs that had crept in. - Use debugs() in preference to debug()(). - Adjust some debug levels. I believe my