Re: [RFC] Squid process model and service name impact

2014-01-28 Thread Tsantilas Christos
On 01/27/2014 03:44 PM, Amos Jeffries wrote: On 27/01/2014 8:18 a.m., Henrik Nordström wrote: sön 2014-01-26 klockan 13:59 +1300 skrev Amos Jeffries: Ditto for shared memory spaces. Named shared memory spaces need consistent naming. Having a squid.conf directive with a macro expansion

Re: /bzr/squid3/trunk/ r13247: Add ${service_name} macro to squid.conf processing

2014-01-28 Thread Alex Rousskov
On 01/26/2014 08:06 PM, Amos Jeffries wrote: revno: 13247 committer: Amos Jeffries squ...@treenet.co.nz branch nick: trunk timestamp: Sun 2014-01-26 20:06:15 -0700 message: Add ${service_name} macro to squid.conf processing

Re: [RFC] Squid process model and service name impact

2014-01-28 Thread Alex Rousskov
On 01/27/2014 06:44 AM, Amos Jeffries wrote: On 27/01/2014 8:18 a.m., Henrik Nordström wrote: How do using a service name for these differ from having a squid.conf set the name (possibly using the same service name as a macro expansion)? squid.conf lines effects differ based on all the

Re: [RFC] Squid process model and the need for -n

2014-01-28 Thread Alex Rousskov
On 11/01/2013 07:11 AM, Amos Jeffries wrote: -n - Windows service name The Windows build of Squid requires a -n option to point at the particular named service which is running in the background. Which defaults to the name squid when omitted. Why do we need a command line option to specify

[PATCH] Setting SO_KEEPALIVE on outbound connections

2014-01-28 Thread eam
Hi Squid devs, Below I include a patch to enable configurable SO_KEEPALIVE on outbound connections from Squid. Amos helped me out with some advice on squid-users@ and I've diverged a bit from the advice -- I'd like to explain my reasoning: 1) This patch simply enables SO_KEEPALIVE for outbound

Re: [RFC] Squid process model and the need for -n

2014-01-28 Thread Henrik Nordström
tis 2014-01-28 klockan 11:25 -0700 skrev Alex Rousskov: Why do we need a command line option to specify a service name? Can the service name be configured via squid.conf? The squid.conf location is already configurable via command line, of course. If I remember correctly the service name is

Re: [RFC] Squid process model and the need for -n

2014-01-28 Thread Alex Rousskov
On 01/28/2014 11:56 AM, Henrik Nordström wrote: tis 2014-01-28 klockan 11:25 -0700 skrev Alex Rousskov: Why do we need a command line option to specify a service name? Can the service name be configured via squid.conf? The squid.conf location is already configurable via command line, of

Re: debugs from an interesting CBDATA case study

2014-01-28 Thread Alex Rousskov
On 01/21/2014 01:23 AM, Amos Jeffries wrote: On 14/01/2014 3:31 p.m., Alex Rousskov wrote: On 01/07/2014 08:35 AM, Alex Rousskov wrote: 2) [Add cbdata debugging to] find which object stores the invalid cbdata pointer. Then find how that invalid pointer gets to that object. I think it

Re: [RFC] Squid process model and the need for -n

2014-01-28 Thread Henrik Nordström
tis 2014-01-28 klockan 12:15 -0700 skrev Alex Rousskov: but squid.conf location is already configurable via the command line. Why another option, that is now propagated to non-Windows builds, without even defining what service is in non-Windows context (AFAIK). If I am not mistaken the

Re: [PATCH] Setting SO_KEEPALIVE on outbound connections

2014-01-28 Thread Alex Rousskov
On 01/28/2014 11:14 AM, e...@frap.net wrote: Below I include a patch to enable configurable SO_KEEPALIVE on outbound connections from Squid. +NAME: tcp_keepalive If the new directive is specific to outbound connections, should it be renamed to reflect that fact? How about

Build failed in Jenkins: 3.HEAD-amd64-centos-6 #197

2014-01-28 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-centos-6/197/changes Changes: [Alex Rousskov] Comm job callbacks need job's cbdata pointer, not a job pointer. Otherwise, in complex inheritance hierarchies, some [inner] classes will hit cbdata cookie assertions when scheduling Comm calls with

Re: [RFC] ignore ftp_epsv off for IPv6

2014-01-28 Thread Alex Rousskov
On 01/25/2014 06:05 PM, Amos Jeffries wrote: On 25/01/2014 9:27 a.m., Alex Rousskov wrote: I propose to limit squid.conf ftp_epsv off prohibition to IPv4 FTP servers. ... Do you think it would be OK to allow the use of EPSV commands with IPv6 servers even if ftp_epsv is off? off

Re: RunnersRegistry dependencies

2014-01-28 Thread Alex Rousskov
On 01/26/2014 06:58 PM, Amos Jeffries wrote: I am looking at making a few more items in the startup and shutdown sequences of Squid into Runners. I cannot quite see how to create dependencies such that Runner A does not occur until after Runner B has completed. Such as allocate cache heaps

Re: [PATCH] Setting SO_KEEPALIVE on outbound connections

2014-01-28 Thread eam
On Tue, Jan 28, 2014 at 01:03:24PM -0700, Alex Rousskov wrote: On 01/28/2014 11:14 AM, e...@frap.net wrote: Below I include a patch to enable configurable SO_KEEPALIVE on outbound connections from Squid. +NAME: tcp_keepalive If the new directive is specific to outbound connections,

Re: [PATCH] Setting SO_KEEPALIVE on outbound connections

2014-01-28 Thread Alex Rousskov
On 01/28/2014 02:52 PM, e...@frap.net wrote: On Tue, Jan 28, 2014 at 01:03:24PM -0700, Alex Rousskov wrote: Should this directive implementation be adjusted to also work for disabling TCP keepalive for outbound connections if the admin wants to overwrite a system-wide setting? I think this

Re: [RFC] Squid process model and service name impact

2014-01-28 Thread Amos Jeffries
On 2014-01-29 07:21, Alex Rousskov wrote: On 01/27/2014 06:44 AM, Amos Jeffries wrote: On 27/01/2014 8:18 a.m., Henrik Nordström wrote: How do using a service name for these differ from having a squid.conf set the name (possibly using the same service name as a macro expansion)? squid.conf

Re: [RFC] ignore ftp_epsv off for IPv6

2014-01-28 Thread Amos Jeffries
On 29/01/2014 9:24 a.m., Alex Rousskov wrote: On 01/25/2014 06:05 PM, Amos Jeffries wrote: On 25/01/2014 9:27 a.m., Alex Rousskov wrote: I propose to limit squid.conf ftp_epsv off prohibition to IPv4 FTP servers. ... Do you think it would be OK to allow the use of EPSV commands with

Re: [RFC] Squid process model and service name impact

2014-01-28 Thread Alex Rousskov
I wrote a detailed point-by-point response, but decided to delete it. I doubt it would bring us closer to an agreement because we are still looking at the problem from two different angles: On 01/28/2014 05:29 PM, Amos Jeffries wrote: Lets look at the BNF: FOO.pid = chroot pid_filename

Re: [RFC] ignore ftp_epsv off for IPv6

2014-01-28 Thread Alex Rousskov
On 01/28/2014 09:29 PM, Amos Jeffries wrote: On 29/01/2014 9:24 a.m., Alex Rousskov wrote: On 01/25/2014 06:05 PM, Amos Jeffries wrote: off should never be abused to mean half-off. The problem here is that the directive itself was misnamed IMO. It should have been ftp_epsv_for_ipv4 or

Re: [RFC] Squid process model and service name impact

2014-01-28 Thread Kinkie
hard-coded is being used a bit much here. I don't think any of us are arguing for that. Lets look at the BNF: FOO.pid = chroot pid_filename chroot = {squid.conf chroot} | / pid_filename = {squid.conf pid_filename} | DEFAULT_PID_FILE DEFAULT_PID_FILE = {./configure --with-pidfile} |

Re: [RFC] ignore ftp_epsv off for IPv6

2014-01-28 Thread Amos Jeffries
On 29/01/2014 6:40 p.m., Alex Rousskov wrote: On 01/28/2014 09:29 PM, Amos Jeffries wrote: On 29/01/2014 9:24 a.m., Alex Rousskov wrote: On 01/25/2014 06:05 PM, Amos Jeffries wrote: off should never be abused to mean half-off. The problem here is that the directive itself was misnamed IMO.