Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-23 Thread Amos Jeffries
On 23/06/2014 5:43 a.m., Tsantilas Christos wrote: Hi all, The attached patch replaces existin annotation values with the new one received from helpers. Just one question. We are documenting key-value pairs in cf.data.pre only for url-rewriter helpers, but annotations works for all squid

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-23 Thread Tsantilas Christos
On 06/23/2014 09:50 AM, Amos Jeffries wrote: On 23/06/2014 5:43 a.m., Tsantilas Christos wrote: Hi all, The attached patch replaces existin annotation values with the new one received from helpers. Just one question. We are documenting key-value pairs in cf.data.pre only for url-rewriter

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-23 Thread Alex Rousskov
On 06/23/2014 07:44 AM, Tsantilas Christos wrote: On 06/23/2014 09:50 AM, Amos Jeffries wrote: On 23/06/2014 5:43 a.m., Tsantilas Christos wrote: clt_conn_id=ID Associates the received ID with the client TCP connection. The clt_conn_id=ID pair is treated as a regular annotation

Re: [RFC] connections logging

2014-06-23 Thread Alex Rousskov
On 06/20/2014 03:04 AM, Amos Jeffries wrote: I am playing with the idea of adding a new log file to record just the connections handled by Squid (rather than the HTTP request/reply transactions). This log would include connections opened but never used, port details, connection lifetimes,

[PATCH] Fixes to get more collapsed forwarding hits

2014-06-23 Thread Alex Rousskov
Hello, The attached patch contains several changes to improve the probability of getting a collapsed forwarding hit: * Allow STORE_MEMORY_CLIENTs to open disk files if needed and possible. STORE_*_CLIENT designation is rather buggy (several known XXXs). Some collapsed clients are marked as

Re: [RFC] connections logging

2014-06-23 Thread Kinkie
On Tue, Jun 24, 2014 at 2:26 AM, Alex Rousskov rouss...@measurement-factory.com wrote: On 06/20/2014 03:04 AM, Amos Jeffries wrote: I am playing with the idea of adding a new log file to record just the connections handled by Squid (rather than the HTTP request/reply transactions). This log

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-23 Thread Amos Jeffries
On 24/06/2014 8:19 a.m., Alex Rousskov wrote: On 06/23/2014 07:44 AM, Tsantilas Christos wrote: On 06/23/2014 09:50 AM, Amos Jeffries wrote: On 23/06/2014 5:43 a.m., Tsantilas Christos wrote: clt_conn_id=ID Associates the received ID with the client TCP connection. The

Re: [PATCH] Support client connection annotation by helpers via clt_conn_id=ID

2014-06-23 Thread Amos Jeffries
On 24/06/2014 1:44 a.m., Tsantilas Christos wrote: On 06/23/2014 09:50 AM, Amos Jeffries wrote: On 23/06/2014 5:43 a.m., Tsantilas Christos wrote: Hi all, The attached patch replaces existin annotation values with the new one received from helpers. Just one question. We are documenting

Re: [PATCH] Fixes to get more collapsed forwarding hits

2014-06-23 Thread Amos Jeffries
On 24/06/2014 4:07 p.m., Alex Rousskov wrote: Hello, The attached patch contains several changes to improve the probability of getting a collapsed forwarding hit: * Allow STORE_MEMORY_CLIENTs to open disk files if needed and possible. STORE_*_CLIENT designation is rather buggy