Re: [RFC] squid-3.6 unit tests

2014-08-23 Thread Amos Jeffries
On 23/08/2014 5:41 a.m., Alex Rousskov wrote: On 08/20/2014 09:16 PM, Amos Jeffries wrote: Future versions of autoconf/automake will be auto-enabling their subdir-objects feature. This impacts Squid in a few ways, the largest being how we perform unit testing. At present our unit tests link

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-9.1-clang #636

2014-08-23 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-FreeBSD-9.1-clang/636/changes Changes: [Amos Jeffries] Cleanup: remove goto from logformat token parser [Amos Jeffries] Cleanup: remove goto from clientProcessRequest() The code path can be better statically analysed without goto statements.

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-9.1 #738

2014-08-23 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-FreeBSD-9.1/738/changes Changes: [Amos Jeffries] Cleanup: remove goto from logformat token parser [Amos Jeffries] Cleanup: remove goto from clientProcessRequest() The code path can be better statically analysed without goto statements. Bonus

Build failed in Jenkins: 3.HEAD-amd64-centos-7 #22

2014-08-23 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-centos-7/22/changes Changes: [Amos Jeffries] Cleanup: remove goto from logformat token parser [Amos Jeffries] Cleanup: remove goto from clientProcessRequest() The code path can be better statically analysed without goto statements. Bonus side

Build failed in Jenkins: 3.HEAD-amd64-centos-7 #23

2014-08-23 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-centos-7/23/changes Changes: [Amos Jeffries] Cleanup: remove goto from Vary: header failure recovery -- [...truncated 12461 lines...] Making uninstall in log make[3]: Entering directory

Jenkins build is back to normal : 3.HEAD-amd64-centos-7-clang #9

2014-08-23 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/9/changes

Build failed in Jenkins: 3.HEAD-amd64-centos-7-clang #10

2014-08-23 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-centos-7-clang/10/changes Changes: [Amos Jeffries] Cleanup: remove goto from Vary: header failure recovery -- [...truncated 12520 lines...] Making uninstall in log make[3]: Entering directory

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-9.1-clang #637

2014-08-23 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-FreeBSD-9.1-clang/637/changes Changes: [Amos Jeffries] Cleanup: remove goto from Vary: header failure recovery -- [...truncated 4215 lines...] libtool: compile: ccache clang++ -DHAVE_CONFIG_H -I../../..

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-9.1 #739

2014-08-23 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-FreeBSD-9.1/739/changes Changes: [Amos Jeffries] Cleanup: remove goto from Vary: header failure recovery -- [...truncated 4154 lines...] libtool: compile: /usr/local/bin/ccache g++ -DHAVE_CONFIG_H

Jenkins build is back to normal : 3.HEAD-amd64-centos-7 #24

2014-08-23 Thread noc
See http://build.squid-cache.org/job/3.HEAD-amd64-centos-7/24/

Re: [RFC] squid-3.6 unit tests

2014-08-23 Thread Alex Rousskov
On 08/23/2014 04:20 AM, Amos Jeffries wrote: On 23/08/2014 5:41 a.m., Alex Rousskov wrote: On 08/20/2014 09:16 PM, Amos Jeffries wrote: Future versions of autoconf/automake will be auto-enabling their subdir-objects feature. This impacts Squid in a few ways, the largest being how we perform

Re: [RFC] squid-3.6 unit tests

2014-08-23 Thread Amos Jeffries
On 24/08/2014 3:59 a.m., Alex Rousskov wrote: If the proposed changes take a few months to implement, then yes, I agree, we should not wait. If it is a matter of a week or two, I suggest doing it now. This is your call though. It should be a relatively quick job. I will give it a shot