Re: [PATCH] update port protocol parameter

2013-07-25 Thread Alex Rousskov
On 07/24/2013 10:24 PM, Amos Jeffries wrote: On 25/07/2013 4:08 p.m., Alex Rousskov wrote: On 07/22/2013 09:36 AM, Amos Jeffries wrote: How does this one suit you? Update the http(s)_port directives protocol= parameter to use AnyP::ProtocolVersion for internal storage instead of opaque

Re: [PATCH] update port protocol parameter

2013-07-24 Thread Alex Rousskov
On 07/22/2013 09:36 AM, Amos Jeffries wrote: How does this one suit you? Update the http(s)_port directives protocol= parameter to use AnyP::ProtocolVersion for internal storage instead of opaque string text. This both limits the possible parameter values to one of HTTP, HTTP/1.1, HTTPS

Re: [PATCH] update port protocol parameter

2013-07-24 Thread Amos Jeffries
On 25/07/2013 4:08 p.m., Alex Rousskov wrote: On 07/22/2013 09:36 AM, Amos Jeffries wrote: How does this one suit you? Update the http(s)_port directives protocol= parameter to use AnyP::ProtocolVersion for internal storage instead of opaque string text. This both limits the possible

Re: [PATCH] update port protocol parameter

2013-07-22 Thread Amos Jeffries
How does this one suit you? Update the http(s)_port directives protocol= parameter to use AnyP::ProtocolVersion for internal storage instead of opaque string text. This both limits the possible parameter values to one of HTTP, HTTP/1.1, HTTPS or HTTPS/1.1 and ensures that URLs generated

Re: [PATCH] update port protocol parameter

2013-07-21 Thread Amos Jeffries
On 18/07/2013 4:12 p.m., Alex Rousskov wrote: On 07/17/2013 08:16 PM, Amos Jeffries wrote: On 18/07/2013 1:36 p.m., Alex Rousskov wrote: On 07/06/2013 08:22 AM, Amos Jeffries wrote: +debugs(3, DBG_CRITICAL, FATAL: URLScheme(s-transport.protocol).const_str() _port: missing ']'

Re: [PATCH] update port protocol parameter

2013-07-21 Thread Alex Rousskov
On 07/21/2013 07:10 PM, Amos Jeffries wrote: On 18/07/2013 4:12 p.m., Alex Rousskov wrote: On 07/17/2013 08:16 PM, Amos Jeffries wrote: On 18/07/2013 1:36 p.m., Alex Rousskov wrote: On 07/06/2013 08:22 AM, Amos Jeffries wrote: +debugs(3, DBG_CRITICAL, FATAL:

Re: [PATCH] update port protocol parameter

2013-07-17 Thread Alex Rousskov
On 07/06/2013 08:22 AM, Amos Jeffries wrote: This patch updates the *_port directives protocol= parameter to accept to use AnyP::ProtocolVersion internal storage instead of opaque string text. The above says instead but the patch leaves the old string-based constructor. Do we still need that

Re: [PATCH] update port protocol parameter

2013-07-17 Thread Amos Jeffries
On 18/07/2013 1:36 p.m., Alex Rousskov wrote: On 07/06/2013 08:22 AM, Amos Jeffries wrote: This patch updates the *_port directives protocol= parameter to accept to use AnyP::ProtocolVersion internal storage instead of opaque string text. The above says instead but the patch leaves the old

Re: [PATCH] update port protocol parameter

2013-07-17 Thread Alex Rousskov
On 07/17/2013 08:16 PM, Amos Jeffries wrote: On 18/07/2013 1:36 p.m., Alex Rousskov wrote: On 07/06/2013 08:22 AM, Amos Jeffries wrote: +debugs(3, DBG_CRITICAL, FATAL: URLScheme(s-transport.protocol).const_str() _port: missing ']' on IPv6 address: token); +

[PATCH] update port protocol parameter

2013-07-06 Thread Amos Jeffries
This patch updates the *_port directives protocol= parameter to accept to use AnyP::ProtocolVersion internal storage instead of opaque string text. This both limits the possible parameter values to one of HTTP, HTTP/1.1, HTTPS, or HTTPS/1.1 and ensures that URLs generated from that protocol