On 20/07/2013 4:28 a.m., Tsantilas Christos wrote:
On 07/18/2013 07:22 AM, Amos Jeffries wrote:
Hi Christos,
So sorry for the long delay in reply. This thread seems to be getting
lost in may mailer filters.
+1. I have another long list of tweaks below, BUT these ones are all
very cosmetic
Hi Christos,
So sorry for the long delay in reply. This thread seems to be getting
lost in may mailer filters.
+1. I have another long list of tweaks below, BUT these ones are all
very cosmetic polishing that can be done and comitted without another
review.
Thank you very much for
On 07/17/2013 10:22 PM, Amos Jeffries wrote:
2) Does not allow inside double quoted strings an escaped $ or %
character if the parameter does not support macros.
What about users who want to place config files in a directory path with
spaces AND use per-worker ${process_number} macro on the
On 18/06/2013 9:42 p.m., Tsantilas Christos wrote:
This discussion is also frozen...
Alex and Kinki suggest the function style, and looks that is a good
choice and there are very good reasons for doing this.
Are we OK to implement it like this?
Your call. As implementer you have the final
On 05/26/2013 10:26 PM, Amos Jeffries wrote:
Whether macros are supported or not is irrelevant to the string being
de-coded into a single token or split on whitespace.
On 05/27/2013 07:23 PM, Alex Rousskov wrote:
I agree that we can and perhaps should keep runtime %macros handling
outside
This discussion is also frozen...
Alex and Kinki suggest the function style, and looks that is a good
choice and there are very good reasons for doing this.
Are we OK to implement it like this?
@Alex
What are you suggesting file(location) or parameters(location)?
On 06/04/2013 05:55 PM,
On 06/18/2013 03:42 AM, Tsantilas Christos wrote:
What are you suggesting file(location) or parameters(location)?
parameters() or options() seems better to me because the code actually
loads a squid.conf directive parameters. It cannot load directives
themselves this way (we have an import
On 06/03/2013 08:31 PM, Amos Jeffries wrote:
In summary we seem to be talking about different features here.
I am afraid your summary is incorrect, which may explain why we cannot
reach an agreement:
1) the syntax for linking access method and location.
* this seems to be agreed as : in
On 06/02/2013 03:43 PM, Amos Jeffries wrote:
On 1/06/2013 5:14 a.m., Alex Rousskov wrote:
On 05/31/2013 10:05 AM, Tsantilas Christos wrote:
On 05/27/2013 07:12 PM, Alex Rousskov wrote:
On 05/27/2013 04:54 AM, Tsantilas Christos wrote:
On 05/26/2013 10:05 PM, Kinkie wrote:
The only thing I
On 06/02/2013 06:43 AM, Amos Jeffries wrote:
On 1/06/2013 5:14 a.m., Alex Rousskov wrote:
Stepping back a little, I think there are two big problems with the URL
scheme-like approaches (file:, db:, etc.):
1) They combine the method of access (local file, HTTP, database query,
etc.) with the
In summary we seem to be talking about different features here.
1) the syntax for linking access method and location.
* this seems to be agreed as : in URI-style.
2) whether and how add a new parameter, which is syntactically valid
anywhere and tokens are read 1-per-line from that source.
On 1/06/2013 5:14 a.m., Alex Rousskov wrote:
On 05/31/2013 10:05 AM, Tsantilas Christos wrote:
On 05/27/2013 07:12 PM, Alex Rousskov wrote:
On 05/27/2013 04:54 AM, Tsantilas Christos wrote:
On 05/26/2013 10:05 PM, Kinkie wrote:
The only thing I would like to see differently implemented is
On 05/27/2013 07:12 PM, Alex Rousskov wrote:
On 05/27/2013 04:54 AM, Tsantilas Christos wrote:
On 05/26/2013 10:05 PM, Kinkie wrote:
The only thing I would like to see differently implemented is the
syntax used to include files:
file(path) would be IMO easier to understand and less prone to
On 05/31/2013 10:05 AM, Tsantilas Christos wrote:
On 05/27/2013 07:12 PM, Alex Rousskov wrote:
On 05/27/2013 04:54 AM, Tsantilas Christos wrote:
On 05/26/2013 10:05 PM, Kinkie wrote:
The only thing I would like to see differently implemented is the
syntax used to include files:
file(path)
On 28/05/2013 4:12 a.m., Alex Rousskov wrote:
On 05/27/2013 04:54 AM, Tsantilas Christos wrote:
On 05/26/2013 10:05 PM, Kinkie wrote:
The only thing I would like to see differently implemented is the
syntax used to include files:
file(path) would be IMO easier to understand and less prone to
On 05/28/2013 07:14 AM, Amos Jeffries wrote:
On 28/05/2013 4:12 a.m., Alex Rousskov wrote:
On 05/27/2013 04:54 AM, Tsantilas Christos wrote:
On 05/26/2013 10:05 PM, Kinkie wrote:
The only thing I would like to see differently implemented is the
syntax used to include files:
file(path) would
On 27/05/2013 4:36 a.m., Kinkie wrote:
On Sun, May 26, 2013 at 7:29 AM, Alex Rousskov
rouss...@measurement-factory.com wrote:
On 05/25/2013 09:30 PM, Amos Jeffries wrote:
On 24/05/2013 7:38 a.m., Tsantilas Christos wrote:
This patch :
- adds support for quoted values in the entire squid.conf
On 05/27/2013 07:26 AM, Amos Jeffries wrote:
On 27/05/2013 2:07 a.m., Tsantilas Christos wrote:
On 05/26/2013 06:30 AM, Amos Jeffries wrote:
On 24/05/2013 7:38 a.m., Tsantilas Christos wrote:
snip strings
Secondly, multiple features in one patch:
The MacroUser system you are adding
On 05/26/2013 10:05 PM, Kinkie wrote:
The only thing I would like to see differently implemented is the
syntax used to include files:
file(path) would be IMO easier to understand and less prone to
confusion than the proposed syntax.
OK.
But imagine in the future also the following syntax:
On 05/27/2013 04:54 AM, Tsantilas Christos wrote:
On 05/26/2013 10:05 PM, Kinkie wrote:
The only thing I would like to see differently implemented is the
syntax used to include files:
file(path) would be IMO easier to understand and less prone to
confusion than the proposed syntax.
OK.
But
On 05/26/2013 10:26 PM, Amos Jeffries wrote:
On 27/05/2013 2:07 a.m., Tsantilas Christos wrote:
On 05/26/2013 06:30 AM, Amos Jeffries wrote:
The MacroUser system you are adding here is combining some, but not
enough, of the next step in the libformat project. Thank you for doing
that, but I
On 05/27/2013 12:44 AM, Amos Jeffries wrote:
On 27/05/2013 4:36 a.m., Kinkie wrote:
On Sun, May 26, 2013 at 7:29 AM, Alex Rousskov wrote:
On 05/25/2013 09:30 PM, Amos Jeffries wrote:
IMO, we should drop the '-quoted string handling from this. It is
the first step on a slipery-slope toward
On 05/26/2013 06:30 AM, Amos Jeffries wrote:
On 24/05/2013 7:38 a.m., Tsantilas Christos wrote:
This patch :
- adds support for quoted values in the entire squid.conf
- warn about or prohibit values that can no longer be interpreted as
either quoted strings or simple tokens
- support
On Sun, May 26, 2013 at 7:29 AM, Alex Rousskov
rouss...@measurement-factory.com wrote:
On 05/25/2013 09:30 PM, Amos Jeffries wrote:
On 24/05/2013 7:38 a.m., Tsantilas Christos wrote:
This patch :
- adds support for quoted values in the entire squid.conf
- warn about or prohibit values that
On 05/26/2013 07:36 PM, Kinkie wrote:
On Sun, May 26, 2013 at 7:29 AM, Alex Rousskov
rouss...@measurement-factory.com wrote:
On 05/25/2013 09:30 PM, Amos Jeffries wrote:
On 24/05/2013 7:38 a.m., Tsantilas Christos wrote:
This patch :
- adds support for quoted values in the entire squid.conf
The only thing I would like to see differently implemented is the
syntax used to include files:
file(path) would be IMO easier to understand and less prone to
confusion than the proposed syntax.
OK.
But imagine in the future also the following syntax:
file:/path/file
On 27/05/2013 2:07 a.m., Tsantilas Christos wrote:
On 05/26/2013 06:30 AM, Amos Jeffries wrote:
On 24/05/2013 7:38 a.m., Tsantilas Christos wrote:
snip strings
Secondly, multiple features in one patch:
The MacroUser system you are adding here is combining some, but not
enough, of the
On 24/05/2013 7:38 a.m., Tsantilas Christos wrote:
This patch :
- adds support for quoted values in the entire squid.conf
- warn about or prohibit values that can no longer be interpreted as
either quoted strings or simple tokens
- support file:path/to/file.name syntax to load external
On 05/25/2013 09:30 PM, Amos Jeffries wrote:
On 24/05/2013 7:38 a.m., Tsantilas Christos wrote:
This patch :
- adds support for quoted values in the entire squid.conf
- warn about or prohibit values that can no longer be interpreted as
either quoted strings or simple tokens
- support
29 matches
Mail list logo
