Okay then, applied as trunk 12750.
For the record: We have managed to test everything short of the timing
change about when unpin() is performed. The effects of leaving the
server connection pinned for a few milliseconds longer now than before
is unknown - but probably not too bad.
Amos
On 3/04/2013 3:55 a.m., Alex Rousskov wrote:
On 03/28/2013 12:41 AM, Amos Jeffries wrote:
New patch attached with the above small changes to conn-auth included.
Thanks for addressing all of my concerns,
Alex.
Is that a +1?
Amos
On 04/02/2013 11:55 PM, Amos Jeffries wrote:
On 3/04/2013 3:55 a.m., Alex Rousskov wrote:
On 03/28/2013 12:41 AM, Amos Jeffries wrote:
New patch attached with the above small changes to conn-auth included.
Thanks for addressing all of my concerns,
Is that a +1?
Well, I cannot +1 this code
On 03/28/2013 12:41 AM, Amos Jeffries wrote:
New patch attached with the above small changes to conn-auth included.
Thanks for addressing all of my concerns,
Alex.
On 28/03/2013 7:50 a.m., Alex Rousskov wrote:
On 03/27/2013 05:38 AM, Amos Jeffries wrote:
On 27/03/2013 10:16 a.m., Alex Rousskov wrote:
On 03/25/2013 09:59 PM, Amos Jeffries wrote:
snip
+// clobbered with alternative credentials
+if (aur != credentialsState) {
+debugs(33,
On 27/03/2013 10:16 a.m., Alex Rousskov wrote:
On 03/25/2013 09:59 PM, Amos Jeffries wrote:
Bug 3643: NTLM helpers stuck in reserved state by Safari
NTLM failures are not always cleaning up connection-auth credentials
properly. In particular they are not releasing the NTLM helpers when
the
On 03/27/2013 05:38 AM, Amos Jeffries wrote:
On 27/03/2013 10:16 a.m., Alex Rousskov wrote:
On 03/25/2013 09:59 PM, Amos Jeffries wrote:
+private:
+/// state of some credentials that can be used to perform
authentication on this connection
+Auth::UserRequest::Pointer
On 03/25/2013 09:59 PM, Amos Jeffries wrote:
Bug 3643: NTLM helpers stuck in reserved state by Safari
NTLM failures are not always cleaning up connection-auth credentials
properly. In particular they are not releasing the NTLM helpers when
the connection is closed between challenge and