Re: Object naming conflict on nt branch

2003-03-11 Thread Robert Collins
On Tue, 2003-03-11 at 21:36, Guido Serassio wrote:


 Yes, but there is still a problem:
 
 max() and min() are already defined on Windows platform.

Ah, thats easy. Just protect their defines with 
#ifndef max
...

#endif 

and 
#ifndef min
...
#endif

-- 
GPG key available at: http://users.bigpond.net.au/robertc/keys.txt.


signature.asc
Description: This is a digitally signed message part


Re: Object naming conflict on nt branch

2003-03-11 Thread Guido Serassio
Hi Robert,

Il 11.41 11/03/2003 Robert Collins ha scritto:

On Tue, 2003-03-11 at 21:36, Guido Serassio wrote:

 Yes, but there is still a problem:

 max() and min() are already defined on Windows platform.
Ah, thats easy. Just protect their defines with
#ifndef max
...
#endif

and
#ifndef min
...
#endif
Yes, I have already made this, but this was FYI.

Regards

Guido



-
===
Serassio Guido
Via Albenga, 11/4   10134 - Torino - ITALY
E-mail: [EMAIL PROTECTED]
WWW: http://www.serassio.it


Re: Object naming conflict on nt branch

2003-03-10 Thread Robert Collins
On Mon, 2003-03-10 at 15:07, Adrian Chadd wrote:
 On Sun, Mar 09, 2003, Robert Collins wrote:
 
   This happens on all Windows build environments: Cygwin, MinGW and MS Visual 
   Studio.
  
  Dang. It's just *so hard* with MS polluting the namescape all the time.
  
  If we don't use the windows ACL type, just do this:
  
 
 Heh. Prefix everything with SQUID_ or squid_. Go namespace.

Urk. Goodbye readability.

Squid::ACL I'd consider ok, but only if we actually *use* the windows
ACL type.

Rob

-- 
GPG key available at: http://users.bigpond.net.au/robertc/keys.txt.


signature.asc
Description: This is a digitally signed message part


Re: Object naming conflict on nt branch

2003-03-10 Thread Robert Collins
On Tue, 2003-03-11 at 07:51, Guido Serassio wrote:

 
 What is wrong ?

I broke head merging ESI. I've fixed it now, and the next merge to the
devel tree will bring across the fixes.

Cheers,
Rob

-- 
GPG key available at: http://users.bigpond.net.au/robertc/keys.txt.


signature.asc
Description: This is a digitally signed message part


Re: Object naming conflict on nt branch

2003-03-10 Thread Guido Serassio
Hi Robert,

Il 22.02 10/03/2003 Robert Collins ha scritto:

On Tue, 2003-03-11 at 07:51, Guido Serassio wrote:


 What is wrong ?
I broke head merging ESI. I've fixed it now, and the next merge to the
devel tree will bring across the fixes.
Are You sure that ESI merge is the source of my problem ?
I don't have still merged latest ESI changes on nt branch.
Regards

Cheers,
Rob
--
GPG key available at: http://users.bigpond.net.au/robertc/keys.txt.


-
===
Serassio Guido
Via Albenga, 11/4   10134 - Torino - ITALY
E-mail: [EMAIL PROTECTED]
WWW: http://www.serassio.it


Re: Object naming conflict on nt branch

2003-03-10 Thread Henrik Nordstrom
On Monday 10 March 2003 21.51, Guido Serassio wrote:

 ACLMaxUserIP.cc:51:77: macro max requires 2 arguments, but only 1
 given ACLMaxUserIP.cc: In constructor
 `ACLMaxUserIP::ACLMaxUserIP(const char*)': ACLMaxUserIP.cc:52:
 parse error before `{' token

Another namespace conflict, this time in the form of a #define...

Regards
Henrik


Re: Object naming conflict on nt branch

2003-03-10 Thread Guido Serassio
Hi Robert,

Il 22.07 10/03/2003 Guido Serassio ha scritto:
Hi Robert,

Il 22.02 10/03/2003 Robert Collins ha scritto:

On Tue, 2003-03-11 at 07:51, Guido Serassio wrote:


 What is wrong ?
I broke head merging ESI. I've fixed it now, and the next merge to the
devel tree will bring across the fixes.
Are You sure that ESI merge is the source of my problem ?
I don't have still merged latest ESI changes on nt branch.
Yes, now it's correct.

Regards

Guido

Regards

Cheers,
Rob
--
GPG key available at: http://users.bigpond.net.au/robertc/keys.txt.


-
===
Serassio Guido
Via Albenga, 11/4   10134 - Torino - ITALY
E-mail: [EMAIL PROTECTED]
WWW: http://www.serassio.it


-
===
Serassio Guido
Via Albenga, 11/4   10134 - Torino - ITALY
E-mail: [EMAIL PROTECTED]
WWW: http://www.serassio.it


Re: Object naming conflict on nt branch

2003-03-10 Thread Guido Serassio
Hi Henrik,

Il 22.44 10/03/2003 Henrik Nordstrom ha scritto:

On Monday 10 March 2003 21.51, Guido Serassio wrote:

 ACLMaxUserIP.cc:51:77: macro max requires 2 arguments, but only 1
 given ACLMaxUserIP.cc: In constructor
 `ACLMaxUserIP::ACLMaxUserIP(const char*)': ACLMaxUserIP.cc:52:
 parse error before `{' token
Another namespace conflict, this time in the form of a #define...
True, but already fixed by Robert.

Regards

Guido


Regards
Henrik


-
===
Serassio Guido
Via Albenga, 11/4   10134 - Torino - ITALY
E-mail: [EMAIL PROTECTED]
WWW: http://www.serassio.it


Re: Object naming conflict on nt branch

2003-03-09 Thread Adrian Chadd
On Sun, Mar 09, 2003, Robert Collins wrote:

  This happens on all Windows build environments: Cygwin, MinGW and MS Visual 
  Studio.
 
 Dang. It's just *so hard* with MS polluting the namescape all the time.
 
 If we don't use the windows ACL type, just do this:
 

Heh. Prefix everything with SQUID_ or squid_. Go namespace.




Adrian